Remapping iInCircle and questionInCircle and deprecating help icon#223142
Merged
jbudz merged 102 commits intoelastic:mainfrom Jun 25, 2025
Merged
Remapping iInCircle and questionInCircle and deprecating help icon#223142jbudz merged 102 commits intoelastic:mainfrom
iInCircle and questionInCircle and deprecating help icon#223142jbudz merged 102 commits intoelastic:mainfrom
Conversation
This reverts commit cb230d8.
# Conflicts: # x-pack/platform/plugins/private/upgrade_assistant/public/application/components/es_deprecations/deprecation_types/data_streams/flyout/steps/confirm/warnings/warning_step_checkbox.tsx # x-pack/platform/plugins/private/upgrade_assistant/public/application/components/es_deprecations/deprecation_types/indices/flyout/steps/details/reindex_details_step.tsx # x-pack/solutions/observability/plugins/apm/public/components/shared/charts/log_rates/popover.tsx # x-pack/solutions/observability/plugins/inventory/public/components/entities_grid/grid_columns.tsx
Contributor
💔 Build Failed
Failed CI StepsTest Failures
Metrics [docs]Async chunks
Page load bundle
History
|
Contributor
|
Closing the loop... Thank you @ek-so
Sorry for my blindness and missing the issue—reading through that it looks like you have similar concerns as I do. I'm good with the icon change. My 'include alongside' comment was specific to adding a label to the doc link in header, but this isn't a blocker to me. Sorry for the noise. |
Contributor
|
Starting backport for target branches: 8.19 |
Contributor
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
This was referenced Jun 26, 2025
Member
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
tsullivan
pushed a commit
to tsullivan/kibana
that referenced
this pull request
Jun 26, 2025
…con (elastic#223142) ## Summary This PR closes the issue elastic#221380 and does 3 things: 1. Replaces all current usages of `iInCircle` with `info` (no visual changes) 2. Replaces all current usages of `questionInCircle` with `question`(no visual changes) 3. Replaces all current `help` icon usages with `question`(lifesaver icon replaced with question) ## Screenshots:    --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Anton Dosov <anton.dosov@elastic.co> (cherry picked from commit 0d21254) # Conflicts: # src/platform/packages/shared/content-management/content_editor/src/components/metadata_form.tsx # src/platform/packages/shared/shared-ux/chrome/navigation/src/ui/navigation.stories.tsx # src/platform/plugins/shared/inspector/public/views/requests/components/details/req_details_stats.tsx # src/platform/plugins/shared/saved_objects/public/save_modal/saved_object_save_modal.tsx # x-pack/platform/plugins/private/monitoring/public/components/chart/monitoring_timeseries_container.tsx # x-pack/platform/plugins/shared/content_connectors/public/components/connector_detail/components/advanced_config_override_callout.tsx # x-pack/platform/plugins/shared/content_connectors/public/components/connector_detail/components/example_config_callout.tsx # x-pack/platform/plugins/shared/content_connectors/public/components/connector_detail/components/waiting_for_connector_step.tsx # x-pack/platform/plugins/shared/content_connectors/public/components/connector_detail/overview.tsx # x-pack/platform/plugins/shared/content_connectors/public/components/connectors/create_connector/components/connector_description_popover.tsx # x-pack/platform/plugins/shared/content_connectors/public/components/search_index/connector/native_connector_configuration/native_connector_configuration_config.tsx # x-pack/platform/plugins/shared/content_connectors/public/components/search_index/connector/native_connector_configuration/research_configuration.tsx # x-pack/platform/plugins/shared/content_connectors/public/components/search_index/connector/sync_rules/connector_rules.tsx # x-pack/platform/plugins/shared/content_connectors/public/components/search_index/documents.tsx # x-pack/platform/plugins/shared/content_connectors/public/components/search_index/index_mappings.tsx # x-pack/platform/plugins/shared/content_connectors/public/components/shared/flash_messages/constants.ts # x-pack/platform/plugins/shared/content_connectors/public/components/shared/flash_messages/flash_messages.test.tsx # x-pack/platform/plugins/shared/fleet/public/applications/fleet/sections/agents/agent_details_page/components/agent_details/agent_details_overview.tsx # x-pack/platform/plugins/shared/fleet/public/applications/fleet/sections/agents/agent_list_page/components/agent_list_table.tsx # x-pack/platform/plugins/shared/fleet/public/applications/fleet/sections/settings/components/edit_output_flyout/output_form_remote_es.tsx # x-pack/platform/plugins/shared/fleet/public/applications/fleet/sections/settings/components/outputs_table/integration_status_badge.tsx # x-pack/platform/plugins/shared/fleet/public/applications/integrations/sections/epm/screens/installed_integrations/components/confirm_bulk_uninstall_modal.tsx # x-pack/platform/plugins/shared/fleet/public/applications/integrations/sections/epm/screens/installed_integrations/components/confirm_bulk_upgrade_modal.tsx # x-pack/platform/plugins/shared/ml/public/application/model_management/test_models/models/ner/ner_output.test.tsx # x-pack/platform/plugins/shared/ml/public/application/model_management/test_models/models/ner/ner_output.tsx # x-pack/solutions/chat/plugins/workchat-app/public/application/components/assistant/details/assistant_view.tsx # x-pack/solutions/chat/plugins/workchat-app/public/application/components/assistant/list/assistant_list_view.tsx # x-pack/solutions/chat/plugins/workchat-app/public/application/components/integrations/listing/integration_catalog_view.tsx # x-pack/solutions/observability/plugins/exploratory_view/public/components/shared/exploratory_view/header/last_updated.tsx # x-pack/solutions/observability/plugins/infra/public/pages/metrics/hosts/components/common/popover.tsx # x-pack/solutions/observability/plugins/infra/public/pages/metrics/hosts/components/search_bar/limit_options.tsx # x-pack/solutions/search/plugins/enterprise_search/public/applications/enterprise_search_content/components/connector_detail/overview.tsx # x-pack/solutions/search/plugins/serverless_search/public/application/components/connectors/connector_config/connector_link.tsx # x-pack/solutions/security/plugins/cloud_security_posture/public/pages/configurations/findings_flyout/findings_right/content.tsx # x-pack/solutions/security/plugins/security_solution/public/detection_engine/rule_exceptions/components/value_with_space_warning/__tests__/__snapshots__/value_with_space_warning.test.tsx.snap
Contributor
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
1 similar comment
Contributor
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
Contributor
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
tsullivan
added a commit
that referenced
this pull request
Jul 1, 2025
…help` icon (#223142) (#225535) # Backport This will backport the following commits from `main` to `8.19`: - [Remapping `iInCircle` and `questionInCircle` and deprecating `help` icon (#223142)](#223142) <!--- Backport version: 10.0.1 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Kate Sosedova","email":"36230123+ek-so@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-06-25T19:52:04Z","message":"Remapping `iInCircle` and `questionInCircle` and deprecating `help` icon (#223142)\n\n## Summary\n\nThis PR closes the issue https://github.com/elastic/kibana/issues/221380\nand does 3 things:\n1. Replaces all current usages of `iInCircle` with `info` (no visual\nchanges)\n2. Replaces all current usages of `questionInCircle` with `question`(no\nvisual changes)\n3. Replaces all current `help` icon usages with `question`(lifesaver\nicon replaced with question)\n\n## Screenshots:\n\n\n\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>\nCo-authored-by: Anton Dosov <anton.dosov@elastic.co>","sha":"0d2125427f81d2ebedcf7377e6b97da78f1b3cf8","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:enhancement","Team:Fleet","ci:project-deploy-observability","backport:version","v9.1.0","v8.19.0"],"title":"Remapping `iInCircle` and `questionInCircle` and deprecating `help` icon","number":223142,"url":"https://github.com/elastic/kibana/pull/223142","mergeCommit":{"message":"Remapping `iInCircle` and `questionInCircle` and deprecating `help` icon (#223142)\n\n## Summary\n\nThis PR closes the issue https://github.com/elastic/kibana/issues/221380\nand does 3 things:\n1. Replaces all current usages of `iInCircle` with `info` (no visual\nchanges)\n2. Replaces all current usages of `questionInCircle` with `question`(no\nvisual changes)\n3. Replaces all current `help` icon usages with `question`(lifesaver\nicon replaced with question)\n\n## Screenshots:\n\n\n\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>\nCo-authored-by: Anton Dosov <anton.dosov@elastic.co>","sha":"0d2125427f81d2ebedcf7377e6b97da78f1b3cf8"}},"sourceBranch":"main","suggestedTargetBranches":["8.19"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/223142","number":223142,"mergeCommit":{"message":"Remapping `iInCircle` and `questionInCircle` and deprecating `help` icon (#223142)\n\n## Summary\n\nThis PR closes the issue https://github.com/elastic/kibana/issues/221380\nand does 3 things:\n1. Replaces all current usages of `iInCircle` with `info` (no visual\nchanges)\n2. Replaces all current usages of `questionInCircle` with `question`(no\nvisual changes)\n3. Replaces all current `help` icon usages with `question`(lifesaver\nicon replaced with question)\n\n## Screenshots:\n\n\n\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>\nCo-authored-by: Anton Dosov <anton.dosov@elastic.co>","sha":"0d2125427f81d2ebedcf7377e6b97da78f1b3cf8"}},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> --------- Co-authored-by: Kate Sosedova <36230123+ek-so@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR closes the issue #221380 and does 3 things:
iInCirclewithinfo(no visual changes)questionInCirclewithquestion(no visual changes)helpicon usages withquestion(lifesaver icon replaced with question)Screenshots: