Skip to content

Commit fff8925

Browse files
ek-soek-so
committed
Remapping iInCircle and questionInCircle and deprecating help icon (#223142)
## Summary This PR closes the issue #221380 and does 3 things: 1. Replaces all current usages of `iInCircle` with `info` (no visual changes) 2. Replaces all current usages of `questionInCircle` with `question`(no visual changes) 3. Replaces all current `help` icon usages with `question`(lifesaver icon replaced with question) ## Screenshots: ![CleanShot 2025-06-18 at 10 34 01@2x](https://github.com/user-attachments/assets/4379e51e-7422-4570-b452-c17ee26f2d64) ![CleanShot 2025-06-18 at 10 34 13@2x](https://github.com/user-attachments/assets/270056c7-4502-47ef-874f-862149fa27ec) ![CleanShot 2025-06-18 at 10 34 04@2x](https://github.com/user-attachments/assets/1dff8faf-65b7-4208-b568-7718b1a6b729) --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Anton Dosov <anton.dosov@elastic.co> (cherry picked from commit 0d21254) # Conflicts: # src/platform/packages/shared/content-management/content_editor/src/components/metadata_form.tsx # src/platform/packages/shared/shared-ux/chrome/navigation/src/ui/navigation.stories.tsx # src/platform/plugins/shared/inspector/public/views/requests/components/details/req_details_stats.tsx # src/platform/plugins/shared/saved_objects/public/save_modal/saved_object_save_modal.tsx # x-pack/platform/plugins/private/monitoring/public/components/chart/monitoring_timeseries_container.tsx # x-pack/platform/plugins/shared/content_connectors/public/components/connector_detail/components/advanced_config_override_callout.tsx # x-pack/platform/plugins/shared/content_connectors/public/components/connector_detail/components/example_config_callout.tsx # x-pack/platform/plugins/shared/content_connectors/public/components/connector_detail/components/waiting_for_connector_step.tsx # x-pack/platform/plugins/shared/content_connectors/public/components/connector_detail/overview.tsx # x-pack/platform/plugins/shared/content_connectors/public/components/connectors/create_connector/components/connector_description_popover.tsx # x-pack/platform/plugins/shared/content_connectors/public/components/search_index/connector/native_connector_configuration/native_connector_configuration_config.tsx # x-pack/platform/plugins/shared/content_connectors/public/components/search_index/connector/native_connector_configuration/research_configuration.tsx # x-pack/platform/plugins/shared/content_connectors/public/components/search_index/connector/sync_rules/connector_rules.tsx # x-pack/platform/plugins/shared/content_connectors/public/components/search_index/documents.tsx # x-pack/platform/plugins/shared/content_connectors/public/components/search_index/index_mappings.tsx # x-pack/platform/plugins/shared/content_connectors/public/components/shared/flash_messages/constants.ts # x-pack/platform/plugins/shared/content_connectors/public/components/shared/flash_messages/flash_messages.test.tsx # x-pack/platform/plugins/shared/fleet/public/applications/fleet/sections/agents/agent_details_page/components/agent_details/agent_details_overview.tsx # x-pack/platform/plugins/shared/fleet/public/applications/fleet/sections/agents/agent_list_page/components/agent_list_table.tsx # x-pack/platform/plugins/shared/fleet/public/applications/fleet/sections/settings/components/edit_output_flyout/output_form_remote_es.tsx # x-pack/platform/plugins/shared/fleet/public/applications/fleet/sections/settings/components/outputs_table/integration_status_badge.tsx # x-pack/platform/plugins/shared/fleet/public/applications/integrations/sections/epm/screens/installed_integrations/components/confirm_bulk_uninstall_modal.tsx # x-pack/platform/plugins/shared/fleet/public/applications/integrations/sections/epm/screens/installed_integrations/components/confirm_bulk_upgrade_modal.tsx # x-pack/platform/plugins/shared/ml/public/application/model_management/test_models/models/ner/ner_output.test.tsx # x-pack/platform/plugins/shared/ml/public/application/model_management/test_models/models/ner/ner_output.tsx # x-pack/solutions/chat/plugins/workchat-app/public/application/components/assistant/details/assistant_view.tsx # x-pack/solutions/chat/plugins/workchat-app/public/application/components/assistant/list/assistant_list_view.tsx # x-pack/solutions/chat/plugins/workchat-app/public/application/components/integrations/listing/integration_catalog_view.tsx # x-pack/solutions/observability/plugins/exploratory_view/public/components/shared/exploratory_view/header/last_updated.tsx # x-pack/solutions/observability/plugins/infra/public/pages/metrics/hosts/components/common/popover.tsx # x-pack/solutions/observability/plugins/infra/public/pages/metrics/hosts/components/search_bar/limit_options.tsx # x-pack/solutions/search/plugins/enterprise_search/public/applications/enterprise_search_content/components/connector_detail/overview.tsx # x-pack/solutions/search/plugins/serverless_search/public/application/components/connectors/connector_config/connector_link.tsx # x-pack/solutions/security/plugins/cloud_security_posture/public/pages/configurations/findings_flyout/findings_right/content.tsx # x-pack/solutions/security/plugins/security_solution/public/detection_engine/rule_exceptions/components/value_with_space_warning/__tests__/__snapshots__/value_with_space_warning.test.tsx.snap
1 parent f87a8ca commit fff8925

621 files changed

Lines changed: 1162 additions & 1241 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎examples/search_examples/public/search_sessions/app.tsx‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -791,7 +791,7 @@ function NoShardDelayCallout() {
791791
</>
792792
}
793793
color="warning"
794-
iconType="help"
794+
iconType="question"
795795
>
796796
<p>
797797
This demo works best with <EuiCode>shardDelay</EuiCode> aggregation which simulates slow
@@ -807,7 +807,7 @@ function NoShardDelayCallout() {
807807

808808
function NoDataViewsCallout() {
809809
return (
810-
<EuiCallOut title={<>Missing data views!</>} color="warning" iconType="help">
810+
<EuiCallOut title={<>Missing data views!</>} color="warning" iconType="question">
811811
<p>This demo requires at least one data view.</p>
812812
</EuiCallOut>
813813
);

‎src/core/packages/chrome/browser-internal/src/ui/header/__snapshots__/header.test.tsx.snap‎

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎src/core/packages/chrome/browser-internal/src/ui/header/header_help_menu.tsx‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -156,7 +156,7 @@ class HelpMenu extends Component<Props & WithEuiThemeProps, State> {
156156
})}
157157
onClick={this.onMenuButtonClick}
158158
>
159-
<EuiIcon type="help" size="m" />
159+
<EuiIcon type="question" size="m" />
160160
</EuiHeaderSectionItemButton>
161161
);
162162

‎src/core/packages/notifications/browser-internal/src/toasts/toasts_api.tsx‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,7 @@ export class ToastsApi implements IToasts {
124124
public addInfo(toastOrTitle: ToastInput, options?: ToastOptions) {
125125
return this.add({
126126
color: 'primary',
127-
iconType: 'iInCircle',
127+
iconType: 'info',
128128
...normalizeToast(toastOrTitle),
129129
...options,
130130
});

‎src/core/packages/overlays/browser-internal/src/banners/user_banner_service.tsx‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ export class UserBannerService {
7474
defaultMessage="Attention"
7575
/>
7676
}
77-
iconType="help"
77+
iconType="question"
7878
>
7979
<React.Suspense
8080
fallback={

‎src/platform/packages/shared/cloud/connection_details/tabs/api_keys_tab/views/missing_permissions_panel.tsx‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ export const MissingPermissionsPanel: React.FC = () => {
1717
<>
1818
<EuiCallOut
1919
color={'warning'}
20-
iconType={'iInCircle'}
20+
iconType={'info'}
2121
title={i18n.translate('cloud.connectionDetails.tabs.apiKeys.missingPermPanel.title', {
2222
defaultMessage: 'Missing permissions',
2323
})}

‎src/platform/packages/shared/cloud/connection_details/tabs/endpoints_tab/rows/cloud_id_row/label.tsx‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ export const Label: React.FC<{ learnMoreUrl?: string }> = ({ learnMoreUrl }) =>
4141
<EuiPopover
4242
button={
4343
<EuiButtonIcon
44-
iconType="questionInCircle"
44+
iconType="question"
4545
onClick={() => {
4646
setIsPopoverOpen((x) => !x);
4747
}}

‎src/platform/packages/shared/cloud/deployment_details/deployment_details_cloudid_input.tsx‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ const Label: FC<{ learnMoreUrl: string }> = ({ learnMoreUrl }) => {
4646
<EuiPopover
4747
button={
4848
<EuiButtonIcon
49-
iconType="questionInCircle"
49+
iconType="question"
5050
onClick={() => {
5151
setIsPopoverOpen(true);
5252
}}

‎src/platform/packages/shared/content-management/content_editor/src/components/editor_flyout_content.tsx‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -148,7 +148,7 @@ export const ContentEditorFlyoutContent: FC<Props> = ({
148148
<EuiFlyoutHeader>
149149
<EuiTitle data-test-subj="flyoutTitle">
150150
<h2>
151-
<EuiIcon type="iInCircle" css={iconCSS} size="l" />
151+
<EuiIcon type="info" css={iconCSS} size="l" />
152152
<span>{title}</span>
153153
</h2>
154154
</EuiTitle>

‎src/platform/packages/shared/content-management/content_insights/content_insights_public/src/components/views_stats/views_stats.tsx‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ const NoViewsTip = () => {
8484
color="inherit"
8585
iconProps={{ style: { verticalAlign: 'text-bottom', marginLeft: 2 } }}
8686
css={{ textWrap: 'balance' }}
87-
type="questionInCircle"
87+
type="question"
8888
content={
8989
<>
9090
<FormattedMessage

0 commit comments

Comments
 (0)