[upgrade assistant] Create upgrade-assistant package, stub out storybook usage#218705
Merged
mattkime merged 18 commits intoelastic:mainfrom Apr 28, 2025
Merged
[upgrade assistant] Create upgrade-assistant package, stub out storybook usage#218705mattkime merged 18 commits intoelastic:mainfrom
mattkime merged 18 commits intoelastic:mainfrom
Conversation
…e/kibana into upgrade_assistant_storybook_stub
Contributor
|
Pinging @elastic/kibana-management (Team:Kibana Management) |
jbudz
approved these changes
Apr 21, 2025
ElenaStoeva
approved these changes
Apr 24, 2025
Contributor
ElenaStoeva
left a comment
There was a problem hiding this comment.
Changes lgtm with a few small suggestions.
x-pack/platform/packages/private/upgrade-assistant/src/components/deprecation_badge.stories.tsx
Show resolved
Hide resolved
…nts/deprecation_badge.stories.tsx Co-authored-by: Elena Stoeva <59341489+ElenaStoeva@users.noreply.github.com>
Co-authored-by: Elena Stoeva <59341489+ElenaStoeva@users.noreply.github.com>
…e/kibana into upgrade_assistant_storybook_stub
Contributor
|
Starting backport for target branches: 8.19 |
Contributor
💚 Build Succeeded
Metrics [docs]Module Count
Public APIs missing comments
Async chunks
Page load bundle
History
cc @mattkime |
Contributor
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
Contributor
Author
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
mattkime
added a commit
to mattkime/kibana
that referenced
this pull request
Apr 28, 2025
…ook usage (elastic#218705) ## Summary This PR creates an `upgrade-assistant` package, moves a component to the package, and creates a storybook story for it. Run `yarn storybook upgrade_assistant` to see it. The intention is to make it easier to work on upgrade assistant components in isolation from kibana and the state necessary to display them. --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Elena Stoeva <59341489+ElenaStoeva@users.noreply.github.com> (cherry picked from commit 6d96c1a) # Conflicts: # .github/CODEOWNERS # src/dev/storybook/aliases.ts # x-pack/.i18nrc.json # x-pack/platform/plugins/private/upgrade_assistant/tsconfig.json
This was referenced Apr 29, 2025
Contributor
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
This was referenced Apr 30, 2025
Contributor
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
1 task
Contributor
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
1 similar comment
Contributor
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
Contributor
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
1 task
Contributor
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
1 task
Contributor
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
mattkime
added a commit
that referenced
this pull request
May 9, 2025
… storybook usage (#218705) (#219453) # Backport This will backport the following commits from `main` to `8.19`: - [[upgrade assistant] Create upgrade-assistant package, stub out storybook usage (#218705)](#218705) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Matthew Kime","email":"matt@mattki.me"},"sourceCommit":{"committedDate":"2025-04-28T18:45:43Z","message":"[upgrade assistant] Create upgrade-assistant package, stub out storybook usage (#218705)\n\n## Summary\n\nThis PR creates an `upgrade-assistant` package, moves a component to the\npackage, and creates a storybook story for it. Run `yarn storybook\nupgrade_assistant` to see it.\n\nThe intention is to make it easier to work on upgrade assistant\ncomponents in isolation from kibana and the state necessary to display\nthem.\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\nCo-authored-by: Elena Stoeva <59341489+ElenaStoeva@users.noreply.github.com>","sha":"6d96c1a3df964b8df2374f07f424756aa6f40b4e","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Kibana Management","release_note:skip","Feature:Upgrade Assistant","backport:version","v9.1.0","v8.19.0"],"title":"[upgrade assistant] Create upgrade-assistant package, stub out storybook usage","number":218705,"url":"https://github.com/elastic/kibana/pull/218705","mergeCommit":{"message":"[upgrade assistant] Create upgrade-assistant package, stub out storybook usage (#218705)\n\n## Summary\n\nThis PR creates an `upgrade-assistant` package, moves a component to the\npackage, and creates a storybook story for it. Run `yarn storybook\nupgrade_assistant` to see it.\n\nThe intention is to make it easier to work on upgrade assistant\ncomponents in isolation from kibana and the state necessary to display\nthem.\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\nCo-authored-by: Elena Stoeva <59341489+ElenaStoeva@users.noreply.github.com>","sha":"6d96c1a3df964b8df2374f07f424756aa6f40b4e"}},"sourceBranch":"main","suggestedTargetBranches":["8.19"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/218705","number":218705,"mergeCommit":{"message":"[upgrade assistant] Create upgrade-assistant package, stub out storybook usage (#218705)\n\n## Summary\n\nThis PR creates an `upgrade-assistant` package, moves a component to the\npackage, and creates a storybook story for it. Run `yarn storybook\nupgrade_assistant` to see it.\n\nThe intention is to make it easier to work on upgrade assistant\ncomponents in isolation from kibana and the state necessary to display\nthem.\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\nCo-authored-by: Elena Stoeva <59341489+ElenaStoeva@users.noreply.github.com>","sha":"6d96c1a3df964b8df2374f07f424756aa6f40b4e"}},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
akowalska622
pushed a commit
to akowalska622/kibana
that referenced
this pull request
May 29, 2025
…ook usage (elastic#218705) ## Summary This PR creates an `upgrade-assistant` package, moves a component to the package, and creates a storybook story for it. Run `yarn storybook upgrade_assistant` to see it. The intention is to make it easier to work on upgrade assistant components in isolation from kibana and the state necessary to display them. --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Elena Stoeva <59341489+ElenaStoeva@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR creates an
upgrade-assistantpackage, moves a component to the package, and creates a storybook story for it. Runyarn storybook upgrade_assistantto see it.The intention is to make it easier to work on upgrade assistant components in isolation from kibana and the state necessary to display them.