Skip to content

[8.19] [upgrade assistant] Create upgrade-assistant package, stub out storybook usage (#218705)#219453

Merged
mattkime merged 10 commits intoelastic:8.19from
mattkime:backport/8.19/pr-218705
May 9, 2025
Merged

[8.19] [upgrade assistant] Create upgrade-assistant package, stub out storybook usage (#218705)#219453
mattkime merged 10 commits intoelastic:8.19from
mattkime:backport/8.19/pr-218705

Conversation

@mattkime
Copy link
Copy Markdown
Contributor

@mattkime mattkime commented Apr 28, 2025

Backport

This will backport the following commits from main to 8.19:

Questions ?

Please refer to the Backport tool documentation

@mattkime
[upgrade assistant] Create upgrade-assistant package, stub out storyb…
3656201 
…ook usage (elastic#218705)

## Summary

This PR creates an `upgrade-assistant` package, moves a component to the
package, and creates a storybook story for it. Run `yarn storybook
upgrade_assistant` to see it.

The intention is to make it easier to work on upgrade assistant
components in isolation from kibana and the state necessary to display
them.

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Elena Stoeva <59341489+ElenaStoeva@users.noreply.github.com>
(cherry picked from commit 6d96c1a)

# Conflicts:
#	.github/CODEOWNERS
#	src/dev/storybook/aliases.ts
#	x-pack/.i18nrc.json
#	x-pack/platform/plugins/private/upgrade_assistant/tsconfig.json
@mattkime mattkime requested a review from kibanamachine as a code owner April 28, 2025 19:52
@mattkime mattkime added the backport This PR is a backport of another PR label Apr 28, 2025
@mattkime mattkime enabled auto-merge (squash) April 28, 2025 19:52
@mattkime mattkime mentioned this pull request Apr 28, 2025
Merged
@mattkime
Copy link
Copy Markdown
Contributor Author

mattkime commented May 7, 2025

/ci

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented May 7, 2025

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
upgradeAssistant 168 170 +2

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/upgrade-assistant - 3 +3

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
@kbn/upgrade-assistant - 1 +1
Unknown metric groups

API count

id before after diff
@kbn/upgrade-assistant - 3 +3

History

@ElenaStoeva ElenaStoeva self-requested a review May 7, 2025 16:19
ElenaStoeva
ElenaStoeva approved these changes May 9, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@ElenaStoeva ElenaStoeva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this backport PR @mattkime! Code changes and stories lgtm with one small comment.

x-pack/platform/packages/private/upgrade-assistant/src/components/deprecation_badge.stories.tsx

type Story = StoryObj<typeof DeprecationBadge>;

export const Basic: Story = {};
Copy link
Copy Markdown
Contributor

@ElenaStoeva ElenaStoeva May 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we create this additional Basic story?

Copy link
Copy Markdown
Contributor

@ElenaStoeva ElenaStoeva May 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I didn't realize that auto-merge was enabled and approved in advance. I suppose it's not such a big issue if we have this extra story.

Copy link
Copy Markdown
Contributor Author

@mattkime mattkime May 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why, I'm working on another follow up where I might address this.

@mattkime mattkime merged commit f5a3844 into elastic:8.19 May 9, 2025
8 of 9 checks passed
@mattkime mattkime mentioned this pull request May 9, 2025
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ElenaStoeva ElenaStoeva ElenaStoeva approved these changes

@kibanamachine kibanamachine Awaiting requested review from kibanamachine kibanamachine is a code owner

Assignees

No one assigned

Labels

backport This PR is a backport of another PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mattkime @elasticmachine @ElenaStoeva @kibanamachine