[Lens][Datatable] Fix color by value for Last value array mode#213917
Merged
dej611 merged 4 commits intoelastic:mainfrom Mar 18, 2025
Merged
[Lens][Datatable] Fix color by value for Last value array mode#213917dej611 merged 4 commits intoelastic:mainfrom
dej611 merged 4 commits intoelastic:mainfrom
Conversation
Contributor
|
Pinging @elastic/kibana-visualizations (Team:Visualizations) |
Contributor
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Page load bundle
History
cc @dej611 |
markov00
reviewed
Mar 17, 2025
...platform/plugins/shared/lens/public/visualizations/datatable/components/dimension_editor.tsx
Show resolved
Hide resolved
x-pack/platform/plugins/shared/lens/public/visualizations/datatable/visualization.tsx
Show resolved
Hide resolved
markov00
approved these changes
Mar 17, 2025
Contributor
|
Starting backport for target branches: 8.18, 8.x, 9.0 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Mar 18, 2025
…ic#213917) ## Summary Fixes the table side of elastic#188263 The [fix used for `Metric`](elastic#209110) has been generalized and re-used for the datatable visualization.  ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit 0b9df09)
Contributor
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Mar 18, 2025
…213917) (#214919) # Backport This will backport the following commits from `main` to `9.0`: - [[Lens][Datatable] Fix color by value for Last value array mode (#213917)](#213917) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Marco Liberati","email":"dej611@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-03-18T09:09:03Z","message":"[Lens][Datatable] Fix color by value for Last value array mode (#213917)\n\n## Summary\n\nFixes the table side of #188263 \n\nThe [fix used for\n`Metric`](#209110) has been\ngeneralized and re-used for the datatable visualization.\n\n\n\n\n\n### Checklist\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios","sha":"0b9df094d1770065f79c05272a41175396caa27b","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Visualizations","Feature:Lens","backport:version","v9.1.0","v8.19.0","v8.18.1","v9.0.1"],"title":"[Lens][Datatable] Fix color by value for Last value array mode","number":213917,"url":"https://github.com/elastic/kibana/pull/213917","mergeCommit":{"message":"[Lens][Datatable] Fix color by value for Last value array mode (#213917)\n\n## Summary\n\nFixes the table side of #188263 \n\nThe [fix used for\n`Metric`](#209110) has been\ngeneralized and re-used for the datatable visualization.\n\n\n\n\n\n### Checklist\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios","sha":"0b9df094d1770065f79c05272a41175396caa27b"}},"sourceBranch":"main","suggestedTargetBranches":["8.x","8.18","9.0"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/213917","number":213917,"mergeCommit":{"message":"[Lens][Datatable] Fix color by value for Last value array mode (#213917)\n\n## Summary\n\nFixes the table side of #188263 \n\nThe [fix used for\n`Metric`](#209110) has been\ngeneralized and re-used for the datatable visualization.\n\n\n\n\n\n### Checklist\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios","sha":"0b9df094d1770065f79c05272a41175396caa27b"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.0","label":"v9.0.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Marco Liberati <dej611@users.noreply.github.com>
37 tasks
clintandrewhall
pushed a commit
to clintandrewhall/kibana
that referenced
this pull request
Mar 20, 2025
…ic#213917) ## Summary Fixes the table side of elastic#188263 The [fix used for `Metric`](elastic#209110) has been generalized and re-used for the datatable visualization.  ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Mar 22, 2025
…ic#213917) ## Summary Fixes the table side of elastic#188263 The [fix used for `Metric`](elastic#209110) has been generalized and re-used for the datatable visualization.  ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
nickofthyme
pushed a commit
to nickofthyme/kibana
that referenced
this pull request
Mar 27, 2025
…ic#213917) ## Summary Fixes the table side of elastic#188263 The [fix used for `Metric`](elastic#209110) has been generalized and re-used for the datatable visualization.  ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit 0b9df09) # Conflicts: # x-pack/platform/plugins/shared/lens/public/shared_components/coloring/utils.ts # x-pack/platform/plugins/shared/lens/public/visualizations/datatable/components/dimension_editor.test.tsx # x-pack/platform/plugins/shared/lens/public/visualizations/datatable/visualization.tsx # x-pack/platform/plugins/shared/lens/public/visualizations/metric/dimension_editor.tsx
This was referenced Mar 27, 2025
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
nickofthyme
pushed a commit
to nickofthyme/kibana
that referenced
this pull request
Mar 27, 2025
…ic#213917) ## Summary Fixes the table side of elastic#188263 The [fix used for `Metric`](elastic#209110) has been generalized and re-used for the datatable visualization.  ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit 0b9df09) # Conflicts: # x-pack/platform/plugins/shared/lens/public/shared_components/coloring/utils.ts # x-pack/platform/plugins/shared/lens/public/visualizations/datatable/components/dimension_editor.test.tsx # x-pack/platform/plugins/shared/lens/public/visualizations/datatable/visualization.tsx # x-pack/platform/plugins/shared/lens/public/visualizations/metric/dimension_editor.tsx
nickofthyme
added a commit
that referenced
this pull request
Mar 27, 2025
…#213917) (#216118) # Backport This will backport the following commits from `main` to `8.18`: - [[Lens][Datatable] Fix color by value for Last value array mode (#213917)](#213917) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Marco Liberati","email":"dej611@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-03-18T09:09:03Z","message":"[Lens][Datatable] Fix color by value for Last value array mode (#213917)\n\n## Summary\n\nFixes the table side of #188263 \n\nThe [fix used for\n`Metric`](#209110) has been\ngeneralized and re-used for the datatable visualization.\n\n\n\n\n\n### Checklist\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios","sha":"0b9df094d1770065f79c05272a41175396caa27b","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Visualizations","Feature:Lens","v9.0.0","backport:version","v9.1.0","v8.19.0","v8.18.1","v9.0.1"],"title":"[Lens][Datatable] Fix color by value for Last value array mode","number":213917,"url":"https://github.com/elastic/kibana/pull/213917","mergeCommit":{"message":"[Lens][Datatable] Fix color by value for Last value array mode (#213917)\n\n## Summary\n\nFixes the table side of #188263 \n\nThe [fix used for\n`Metric`](#209110) has been\ngeneralized and re-used for the datatable visualization.\n\n\n\n\n\n### Checklist\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios","sha":"0b9df094d1770065f79c05272a41175396caa27b"}},"sourceBranch":"main","suggestedTargetBranches":["8.x","8.18"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/214919","number":214919,"state":"MERGED","mergeCommit":{"sha":"ce776eca54a3b56d07d2404486162d5050098d26","message":"[9.0] [Lens][Datatable] Fix color by value for Last value array mode (#213917) (#214919)\n\n# Backport\n\nThis will backport the following commits from `main` to `9.0`:\n- [[Lens][Datatable] Fix color by value for Last value array mode\n(#213917)](https://github.com/elastic/kibana/pull/213917)\n\n\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sorenlouv/backport)\n\n\n\nCo-authored-by: Marco Liberati <dej611@users.noreply.github.com>"}},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/213917","number":213917,"mergeCommit":{"message":"[Lens][Datatable] Fix color by value for Last value array mode (#213917)\n\n## Summary\n\nFixes the table side of #188263 \n\nThe [fix used for\n`Metric`](#209110) has been\ngeneralized and re-used for the datatable visualization.\n\n\n\n\n\n### Checklist\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios","sha":"0b9df094d1770065f79c05272a41175396caa27b"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Marco Liberati <dej611@users.noreply.github.com>
Contributor
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
nickofthyme
added a commit
that referenced
this pull request
Mar 28, 2025
…213917) (#216117) # Backport This will backport the following commits from `main` to `8.x`: - [[Lens][Datatable] Fix color by value for Last value array mode (#213917)](#213917) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Marco Liberati","email":"dej611@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-03-18T09:09:03Z","message":"[Lens][Datatable] Fix color by value for Last value array mode (#213917)\n\n## Summary\n\nFixes the table side of #188263 \n\nThe [fix used for\n`Metric`](#209110) has been\ngeneralized and re-used for the datatable visualization.\n\n\n\n\n\n### Checklist\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios","sha":"0b9df094d1770065f79c05272a41175396caa27b","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Visualizations","Feature:Lens","v9.0.0","backport:version","v9.1.0","v8.19.0","v8.18.1","v9.0.1"],"title":"[Lens][Datatable] Fix color by value for Last value array mode","number":213917,"url":"https://github.com/elastic/kibana/pull/213917","mergeCommit":{"message":"[Lens][Datatable] Fix color by value for Last value array mode (#213917)\n\n## Summary\n\nFixes the table side of #188263 \n\nThe [fix used for\n`Metric`](#209110) has been\ngeneralized and re-used for the datatable visualization.\n\n\n\n\n\n### Checklist\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios","sha":"0b9df094d1770065f79c05272a41175396caa27b"}},"sourceBranch":"main","suggestedTargetBranches":["8.x","8.18"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/214919","number":214919,"state":"MERGED","mergeCommit":{"sha":"ce776eca54a3b56d07d2404486162d5050098d26","message":"[9.0] [Lens][Datatable] Fix color by value for Last value array mode (#213917) (#214919)\n\n# Backport\n\nThis will backport the following commits from `main` to `9.0`:\n- [[Lens][Datatable] Fix color by value for Last value array mode\n(#213917)](https://github.com/elastic/kibana/pull/213917)\n\n\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sorenlouv/backport)\n\n\n\nCo-authored-by: Marco Liberati <dej611@users.noreply.github.com>"}},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/213917","number":213917,"mergeCommit":{"message":"[Lens][Datatable] Fix color by value for Last value array mode (#213917)\n\n## Summary\n\nFixes the table side of #188263 \n\nThe [fix used for\n`Metric`](#209110) has been\ngeneralized and re-used for the datatable visualization.\n\n\n\n\n\n### Checklist\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios","sha":"0b9df094d1770065f79c05272a41175396caa27b"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Marco Liberati <dej611@users.noreply.github.com>
cqliu1
pushed a commit
to cqliu1/kibana
that referenced
this pull request
Mar 31, 2025
…ic#213917) ## Summary Fixes the table side of elastic#188263 The [fix used for `Metric`](elastic#209110) has been generalized and re-used for the datatable visualization.  ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the table side of #188263
The fix used for
Metrichas been generalized and re-used for the datatable visualization.Checklist