Skip to content

[8.18] [Lens][Datatable] Fix color by value for Last value array mode (#213917)#216118

Merged
nickofthyme merged 1 commit intoelastic:8.18from
nickofthyme:backport/8.18/pr-213917
Mar 27, 2025
Merged

[8.18] [Lens][Datatable] Fix color by value for Last value array mode (#213917)#216118
nickofthyme merged 1 commit intoelastic:8.18from
nickofthyme:backport/8.18/pr-213917

Conversation

@nickofthyme
Copy link
Copy Markdown
Contributor

Backport

This will backport the following commits from main to 8.18:

Questions ?

Please refer to the Backport tool documentation

…ic#213917)

## Summary

Fixes the table side of elastic#188263

The [fix used for
`Metric`](elastic#209110) has been
generalized and re-used for the datatable visualization.

![color_by_value_table](https://github.com/user-attachments/assets/b347dba2-24d7-4233-8c0c-3236f5212f35)

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

(cherry picked from commit 0b9df09)

# Conflicts:
#	x-pack/platform/plugins/shared/lens/public/shared_components/coloring/utils.ts
#	x-pack/platform/plugins/shared/lens/public/visualizations/datatable/components/dimension_editor.test.tsx
#	x-pack/platform/plugins/shared/lens/public/visualizations/datatable/visualization.tsx
#	x-pack/platform/plugins/shared/lens/public/visualizations/metric/dimension_editor.tsx
@nickofthyme nickofthyme added the backport This PR is a backport of another PR label Mar 27, 2025
@nickofthyme nickofthyme enabled auto-merge (squash) March 27, 2025 01:00
@elasticmachine
Copy link
Copy Markdown
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #19 / maps app geo file upload shapefile upload should add as document layer

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
lens 1563 1562 -1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
lens 1.5MB 1.5MB +104.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
lens 49.7KB 49.7KB +13.0B

@nickofthyme nickofthyme merged commit 306c26e into elastic:8.18 Mar 27, 2025
11 checks passed
@nickofthyme nickofthyme deleted the backport/8.18/pr-213917 branch March 27, 2025 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants