[Security Solution] Adds prebuilt rule import/export cypress tests#212172
Merged
banderror merged 1 commit intoelastic:mainfrom Feb 24, 2025
Merged
[Security Solution] Adds prebuilt rule import/export cypress tests#212172banderror merged 1 commit intoelastic:mainfrom
banderror merged 1 commit intoelastic:mainfrom
Conversation
Contributor
|
Pinging @elastic/security-detections-response (Team:Detections and Resp) |
Contributor
|
Pinging @elastic/security-detection-rule-management (Team:Detection Rule Management) |
Contributor
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
22b6655 to
d0ad5ce
Compare
Contributor
💚 Build Succeeded
Metrics [docs]
History
cc @dplumlee |
Contributor
Flaky Test Runner Stats🎉 All tests passed! - kibana-flaky-test-suite-runner#7923[✅] Security Solution Rule Management - Prebuilt Rules - Cypress: 50/50 tests passed. |
Contributor
Flaky Test Runner Stats🎉 All tests passed! - kibana-flaky-test-suite-runner#7924[✅] [Serverless] Security Solution Rule Management - Prebuilt Rules - Cypress: 50/50 tests passed. |
18 tasks
banderror
approved these changes
Feb 24, 2025
Contributor
banderror
left a comment
There was a problem hiding this comment.
I reviewed the changes, and this test coverage makes sense to me.
Further improvements I'm going to do in follow-up PRs:
- Make sure that the coverage is comprehensive.
- Optimize the test setup. Some "read-only" checks could share the same data set up only once for all tests in a group.
- Consider splitting the tests into more detailed and cohesive files if it helps to optimize the test setup.
- Probably something else that I'm missing at the moment.
The Flaky Test Runner looks satisfied, so I'm good with merging 👍
Comment on lines
+58
to
+68
| beforeEach(() => { | ||
| login(); | ||
| deleteAlertsAndRules(); | ||
| cy.intercept('POST', '/api/detection_engine/rules/_bulk_action').as('bulk_action'); | ||
| /* Create a new rule and install it */ | ||
| createAndInstallMockedPrebuiltRules([PREBUILT_RULE]); | ||
| createRule( | ||
| getNewRule({ name: 'Custom rule to export', rule_id: 'custom_rule_id', enabled: false }) | ||
| ).as('customRuleResponse'); | ||
| visitRulesManagementTable(); | ||
| }); |
Contributor
There was a problem hiding this comment.
Same idea: we could set up the test data (rule assets, rules) only once for the whole test file, and then in each test only do the "act" (export) and "assert" phases.
| }, | ||
| }, | ||
| () => { | ||
| describe('when file is unmodified prebuilt rule with matching rule_id', () => { |
Contributor
There was a problem hiding this comment.
I think we could combine both tests in this file into a single test, where we'd test importing a combination of different rules:
- prebuilt non-customized with a base version available, but without the rule being installed
- prebuilt customized with a base version available, but without the rule being installed
- plus the same, but with the rule being already installed
- plus the same, but with a missing base version
- custom
It could be a small number of cohesive tests too, but the point is to test importing multiple different rules at once - that's how we make these tests faster, lighter, and more high-level.
We will have single-purpose scenarios automated at the API integration level.
Contributor
There was a problem hiding this comment.
Let's put this file near the test file itself. It's not and shouldn't be reusable, so there's no need to "share" it in this fixtures folder with the rest of Security teams.
| tags: [...(getExistingRule().tags || []), 'edited'], | ||
| }); | ||
|
|
||
| export const expectedExportedRules = (responses: Array<Cypress.Response<RuleResponse>>): string => { |
Contributor
There was a problem hiding this comment.
Why do we duplicate the code of the expectedExportedRule function?
Contributor
Author
There was a problem hiding this comment.
This diff looks kind of weird but it's abstracting it out into 2 functions and just keeping the shared logic as a separate helper. Could probably just be changed into one expectedExportedRules function
Contributor
|
Starting backport for target branches: 8.18, 8.x, 9.0 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 24, 2025
…lastic#212172) **Partially addresses:** elastic#202079 ## Summary Adds cypress tests in accordance to elastic#204889 Follow-up to: elastic#206893 Adds tests for rule import and export related to the prebuilt rule customization epic. ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [x] 🟢 ESS x50: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7923 - [x] 🟢 Serverless x50: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7924 (cherry picked from commit 427d2d9)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 24, 2025
…lastic#212172) **Partially addresses:** elastic#202079 ## Summary Adds cypress tests in accordance to elastic#204889 Follow-up to: elastic#206893 Adds tests for rule import and export related to the prebuilt rule customization epic. ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [x] 🟢 ESS x50: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7923 - [x] 🟢 Serverless x50: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7924 (cherry picked from commit 427d2d9)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Feb 24, 2025
…sts (#212172) (#212310) # Backport This will backport the following commits from `main` to `8.x`: - [[Security Solution] Adds prebuilt rule import/export cypress tests (#212172)](#212172) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Davis Plumlee","email":"56367316+dplumlee@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-02-24T21:17:44Z","message":"[Security Solution] Adds prebuilt rule import/export cypress tests (#212172)\n\n**Partially addresses:** https://github.com/elastic/kibana/issues/202079\n\n## Summary\n\nAdds cypress tests in accordance to\nhttps://github.com//pull/204889\n\nFollow-up to: https://github.com/elastic/kibana/pull/206893\n\nAdds tests for rule import and export related to the prebuilt rule\ncustomization epic.\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed\n- [x] 🟢 ESS x50:\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7923\n- [x] 🟢 Serverless x50:\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7924","sha":"427d2d992988a125f00075ae959c33f6d2bc7a6e","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["test","release_note:skip","v9.0.0","Team:Detections and Resp","Team: SecuritySolution","Team:Detection Rule Management","Feature:Prebuilt Detection Rules","backport:version","v8.18.0","v9.1.0","v8.19.0"],"title":"[Security Solution] Adds prebuilt rule import/export cypress tests","number":212172,"url":"https://github.com/elastic/kibana/pull/212172","mergeCommit":{"message":"[Security Solution] Adds prebuilt rule import/export cypress tests (#212172)\n\n**Partially addresses:** https://github.com/elastic/kibana/issues/202079\n\n## Summary\n\nAdds cypress tests in accordance to\nhttps://github.com//pull/204889\n\nFollow-up to: https://github.com/elastic/kibana/pull/206893\n\nAdds tests for rule import and export related to the prebuilt rule\ncustomization epic.\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed\n- [x] 🟢 ESS x50:\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7923\n- [x] 🟢 Serverless x50:\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7924","sha":"427d2d992988a125f00075ae959c33f6d2bc7a6e"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/212172","number":212172,"mergeCommit":{"message":"[Security Solution] Adds prebuilt rule import/export cypress tests (#212172)\n\n**Partially addresses:** https://github.com/elastic/kibana/issues/202079\n\n## Summary\n\nAdds cypress tests in accordance to\nhttps://github.com//pull/204889\n\nFollow-up to: https://github.com/elastic/kibana/pull/206893\n\nAdds tests for rule import and export related to the prebuilt rule\ncustomization epic.\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed\n- [x] 🟢 ESS x50:\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7923\n- [x] 🟢 Serverless x50:\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7924","sha":"427d2d992988a125f00075ae959c33f6d2bc7a6e"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Davis Plumlee <56367316+dplumlee@users.noreply.github.com>
kibanamachine
added a commit
that referenced
this pull request
Feb 25, 2025
…sts (#212172) (#212311) # Backport This will backport the following commits from `main` to `9.0`: - [[Security Solution] Adds prebuilt rule import/export cypress tests (#212172)](#212172) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Davis Plumlee","email":"56367316+dplumlee@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-02-24T21:17:44Z","message":"[Security Solution] Adds prebuilt rule import/export cypress tests (#212172)\n\n**Partially addresses:** https://github.com/elastic/kibana/issues/202079\n\n## Summary\n\nAdds cypress tests in accordance to\nhttps://github.com//pull/204889\n\nFollow-up to: https://github.com/elastic/kibana/pull/206893\n\nAdds tests for rule import and export related to the prebuilt rule\ncustomization epic.\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed\n- [x] 🟢 ESS x50:\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7923\n- [x] 🟢 Serverless x50:\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7924","sha":"427d2d992988a125f00075ae959c33f6d2bc7a6e","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["test","release_note:skip","v9.0.0","Team:Detections and Resp","Team: SecuritySolution","Team:Detection Rule Management","Feature:Prebuilt Detection Rules","backport:version","v8.18.0","v9.1.0","v8.19.0"],"title":"[Security Solution] Adds prebuilt rule import/export cypress tests","number":212172,"url":"https://github.com/elastic/kibana/pull/212172","mergeCommit":{"message":"[Security Solution] Adds prebuilt rule import/export cypress tests (#212172)\n\n**Partially addresses:** https://github.com/elastic/kibana/issues/202079\n\n## Summary\n\nAdds cypress tests in accordance to\nhttps://github.com//pull/204889\n\nFollow-up to: https://github.com/elastic/kibana/pull/206893\n\nAdds tests for rule import and export related to the prebuilt rule\ncustomization epic.\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed\n- [x] 🟢 ESS x50:\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7923\n- [x] 🟢 Serverless x50:\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7924","sha":"427d2d992988a125f00075ae959c33f6d2bc7a6e"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/212172","number":212172,"mergeCommit":{"message":"[Security Solution] Adds prebuilt rule import/export cypress tests (#212172)\n\n**Partially addresses:** https://github.com/elastic/kibana/issues/202079\n\n## Summary\n\nAdds cypress tests in accordance to\nhttps://github.com//pull/204889\n\nFollow-up to: https://github.com/elastic/kibana/pull/206893\n\nAdds tests for rule import and export related to the prebuilt rule\ncustomization epic.\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed\n- [x] 🟢 ESS x50:\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7923\n- [x] 🟢 Serverless x50:\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7924","sha":"427d2d992988a125f00075ae959c33f6d2bc7a6e"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Davis Plumlee <56367316+dplumlee@users.noreply.github.com>
banderror
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 25, 2025
…lastic#212172) **Partially addresses:** elastic#202079 ## Summary Adds cypress tests in accordance to elastic#204889 Follow-up to: elastic#206893 Adds tests for rule import and export related to the prebuilt rule customization epic. ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [x] 🟢 ESS x50: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7923 - [x] 🟢 Serverless x50: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7924 (cherry picked from commit 427d2d9)
kibanamachine
added a commit
that referenced
this pull request
Feb 25, 2025
…ests (#212172) (#212309) # Backport This will backport the following commits from `main` to `8.18`: - [[Security Solution] Adds prebuilt rule import/export cypress tests (#212172)](#212172) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Davis Plumlee","email":"56367316+dplumlee@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-02-24T21:17:44Z","message":"[Security Solution] Adds prebuilt rule import/export cypress tests (#212172)\n\n**Partially addresses:** https://github.com/elastic/kibana/issues/202079\n\n## Summary\n\nAdds cypress tests in accordance to\nhttps://github.com//pull/204889\n\nFollow-up to: https://github.com/elastic/kibana/pull/206893\n\nAdds tests for rule import and export related to the prebuilt rule\ncustomization epic.\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed\n- [x] 🟢 ESS x50:\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7923\n- [x] 🟢 Serverless x50:\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7924","sha":"427d2d992988a125f00075ae959c33f6d2bc7a6e","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["test","release_note:skip","v9.0.0","Team:Detections and Resp","Team: SecuritySolution","Team:Detection Rule Management","Feature:Prebuilt Detection Rules","backport:version","v8.18.0","v9.1.0","v8.19.0"],"title":"[Security Solution] Adds prebuilt rule import/export cypress tests","number":212172,"url":"https://github.com/elastic/kibana/pull/212172","mergeCommit":{"message":"[Security Solution] Adds prebuilt rule import/export cypress tests (#212172)\n\n**Partially addresses:** https://github.com/elastic/kibana/issues/202079\n\n## Summary\n\nAdds cypress tests in accordance to\nhttps://github.com//pull/204889\n\nFollow-up to: https://github.com/elastic/kibana/pull/206893\n\nAdds tests for rule import and export related to the prebuilt rule\ncustomization epic.\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed\n- [x] 🟢 ESS x50:\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7923\n- [x] 🟢 Serverless x50:\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7924","sha":"427d2d992988a125f00075ae959c33f6d2bc7a6e"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/212172","number":212172,"mergeCommit":{"message":"[Security Solution] Adds prebuilt rule import/export cypress tests (#212172)\n\n**Partially addresses:** https://github.com/elastic/kibana/issues/202079\n\n## Summary\n\nAdds cypress tests in accordance to\nhttps://github.com//pull/204889\n\nFollow-up to: https://github.com/elastic/kibana/pull/206893\n\nAdds tests for rule import and export related to the prebuilt rule\ncustomization epic.\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed\n- [x] 🟢 ESS x50:\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7923\n- [x] 🟢 Serverless x50:\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7924","sha":"427d2d992988a125f00075ae959c33f6d2bc7a6e"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Davis Plumlee <56367316+dplumlee@users.noreply.github.com>
patrykkopycinski
pushed a commit
to patrykkopycinski/kibana
that referenced
this pull request
Feb 25, 2025
…lastic#212172) **Partially addresses:** elastic#202079 ## Summary Adds cypress tests in accordance to elastic#204889 Follow-up to: elastic#206893 Adds tests for rule import and export related to the prebuilt rule customization epic. ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [x] 🟢 ESS x50: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7923 - [x] 🟢 Serverless x50: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7924
JoseLuisGJ
pushed a commit
to JoseLuisGJ/kibana
that referenced
this pull request
Feb 27, 2025
…lastic#212172) **Partially addresses:** elastic#202079 ## Summary Adds cypress tests in accordance to elastic#204889 Follow-up to: elastic#206893 Adds tests for rule import and export related to the prebuilt rule customization epic. ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [x] 🟢 ESS x50: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7923 - [x] 🟢 Serverless x50: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7924
SoniaSanzV
pushed a commit
to SoniaSanzV/kibana
that referenced
this pull request
Mar 4, 2025
…sts (elastic#212172) (elastic#212310) # Backport This will backport the following commits from `main` to `8.x`: - [[Security Solution] Adds prebuilt rule import/export cypress tests (elastic#212172)](elastic#212172) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Davis Plumlee","email":"56367316+dplumlee@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-02-24T21:17:44Z","message":"[Security Solution] Adds prebuilt rule import/export cypress tests (elastic#212172)\n\n**Partially addresses:** https://github.com/elastic/kibana/issues/202079\n\n## Summary\n\nAdds cypress tests in accordance to\nhttps://github.com/elastic/pull/204889\n\nFollow-up to: https://github.com/elastic/kibana/pull/206893\n\nAdds tests for rule import and export related to the prebuilt rule\ncustomization epic.\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed\n- [x] 🟢 ESS x50:\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7923\n- [x] 🟢 Serverless x50:\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7924","sha":"427d2d992988a125f00075ae959c33f6d2bc7a6e","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["test","release_note:skip","v9.0.0","Team:Detections and Resp","Team: SecuritySolution","Team:Detection Rule Management","Feature:Prebuilt Detection Rules","backport:version","v8.18.0","v9.1.0","v8.19.0"],"title":"[Security Solution] Adds prebuilt rule import/export cypress tests","number":212172,"url":"https://github.com/elastic/kibana/pull/212172","mergeCommit":{"message":"[Security Solution] Adds prebuilt rule import/export cypress tests (elastic#212172)\n\n**Partially addresses:** https://github.com/elastic/kibana/issues/202079\n\n## Summary\n\nAdds cypress tests in accordance to\nhttps://github.com/elastic/pull/204889\n\nFollow-up to: https://github.com/elastic/kibana/pull/206893\n\nAdds tests for rule import and export related to the prebuilt rule\ncustomization epic.\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed\n- [x] 🟢 ESS x50:\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7923\n- [x] 🟢 Serverless x50:\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7924","sha":"427d2d992988a125f00075ae959c33f6d2bc7a6e"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/212172","number":212172,"mergeCommit":{"message":"[Security Solution] Adds prebuilt rule import/export cypress tests (elastic#212172)\n\n**Partially addresses:** https://github.com/elastic/kibana/issues/202079\n\n## Summary\n\nAdds cypress tests in accordance to\nhttps://github.com/elastic/pull/204889\n\nFollow-up to: https://github.com/elastic/kibana/pull/206893\n\nAdds tests for rule import and export related to the prebuilt rule\ncustomization epic.\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed\n- [x] 🟢 ESS x50:\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7923\n- [x] 🟢 Serverless x50:\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7924","sha":"427d2d992988a125f00075ae959c33f6d2bc7a6e"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Davis Plumlee <56367316+dplumlee@users.noreply.github.com>
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Mar 22, 2025
…lastic#212172) **Partially addresses:** elastic#202079 ## Summary Adds cypress tests in accordance to elastic#204889 Follow-up to: elastic#206893 Adds tests for rule import and export related to the prebuilt rule customization epic. ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [x] 🟢 ESS x50: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7923 - [x] 🟢 Serverless x50: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7924
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially addresses: #202079
Summary
Adds cypress tests in accordance to #204889
Follow-up to: #206893
Adds tests for rule import and export related to the prebuilt rule customization epic.
Checklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.