Skip to content

[Security Solution] Adds prebuilt rule import/export integration tests#206893

Merged
banderror merged 22 commits intoelastic:mainfrom
dplumlee:import-export-prebuilt-rule-tests
Feb 24, 2025
Merged

[Security Solution] Adds prebuilt rule import/export integration tests#206893
banderror merged 22 commits intoelastic:mainfrom
dplumlee:import-export-prebuilt-rule-tests

Conversation

@dplumlee
Copy link
Copy Markdown
Contributor

@dplumlee dplumlee commented Jan 16, 2025

Summary

Adds integration tests in accordance to #204889

Adds on to the existing tests we have for rule import and export to include tests related to the prebuilt rule customization epic and the new functionality that will be shipping. All these tests are running behind the prebuiltRulesCustomizationEnabled feature flag.

Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

@dplumlee dplumlee added test release_note:skip Skip the PR/issue when compiling release notes v9.0.0 Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Detection Rule Management Security Detection Rule Management Team Feature:Prebuilt Detection Rules Security Solution Prebuilt Detection Rules area backport:version Backport to applied version labels v8.18.0 labels Jan 16, 2025
@dplumlee dplumlee self-assigned this Jan 16, 2025
@dplumlee dplumlee marked this pull request as ready for review January 16, 2025 21:28
@dplumlee dplumlee requested review from a team as code owners January 16, 2025 21:28
@dplumlee dplumlee requested a review from xcrzx January 16, 2025 21:28
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/security-detection-rule-management (Team:Detection Rule Management)

@dplumlee dplumlee requested a review from nikitaindik January 16, 2025 21:28
Copy link
Copy Markdown
Contributor

@jbudz jbudz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.buildkite LGTM

@dplumlee dplumlee marked this pull request as draft January 30, 2025 07:12
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 24, 2025
elastic#206893)

## Summary

Adds integration tests in accordance to
elastic#204889

Adds on to the existing tests we have for rule import and export to
include tests related to the prebuilt rule customization epic and the
new functionality that will be shipping. All these tests are running
behind the `prebuiltRulesCustomizationEnabled` feature flag.

### Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
- [x] ESS x100:
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7921
- [x] Serverless x100:
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7922

---------

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: Georgii Gorbachev <georgii.gorbachev@elastic.co>
(cherry picked from commit 3e4ed6e)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 24, 2025
elastic#206893)

## Summary

Adds integration tests in accordance to
elastic#204889

Adds on to the existing tests we have for rule import and export to
include tests related to the prebuilt rule customization epic and the
new functionality that will be shipping. All these tests are running
behind the `prebuiltRulesCustomizationEnabled` feature flag.

### Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
- [x] ESS x100:
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7921
- [x] Serverless x100:
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7922

---------

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: Georgii Gorbachev <georgii.gorbachev@elastic.co>
(cherry picked from commit 3e4ed6e)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 24, 2025
elastic#206893)

## Summary

Adds integration tests in accordance to
elastic#204889

Adds on to the existing tests we have for rule import and export to
include tests related to the prebuilt rule customization epic and the
new functionality that will be shipping. All these tests are running
behind the `prebuiltRulesCustomizationEnabled` feature flag.

### Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
- [x] ESS x100:
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7921
- [x] Serverless x100:
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7922

---------

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: Georgii Gorbachev <georgii.gorbachev@elastic.co>
(cherry picked from commit 3e4ed6e)
@kibanamachine
Copy link
Copy Markdown
Contributor

💚 All backports created successfully

Status Branch Result
8.18
8.x
9.0

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Feb 24, 2025
…n tests (#206893) (#212194)

# Backport

This will backport the following commits from `main` to `9.0`:
- [[Security Solution] Adds prebuilt rule import/export integration
tests (#206893)](#206893)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Davis
Plumlee","email":"56367316+dplumlee@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-02-24T01:18:02Z","message":"[Security
Solution] Adds prebuilt rule import/export integration tests
(#206893)\n\n## Summary\n\nAdds integration tests in accordance
to\nhttps://github.com//pull/204889\n\nAdds on to the
existing tests we have for rule import and export to\ninclude tests
related to the prebuilt rule customization epic and the\nnew
functionality that will be shipping. All these tests are running\nbehind
the `prebuiltRulesCustomizationEnabled` feature flag.\n\n###
Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers
should verify this PR satisfies this list as well.\n\n- [x] [Unit or
functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere
updated or added to match the most common scenarios\n- [x] [Flaky
Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1)
was\nused on any tests changed\n- [x] ESS
x100:\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7921\n-
[x] Serverless
x100:\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7922\n\n---------\n\nCo-authored-by:
Elastic Machine
<elasticmachine@users.noreply.github.com>\nCo-authored-by: Georgii
Gorbachev
<georgii.gorbachev@elastic.co>","sha":"3e4ed6ebd58c77f555e2eb1287f70ad41ca73666","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["test","release_note:skip","v9.0.0","Team:Detections
and Resp","Team: SecuritySolution","Team:Detection Rule
Management","Feature:Prebuilt Detection
Rules","backport:version","v8.18.0","v9.1.0","v8.19.0"],"title":"[Security
Solution] Adds prebuilt rule import/export integration
tests","number":206893,"url":"https://github.com/elastic/kibana/pull/206893","mergeCommit":{"message":"[Security
Solution] Adds prebuilt rule import/export integration tests
(#206893)\n\n## Summary\n\nAdds integration tests in accordance
to\nhttps://github.com//pull/204889\n\nAdds on to the
existing tests we have for rule import and export to\ninclude tests
related to the prebuilt rule customization epic and the\nnew
functionality that will be shipping. All these tests are running\nbehind
the `prebuiltRulesCustomizationEnabled` feature flag.\n\n###
Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers
should verify this PR satisfies this list as well.\n\n- [x] [Unit or
functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere
updated or added to match the most common scenarios\n- [x] [Flaky
Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1)
was\nused on any tests changed\n- [x] ESS
x100:\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7921\n-
[x] Serverless
x100:\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7922\n\n---------\n\nCo-authored-by:
Elastic Machine
<elasticmachine@users.noreply.github.com>\nCo-authored-by: Georgii
Gorbachev
<georgii.gorbachev@elastic.co>","sha":"3e4ed6ebd58c77f555e2eb1287f70ad41ca73666"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/206893","number":206893,"mergeCommit":{"message":"[Security
Solution] Adds prebuilt rule import/export integration tests
(#206893)\n\n## Summary\n\nAdds integration tests in accordance
to\nhttps://github.com//pull/204889\n\nAdds on to the
existing tests we have for rule import and export to\ninclude tests
related to the prebuilt rule customization epic and the\nnew
functionality that will be shipping. All these tests are running\nbehind
the `prebuiltRulesCustomizationEnabled` feature flag.\n\n###
Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers
should verify this PR satisfies this list as well.\n\n- [x] [Unit or
functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere
updated or added to match the most common scenarios\n- [x] [Flaky
Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1)
was\nused on any tests changed\n- [x] ESS
x100:\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7921\n-
[x] Serverless
x100:\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7922\n\n---------\n\nCo-authored-by:
Elastic Machine
<elasticmachine@users.noreply.github.com>\nCo-authored-by: Georgii
Gorbachev
<georgii.gorbachev@elastic.co>","sha":"3e4ed6ebd58c77f555e2eb1287f70ad41ca73666"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Davis Plumlee <56367316+dplumlee@users.noreply.github.com>
kibanamachine added a commit that referenced this pull request Feb 24, 2025
…on tests (#206893) (#212192)

# Backport

This will backport the following commits from `main` to `8.18`:
- [[Security Solution] Adds prebuilt rule import/export integration
tests (#206893)](#206893)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Davis
Plumlee","email":"56367316+dplumlee@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-02-24T01:18:02Z","message":"[Security
Solution] Adds prebuilt rule import/export integration tests
(#206893)\n\n## Summary\n\nAdds integration tests in accordance
to\nhttps://github.com//pull/204889\n\nAdds on to the
existing tests we have for rule import and export to\ninclude tests
related to the prebuilt rule customization epic and the\nnew
functionality that will be shipping. All these tests are running\nbehind
the `prebuiltRulesCustomizationEnabled` feature flag.\n\n###
Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers
should verify this PR satisfies this list as well.\n\n- [x] [Unit or
functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere
updated or added to match the most common scenarios\n- [x] [Flaky
Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1)
was\nused on any tests changed\n- [x] ESS
x100:\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7921\n-
[x] Serverless
x100:\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7922\n\n---------\n\nCo-authored-by:
Elastic Machine
<elasticmachine@users.noreply.github.com>\nCo-authored-by: Georgii
Gorbachev
<georgii.gorbachev@elastic.co>","sha":"3e4ed6ebd58c77f555e2eb1287f70ad41ca73666","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["test","release_note:skip","v9.0.0","Team:Detections
and Resp","Team: SecuritySolution","Team:Detection Rule
Management","Feature:Prebuilt Detection
Rules","backport:version","v8.18.0","v9.1.0","v8.19.0"],"title":"[Security
Solution] Adds prebuilt rule import/export integration
tests","number":206893,"url":"https://github.com/elastic/kibana/pull/206893","mergeCommit":{"message":"[Security
Solution] Adds prebuilt rule import/export integration tests
(#206893)\n\n## Summary\n\nAdds integration tests in accordance
to\nhttps://github.com//pull/204889\n\nAdds on to the
existing tests we have for rule import and export to\ninclude tests
related to the prebuilt rule customization epic and the\nnew
functionality that will be shipping. All these tests are running\nbehind
the `prebuiltRulesCustomizationEnabled` feature flag.\n\n###
Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers
should verify this PR satisfies this list as well.\n\n- [x] [Unit or
functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere
updated or added to match the most common scenarios\n- [x] [Flaky
Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1)
was\nused on any tests changed\n- [x] ESS
x100:\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7921\n-
[x] Serverless
x100:\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7922\n\n---------\n\nCo-authored-by:
Elastic Machine
<elasticmachine@users.noreply.github.com>\nCo-authored-by: Georgii
Gorbachev
<georgii.gorbachev@elastic.co>","sha":"3e4ed6ebd58c77f555e2eb1287f70ad41ca73666"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/206893","number":206893,"mergeCommit":{"message":"[Security
Solution] Adds prebuilt rule import/export integration tests
(#206893)\n\n## Summary\n\nAdds integration tests in accordance
to\nhttps://github.com//pull/204889\n\nAdds on to the
existing tests we have for rule import and export to\ninclude tests
related to the prebuilt rule customization epic and the\nnew
functionality that will be shipping. All these tests are running\nbehind
the `prebuiltRulesCustomizationEnabled` feature flag.\n\n###
Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers
should verify this PR satisfies this list as well.\n\n- [x] [Unit or
functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere
updated or added to match the most common scenarios\n- [x] [Flaky
Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1)
was\nused on any tests changed\n- [x] ESS
x100:\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7921\n-
[x] Serverless
x100:\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7922\n\n---------\n\nCo-authored-by:
Elastic Machine
<elasticmachine@users.noreply.github.com>\nCo-authored-by: Georgii
Gorbachev
<georgii.gorbachev@elastic.co>","sha":"3e4ed6ebd58c77f555e2eb1287f70ad41ca73666"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Davis Plumlee <56367316+dplumlee@users.noreply.github.com>
kibanamachine added a commit that referenced this pull request Feb 24, 2025
…n tests (#206893) (#212193)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Security Solution] Adds prebuilt rule import/export integration
tests (#206893)](#206893)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Davis
Plumlee","email":"56367316+dplumlee@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-02-24T01:18:02Z","message":"[Security
Solution] Adds prebuilt rule import/export integration tests
(#206893)\n\n## Summary\n\nAdds integration tests in accordance
to\nhttps://github.com//pull/204889\n\nAdds on to the
existing tests we have for rule import and export to\ninclude tests
related to the prebuilt rule customization epic and the\nnew
functionality that will be shipping. All these tests are running\nbehind
the `prebuiltRulesCustomizationEnabled` feature flag.\n\n###
Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers
should verify this PR satisfies this list as well.\n\n- [x] [Unit or
functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere
updated or added to match the most common scenarios\n- [x] [Flaky
Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1)
was\nused on any tests changed\n- [x] ESS
x100:\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7921\n-
[x] Serverless
x100:\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7922\n\n---------\n\nCo-authored-by:
Elastic Machine
<elasticmachine@users.noreply.github.com>\nCo-authored-by: Georgii
Gorbachev
<georgii.gorbachev@elastic.co>","sha":"3e4ed6ebd58c77f555e2eb1287f70ad41ca73666","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["test","release_note:skip","v9.0.0","Team:Detections
and Resp","Team: SecuritySolution","Team:Detection Rule
Management","Feature:Prebuilt Detection
Rules","backport:version","v8.18.0","v9.1.0","v8.19.0"],"title":"[Security
Solution] Adds prebuilt rule import/export integration
tests","number":206893,"url":"https://github.com/elastic/kibana/pull/206893","mergeCommit":{"message":"[Security
Solution] Adds prebuilt rule import/export integration tests
(#206893)\n\n## Summary\n\nAdds integration tests in accordance
to\nhttps://github.com//pull/204889\n\nAdds on to the
existing tests we have for rule import and export to\ninclude tests
related to the prebuilt rule customization epic and the\nnew
functionality that will be shipping. All these tests are running\nbehind
the `prebuiltRulesCustomizationEnabled` feature flag.\n\n###
Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers
should verify this PR satisfies this list as well.\n\n- [x] [Unit or
functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere
updated or added to match the most common scenarios\n- [x] [Flaky
Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1)
was\nused on any tests changed\n- [x] ESS
x100:\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7921\n-
[x] Serverless
x100:\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7922\n\n---------\n\nCo-authored-by:
Elastic Machine
<elasticmachine@users.noreply.github.com>\nCo-authored-by: Georgii
Gorbachev
<georgii.gorbachev@elastic.co>","sha":"3e4ed6ebd58c77f555e2eb1287f70ad41ca73666"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/206893","number":206893,"mergeCommit":{"message":"[Security
Solution] Adds prebuilt rule import/export integration tests
(#206893)\n\n## Summary\n\nAdds integration tests in accordance
to\nhttps://github.com//pull/204889\n\nAdds on to the
existing tests we have for rule import and export to\ninclude tests
related to the prebuilt rule customization epic and the\nnew
functionality that will be shipping. All these tests are running\nbehind
the `prebuiltRulesCustomizationEnabled` feature flag.\n\n###
Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers
should verify this PR satisfies this list as well.\n\n- [x] [Unit or
functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere
updated or added to match the most common scenarios\n- [x] [Flaky
Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1)
was\nused on any tests changed\n- [x] ESS
x100:\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7921\n-
[x] Serverless
x100:\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7922\n\n---------\n\nCo-authored-by:
Elastic Machine
<elasticmachine@users.noreply.github.com>\nCo-authored-by: Georgii
Gorbachev
<georgii.gorbachev@elastic.co>","sha":"3e4ed6ebd58c77f555e2eb1287f70ad41ca73666"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Davis Plumlee <56367316+dplumlee@users.noreply.github.com>
@banderror banderror removed request for a team and nikitaindik February 24, 2025 14:38
banderror pushed a commit that referenced this pull request Feb 24, 2025
…212172)

**Partially addresses:** #202079

## Summary

Adds cypress tests in accordance to
#204889

Follow-up to: #206893

Adds tests for rule import and export related to the prebuilt rule
customization epic.
### Checklist

Check the PR satisfies following conditions. 

Reviewers should verify this PR satisfies this list as well.

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
- [x] 🟢 ESS x50:
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7923
- [x] 🟢 Serverless x50:
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7924
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 24, 2025
…lastic#212172)

**Partially addresses:** elastic#202079

## Summary

Adds cypress tests in accordance to
elastic#204889

Follow-up to: elastic#206893

Adds tests for rule import and export related to the prebuilt rule
customization epic.
### Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
- [x] 🟢 ESS x50:
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7923
- [x] 🟢 Serverless x50:
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7924

(cherry picked from commit 427d2d9)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 24, 2025
…lastic#212172)

**Partially addresses:** elastic#202079

## Summary

Adds cypress tests in accordance to
elastic#204889

Follow-up to: elastic#206893

Adds tests for rule import and export related to the prebuilt rule
customization epic.
### Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
- [x] 🟢 ESS x50:
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7923
- [x] 🟢 Serverless x50:
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7924

(cherry picked from commit 427d2d9)
@dplumlee dplumlee deleted the import-export-prebuilt-rule-tests branch February 24, 2025 22:32
banderror pushed a commit to kibanamachine/kibana that referenced this pull request Feb 25, 2025
…lastic#212172)

**Partially addresses:** elastic#202079

## Summary

Adds cypress tests in accordance to
elastic#204889

Follow-up to: elastic#206893

Adds tests for rule import and export related to the prebuilt rule
customization epic.
### Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
- [x] 🟢 ESS x50:
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7923
- [x] 🟢 Serverless x50:
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7924

(cherry picked from commit 427d2d9)
patrykkopycinski pushed a commit to patrykkopycinski/kibana that referenced this pull request Feb 25, 2025
…lastic#212172)

**Partially addresses:** elastic#202079

## Summary

Adds cypress tests in accordance to
elastic#204889

Follow-up to: elastic#206893

Adds tests for rule import and export related to the prebuilt rule
customization epic.
### Checklist

Check the PR satisfies following conditions. 

Reviewers should verify this PR satisfies this list as well.

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
- [x] 🟢 ESS x50:
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7923
- [x] 🟢 Serverless x50:
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7924
JoseLuisGJ pushed a commit to JoseLuisGJ/kibana that referenced this pull request Feb 27, 2025
elastic#206893)

## Summary

Adds integration tests in accordance to
elastic#204889

Adds on to the existing tests we have for rule import and export to
include tests related to the prebuilt rule customization epic and the
new functionality that will be shipping. All these tests are running
behind the `prebuiltRulesCustomizationEnabled` feature flag.

### Checklist

Check the PR satisfies following conditions. 

Reviewers should verify this PR satisfies this list as well.

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
- [x] ESS x100:
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7921
- [x] Serverless x100:
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7922

---------

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: Georgii Gorbachev <georgii.gorbachev@elastic.co>
JoseLuisGJ pushed a commit to JoseLuisGJ/kibana that referenced this pull request Feb 27, 2025
…lastic#212172)

**Partially addresses:** elastic#202079

## Summary

Adds cypress tests in accordance to
elastic#204889

Follow-up to: elastic#206893

Adds tests for rule import and export related to the prebuilt rule
customization epic.
### Checklist

Check the PR satisfies following conditions. 

Reviewers should verify this PR satisfies this list as well.

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
- [x] 🟢 ESS x50:
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7923
- [x] 🟢 Serverless x50:
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7924
SoniaSanzV pushed a commit to SoniaSanzV/kibana that referenced this pull request Mar 4, 2025
…n tests (elastic#206893) (elastic#212193)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Security Solution] Adds prebuilt rule import/export integration
tests (elastic#206893)](elastic#206893)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Davis
Plumlee","email":"56367316+dplumlee@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-02-24T01:18:02Z","message":"[Security
Solution] Adds prebuilt rule import/export integration tests
(elastic#206893)\n\n## Summary\n\nAdds integration tests in accordance
to\nhttps://github.com/elastic/pull/204889\n\nAdds on to the
existing tests we have for rule import and export to\ninclude tests
related to the prebuilt rule customization epic and the\nnew
functionality that will be shipping. All these tests are running\nbehind
the `prebuiltRulesCustomizationEnabled` feature flag.\n\n###
Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers
should verify this PR satisfies this list as well.\n\n- [x] [Unit or
functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere
updated or added to match the most common scenarios\n- [x] [Flaky
Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1)
was\nused on any tests changed\n- [x] ESS
x100:\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7921\n-
[x] Serverless
x100:\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7922\n\n---------\n\nCo-authored-by:
Elastic Machine
<elasticmachine@users.noreply.github.com>\nCo-authored-by: Georgii
Gorbachev
<georgii.gorbachev@elastic.co>","sha":"3e4ed6ebd58c77f555e2eb1287f70ad41ca73666","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["test","release_note:skip","v9.0.0","Team:Detections
and Resp","Team: SecuritySolution","Team:Detection Rule
Management","Feature:Prebuilt Detection
Rules","backport:version","v8.18.0","v9.1.0","v8.19.0"],"title":"[Security
Solution] Adds prebuilt rule import/export integration
tests","number":206893,"url":"https://github.com/elastic/kibana/pull/206893","mergeCommit":{"message":"[Security
Solution] Adds prebuilt rule import/export integration tests
(elastic#206893)\n\n## Summary\n\nAdds integration tests in accordance
to\nhttps://github.com/elastic/pull/204889\n\nAdds on to the
existing tests we have for rule import and export to\ninclude tests
related to the prebuilt rule customization epic and the\nnew
functionality that will be shipping. All these tests are running\nbehind
the `prebuiltRulesCustomizationEnabled` feature flag.\n\n###
Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers
should verify this PR satisfies this list as well.\n\n- [x] [Unit or
functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere
updated or added to match the most common scenarios\n- [x] [Flaky
Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1)
was\nused on any tests changed\n- [x] ESS
x100:\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7921\n-
[x] Serverless
x100:\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7922\n\n---------\n\nCo-authored-by:
Elastic Machine
<elasticmachine@users.noreply.github.com>\nCo-authored-by: Georgii
Gorbachev
<georgii.gorbachev@elastic.co>","sha":"3e4ed6ebd58c77f555e2eb1287f70ad41ca73666"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/206893","number":206893,"mergeCommit":{"message":"[Security
Solution] Adds prebuilt rule import/export integration tests
(elastic#206893)\n\n## Summary\n\nAdds integration tests in accordance
to\nhttps://github.com/elastic/pull/204889\n\nAdds on to the
existing tests we have for rule import and export to\ninclude tests
related to the prebuilt rule customization epic and the\nnew
functionality that will be shipping. All these tests are running\nbehind
the `prebuiltRulesCustomizationEnabled` feature flag.\n\n###
Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers
should verify this PR satisfies this list as well.\n\n- [x] [Unit or
functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere
updated or added to match the most common scenarios\n- [x] [Flaky
Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1)
was\nused on any tests changed\n- [x] ESS
x100:\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7921\n-
[x] Serverless
x100:\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7922\n\n---------\n\nCo-authored-by:
Elastic Machine
<elasticmachine@users.noreply.github.com>\nCo-authored-by: Georgii
Gorbachev
<georgii.gorbachev@elastic.co>","sha":"3e4ed6ebd58c77f555e2eb1287f70ad41ca73666"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Davis Plumlee <56367316+dplumlee@users.noreply.github.com>
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Mar 22, 2025
elastic#206893)

## Summary

Adds integration tests in accordance to
elastic#204889

Adds on to the existing tests we have for rule import and export to
include tests related to the prebuilt rule customization epic and the
new functionality that will be shipping. All these tests are running
behind the `prebuiltRulesCustomizationEnabled` feature flag.

### Checklist

Check the PR satisfies following conditions. 

Reviewers should verify this PR satisfies this list as well.

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
- [x] ESS x100:
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7921
- [x] Serverless x100:
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7922

---------

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: Georgii Gorbachev <georgii.gorbachev@elastic.co>
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Mar 22, 2025
…lastic#212172)

**Partially addresses:** elastic#202079

## Summary

Adds cypress tests in accordance to
elastic#204889

Follow-up to: elastic#206893

Adds tests for rule import and export related to the prebuilt rule
customization epic.
### Checklist

Check the PR satisfies following conditions. 

Reviewers should verify this PR satisfies this list as well.

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
- [x] 🟢 ESS x50:
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7923
- [x] 🟢 Serverless x50:
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7924
banderror added a commit that referenced this pull request Mar 24, 2025
…13434)

**Epic:** #174168
**Partially addresses:**
#202079,
#210358

## Summary

We started to rework and introduce functional changes to our existing
test plans for prebuilt rule customization, upgrade, and export/import
workflows.

Specifically, this PR:

- Restructures the test plan, introduces a more fine-grained list of
sections.
- Rewrites almost all the existing scenarios. In most cases it boils
down to splitting a scenario into 2+ more specific scenarios, where each
describes _exactly_ what happens in the GIVEN and THEN sections. This is
very important, as it:
- makes these scenarios ready to be implemented right away: 1 scenario =
1 test to write
  - helps with ensuring that we covered edge cases
- Adds new scenarios for handling missing base versions according to
[#210358](#210358).
- Adds a placeholder section for licensing scenarios according to
[#11502](elastic/security-team#11502).
- Removes scenarios for the `overwrite` request parameter - this is
common importing logic which is not related to prebuilt rules.
- Addresses my own comments from [this
review](#206893 (review)).

The new test plan should be in line with the changes discussed in
#210358.
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Mar 24, 2025
…astic#213434)

**Epic:** elastic#174168
**Partially addresses:**
elastic#202079,
elastic#210358

## Summary

We started to rework and introduce functional changes to our existing
test plans for prebuilt rule customization, upgrade, and export/import
workflows.

Specifically, this PR:

- Restructures the test plan, introduces a more fine-grained list of
sections.
- Rewrites almost all the existing scenarios. In most cases it boils
down to splitting a scenario into 2+ more specific scenarios, where each
describes _exactly_ what happens in the GIVEN and THEN sections. This is
very important, as it:
- makes these scenarios ready to be implemented right away: 1 scenario =
1 test to write
  - helps with ensuring that we covered edge cases
- Adds new scenarios for handling missing base versions according to
[elastic#210358](elastic#210358).
- Adds a placeholder section for licensing scenarios according to
[elastic#11502](elastic/security-team#11502).
- Removes scenarios for the `overwrite` request parameter - this is
common importing logic which is not related to prebuilt rules.
- Addresses my own comments from [this
review](elastic#206893 (review)).

The new test plan should be in line with the changes discussed in
elastic#210358.

(cherry picked from commit a9106c6)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Mar 24, 2025
…astic#213434)

**Epic:** elastic#174168
**Partially addresses:**
elastic#202079,
elastic#210358

## Summary

We started to rework and introduce functional changes to our existing
test plans for prebuilt rule customization, upgrade, and export/import
workflows.

Specifically, this PR:

- Restructures the test plan, introduces a more fine-grained list of
sections.
- Rewrites almost all the existing scenarios. In most cases it boils
down to splitting a scenario into 2+ more specific scenarios, where each
describes _exactly_ what happens in the GIVEN and THEN sections. This is
very important, as it:
- makes these scenarios ready to be implemented right away: 1 scenario =
1 test to write
  - helps with ensuring that we covered edge cases
- Adds new scenarios for handling missing base versions according to
[elastic#210358](elastic#210358).
- Adds a placeholder section for licensing scenarios according to
[elastic#11502](elastic/security-team#11502).
- Removes scenarios for the `overwrite` request parameter - this is
common importing logic which is not related to prebuilt rules.
- Addresses my own comments from [this
review](elastic#206893 (review)).

The new test plan should be in line with the changes discussed in
elastic#210358.

(cherry picked from commit a9106c6)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Mar 24, 2025
…astic#213434)

**Epic:** elastic#174168
**Partially addresses:**
elastic#202079,
elastic#210358

## Summary

We started to rework and introduce functional changes to our existing
test plans for prebuilt rule customization, upgrade, and export/import
workflows.

Specifically, this PR:

- Restructures the test plan, introduces a more fine-grained list of
sections.
- Rewrites almost all the existing scenarios. In most cases it boils
down to splitting a scenario into 2+ more specific scenarios, where each
describes _exactly_ what happens in the GIVEN and THEN sections. This is
very important, as it:
- makes these scenarios ready to be implemented right away: 1 scenario =
1 test to write
  - helps with ensuring that we covered edge cases
- Adds new scenarios for handling missing base versions according to
[elastic#210358](elastic#210358).
- Adds a placeholder section for licensing scenarios according to
[elastic#11502](elastic/security-team#11502).
- Removes scenarios for the `overwrite` request parameter - this is
common importing logic which is not related to prebuilt rules.
- Addresses my own comments from [this
review](elastic#206893 (review)).

The new test plan should be in line with the changes discussed in
elastic#210358.

(cherry picked from commit a9106c6)
cqliu1 pushed a commit to cqliu1/kibana that referenced this pull request Mar 31, 2025
…astic#213434)

**Epic:** elastic#174168
**Partially addresses:**
elastic#202079,
elastic#210358

## Summary

We started to rework and introduce functional changes to our existing
test plans for prebuilt rule customization, upgrade, and export/import
workflows.

Specifically, this PR:

- Restructures the test plan, introduces a more fine-grained list of
sections.
- Rewrites almost all the existing scenarios. In most cases it boils
down to splitting a scenario into 2+ more specific scenarios, where each
describes _exactly_ what happens in the GIVEN and THEN sections. This is
very important, as it:
- makes these scenarios ready to be implemented right away: 1 scenario =
1 test to write
  - helps with ensuring that we covered edge cases
- Adds new scenarios for handling missing base versions according to
[elastic#210358](elastic#210358).
- Adds a placeholder section for licensing scenarios according to
[elastic#11502](elastic/security-team#11502).
- Removes scenarios for the `overwrite` request parameter - this is
common importing logic which is not related to prebuilt rules.
- Addresses my own comments from [this
review](elastic#206893 (review)).

The new test plan should be in line with the changes discussed in
elastic#210358.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:version Backport to applied version labels Feature:Prebuilt Detection Rules Security Solution Prebuilt Detection Rules area release_note:skip Skip the PR/issue when compiling release notes Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. test v8.18.0 v8.19.0 v9.0.0 v9.1.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants