Skip to content

[Security Solution][Expandable flyout] fix flyout flickering when opening/closing left panel#210225

Merged
PhilippeOberti merged 2 commits intoelastic:mainfrom
PhilippeOberti:flyout-flickering
Feb 7, 2025
Merged

[Security Solution][Expandable flyout] fix flyout flickering when opening/closing left panel#210225
PhilippeOberti merged 2 commits intoelastic:mainfrom
PhilippeOberti:flyout-flickering

Conversation

@PhilippeOberti
Copy link
Copy Markdown
Contributor

@PhilippeOberti PhilippeOberti commented Feb 7, 2025

Summary

We recently improved the expandable flyout by adding support for a fully resizable flyout. This work introduce a minor inconvenience, where the right panel gets re-rendered every time the user expands or collapses the flyout.

This PR fixes this issue by better using the EUI resizable container (see how to externally control a resizable container here). The flyout is now always showing a resizable container (even in collapsed mode) but EUI manages internally hiding the left section and the resize button.

Old behavior

Screen.Recording.2025-02-07.at.10.55.49.AM.mov

New behavior

Screen.Recording.2025-02-07.at.10.54.42.AM.mov

The rest of the flyout's behavior remains untouched:

  • identical default widths
  • user selected widths are still applied
  • no changes to the preview behavior

Checklist

@PhilippeOberti PhilippeOberti added release_note:skip Skip the PR/issue when compiling release notes v9.0.0 Team:Threat Hunting:Investigations Security Solution Threat Hunting Investigations Team backport:version Backport to applied version labels v8.18.0 labels Feb 7, 2025
@PhilippeOberti PhilippeOberti requested a review from a team as a code owner February 7, 2025 17:03
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations)

Copy link
Copy Markdown
Contributor

@christineweng christineweng Feb 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i dont think you need the empty tag here?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that is correct, this is left over from some test I was doing with a resize button. Removed!

@PhilippeOberti PhilippeOberti force-pushed the flyout-flickering branch 2 times, most recently from e815270 to 4376a3b Compare February 7, 2025 20:23
@elasticmachine
Copy link
Copy Markdown
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #21 / UserCommentPropertyActions renders the correct number of actions

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 21.4MB 21.4MB -15.0B

History

  • 💚 Build #274408 succeeded 3c4881a04ca3497a9ca65ebec92c89b753286a89

@PhilippeOberti PhilippeOberti merged commit 7a9bf13 into elastic:main Feb 7, 2025
@PhilippeOberti PhilippeOberti deleted the flyout-flickering branch February 7, 2025 22:34
@kibanamachine
Copy link
Copy Markdown
Contributor

Starting backport for target branches: 8.16, 8.17, 8.18, 9.0

https://github.com/elastic/kibana/actions/runs/13209172458

@kibanamachine
Copy link
Copy Markdown
Contributor

💔 All backports failed

Status Branch Result
8.16 Backport failed because of merge conflicts
8.17 Backport failed because of merge conflicts
8.18 Backport failed because of merge conflicts
9.0 Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 210225

Questions ?

Please refer to the Backport tool documentation

PhilippeOberti added a commit to PhilippeOberti/kibana that referenced this pull request Feb 7, 2025
…ning/closing left panel (elastic#210225)

## Summary

We recently improved the expandable flyout by adding support for a
[fully resizable flyout](elastic#192906).
This work introduce a minor inconvenience, where the right panel gets
re-rendered every time the user expands or collapses the flyout.

This PR fixes this issue by better using the EUI resizable container
(see how to externally control a resizable container
[here](https://eui.elastic.co/#/layout/resizable-container#collapsible-panels-with-external-control)).
The flyout is now always showing a resizable container (even in
collapsed mode) but EUI manages internally hiding the left section and
the resize button.

#### Old behavior

https://github.com/user-attachments/assets/4d7589ec-0edf-4690-9ce4-7b969ae0bb44

#### New behavior

https://github.com/user-attachments/assets/7cf720b8-5b31-4cc9-b213-21472ea880d6

The rest of the flyout's behavior remains untouched:
- identical default widths
- user selected widths are still applied
- no changes to the preview behavior

### Checklist

- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

(cherry picked from commit 7a9bf13)

# Conflicts:
#	x-pack/solutions/security/packages/expandable-flyout/src/components/resizable_container.tsx
PhilippeOberti added a commit to PhilippeOberti/kibana that referenced this pull request Feb 7, 2025
…ning/closing left panel (elastic#210225)

## Summary

We recently improved the expandable flyout by adding support for a
[fully resizable flyout](elastic#192906).
This work introduce a minor inconvenience, where the right panel gets
re-rendered every time the user expands or collapses the flyout.

This PR fixes this issue by better using the EUI resizable container
(see how to externally control a resizable container
[here](https://eui.elastic.co/#/layout/resizable-container#collapsible-panels-with-external-control)).
The flyout is now always showing a resizable container (even in
collapsed mode) but EUI manages internally hiding the left section and
the resize button.

#### Old behavior

https://github.com/user-attachments/assets/4d7589ec-0edf-4690-9ce4-7b969ae0bb44

#### New behavior

https://github.com/user-attachments/assets/7cf720b8-5b31-4cc9-b213-21472ea880d6

The rest of the flyout's behavior remains untouched:
- identical default widths
- user selected widths are still applied
- no changes to the preview behavior

### Checklist

- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

(cherry picked from commit 7a9bf13)

# Conflicts:
#	packages/kbn-expandable-flyout/src/components/resizable_container.tsx
@PhilippeOberti
Copy link
Copy Markdown
Contributor Author

💚 All backports created successfully

Status Branch Result
9.0
8.18
8.17
8.16

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

@PhilippeOberti
Copy link
Copy Markdown
Contributor Author

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

PhilippeOberti added a commit to PhilippeOberti/kibana that referenced this pull request Feb 7, 2025
…ning/closing left panel (elastic#210225)

## Summary

We recently improved the expandable flyout by adding support for a
[fully resizable flyout](elastic#192906).
This work introduce a minor inconvenience, where the right panel gets
re-rendered every time the user expands or collapses the flyout.

This PR fixes this issue by better using the EUI resizable container
(see how to externally control a resizable container
[here](https://eui.elastic.co/#/layout/resizable-container#collapsible-panels-with-external-control)).
The flyout is now always showing a resizable container (even in
collapsed mode) but EUI manages internally hiding the left section and
the resize button.

#### Old behavior

https://github.com/user-attachments/assets/4d7589ec-0edf-4690-9ce4-7b969ae0bb44

#### New behavior

https://github.com/user-attachments/assets/7cf720b8-5b31-4cc9-b213-21472ea880d6

The rest of the flyout's behavior remains untouched:
- identical default widths
- user selected widths are still applied
- no changes to the preview behavior

### Checklist

- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

(cherry picked from commit 7a9bf13)
PhilippeOberti added a commit to PhilippeOberti/kibana that referenced this pull request Feb 7, 2025
…ning/closing left panel (elastic#210225)

## Summary

We recently improved the expandable flyout by adding support for a
[fully resizable flyout](elastic#192906).
This work introduce a minor inconvenience, where the right panel gets
re-rendered every time the user expands or collapses the flyout.

This PR fixes this issue by better using the EUI resizable container
(see how to externally control a resizable container
[here](https://eui.elastic.co/#/layout/resizable-container#collapsible-panels-with-external-control)).
The flyout is now always showing a resizable container (even in
collapsed mode) but EUI manages internally hiding the left section and
the resize button.

#### Old behavior

https://github.com/user-attachments/assets/4d7589ec-0edf-4690-9ce4-7b969ae0bb44

#### New behavior

https://github.com/user-attachments/assets/7cf720b8-5b31-4cc9-b213-21472ea880d6

The rest of the flyout's behavior remains untouched:
- identical default widths
- user selected widths are still applied
- no changes to the preview behavior

### Checklist

- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

(cherry picked from commit 7a9bf13)

# Conflicts:
#	packages/kbn-expandable-flyout/src/components/resizable_container.tsx
PhilippeOberti added a commit that referenced this pull request Feb 8, 2025
…hen opening/closing left panel (#210225) (#210291)

# Backport

This will backport the following commits from `main` to `8.16`:
- [[Security Solution][Expandable flyout] fix flyout flickering when
opening/closing left panel
(#210225)](#210225)

<!--- Backport version: 9.6.4 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Philippe
Oberti","email":"philippe.oberti@elastic.co"},"sourceCommit":{"committedDate":"2025-02-07T22:34:27Z","message":"[Security
Solution][Expandable flyout] fix flyout flickering when opening/closing
left panel (#210225)\n\n## Summary\r\n\r\nWe recently improved the
expandable flyout by adding support for a\r\n[fully resizable
flyout](https://github.com/elastic/kibana/pull/192906).\r\nThis work
introduce a minor inconvenience, where the right panel
gets\r\nre-rendered every time the user expands or collapses the
flyout.\r\n\r\nThis PR fixes this issue by better using the EUI
resizable container\r\n(see how to externally control a resizable
container\r\n[here](https://eui.elastic.co/#/layout/resizable-container#collapsible-panels-with-external-control)).\r\nThe
flyout is now always showing a resizable container (even in\r\ncollapsed
mode) but EUI manages internally hiding the left section and\r\nthe
resize button.\r\n\r\n#### Old
behavior\r\n\r\n\r\nhttps://github.com/user-attachments/assets/4d7589ec-0edf-4690-9ce4-7b969ae0bb44\r\n\r\n####
New
behavior\r\n\r\n\r\nhttps://github.com/user-attachments/assets/7cf720b8-5b31-4cc9-b213-21472ea880d6\r\n\r\nThe
rest of the flyout's behavior remains untouched:\r\n- identical default
widths\r\n- user selected widths are still applied\r\n- no changes to
the preview behavior\r\n\r\n### Checklist\r\n\r\n- [ ] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"7a9bf1399c39e9306bbfb23e73a4d72fe8aae967","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Threat
Hunting:Investigations","backport:version","v8.18.0","v9.1.0","v8.17.3","v8.16.5"],"title":"[Security
Solution][Expandable flyout] fix flyout flickering when opening/closing
left
panel","number":210225,"url":"https://github.com/elastic/kibana/pull/210225","mergeCommit":{"message":"[Security
Solution][Expandable flyout] fix flyout flickering when opening/closing
left panel (#210225)\n\n## Summary\r\n\r\nWe recently improved the
expandable flyout by adding support for a\r\n[fully resizable
flyout](https://github.com/elastic/kibana/pull/192906).\r\nThis work
introduce a minor inconvenience, where the right panel
gets\r\nre-rendered every time the user expands or collapses the
flyout.\r\n\r\nThis PR fixes this issue by better using the EUI
resizable container\r\n(see how to externally control a resizable
container\r\n[here](https://eui.elastic.co/#/layout/resizable-container#collapsible-panels-with-external-control)).\r\nThe
flyout is now always showing a resizable container (even in\r\ncollapsed
mode) but EUI manages internally hiding the left section and\r\nthe
resize button.\r\n\r\n#### Old
behavior\r\n\r\n\r\nhttps://github.com/user-attachments/assets/4d7589ec-0edf-4690-9ce4-7b969ae0bb44\r\n\r\n####
New
behavior\r\n\r\n\r\nhttps://github.com/user-attachments/assets/7cf720b8-5b31-4cc9-b213-21472ea880d6\r\n\r\nThe
rest of the flyout's behavior remains untouched:\r\n- identical default
widths\r\n- user selected widths are still applied\r\n- no changes to
the preview behavior\r\n\r\n### Checklist\r\n\r\n- [ ] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"7a9bf1399c39e9306bbfb23e73a4d72fe8aae967"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","8.17","8.16"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/210225","number":210225,"mergeCommit":{"message":"[Security
Solution][Expandable flyout] fix flyout flickering when opening/closing
left panel (#210225)\n\n## Summary\r\n\r\nWe recently improved the
expandable flyout by adding support for a\r\n[fully resizable
flyout](https://github.com/elastic/kibana/pull/192906).\r\nThis work
introduce a minor inconvenience, where the right panel
gets\r\nre-rendered every time the user expands or collapses the
flyout.\r\n\r\nThis PR fixes this issue by better using the EUI
resizable container\r\n(see how to externally control a resizable
container\r\n[here](https://eui.elastic.co/#/layout/resizable-container#collapsible-panels-with-external-control)).\r\nThe
flyout is now always showing a resizable container (even in\r\ncollapsed
mode) but EUI manages internally hiding the left section and\r\nthe
resize button.\r\n\r\n#### Old
behavior\r\n\r\n\r\nhttps://github.com/user-attachments/assets/4d7589ec-0edf-4690-9ce4-7b969ae0bb44\r\n\r\n####
New
behavior\r\n\r\n\r\nhttps://github.com/user-attachments/assets/7cf720b8-5b31-4cc9-b213-21472ea880d6\r\n\r\nThe
rest of the flyout's behavior remains untouched:\r\n- identical default
widths\r\n- user selected widths are still applied\r\n- no changes to
the preview behavior\r\n\r\n### Checklist\r\n\r\n- [ ] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"7a9bf1399c39e9306bbfb23e73a4d72fe8aae967"}},{"branch":"8.17","label":"v8.17.3","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.16","label":"v8.16.5","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->
PhilippeOberti added a commit that referenced this pull request Feb 8, 2025
…hen opening/closing left panel (#210225) (#210289)

# Backport

This will backport the following commits from `main` to `8.17`:
- [[Security Solution][Expandable flyout] fix flyout flickering when
opening/closing left panel
(#210225)](#210225)

<!--- Backport version: 9.6.4 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Philippe
Oberti","email":"philippe.oberti@elastic.co"},"sourceCommit":{"committedDate":"2025-02-07T22:34:27Z","message":"[Security
Solution][Expandable flyout] fix flyout flickering when opening/closing
left panel (#210225)\n\n## Summary\r\n\r\nWe recently improved the
expandable flyout by adding support for a\r\n[fully resizable
flyout](https://github.com/elastic/kibana/pull/192906).\r\nThis work
introduce a minor inconvenience, where the right panel
gets\r\nre-rendered every time the user expands or collapses the
flyout.\r\n\r\nThis PR fixes this issue by better using the EUI
resizable container\r\n(see how to externally control a resizable
container\r\n[here](https://eui.elastic.co/#/layout/resizable-container#collapsible-panels-with-external-control)).\r\nThe
flyout is now always showing a resizable container (even in\r\ncollapsed
mode) but EUI manages internally hiding the left section and\r\nthe
resize button.\r\n\r\n#### Old
behavior\r\n\r\n\r\nhttps://github.com/user-attachments/assets/4d7589ec-0edf-4690-9ce4-7b969ae0bb44\r\n\r\n####
New
behavior\r\n\r\n\r\nhttps://github.com/user-attachments/assets/7cf720b8-5b31-4cc9-b213-21472ea880d6\r\n\r\nThe
rest of the flyout's behavior remains untouched:\r\n- identical default
widths\r\n- user selected widths are still applied\r\n- no changes to
the preview behavior\r\n\r\n### Checklist\r\n\r\n- [ ] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"7a9bf1399c39e9306bbfb23e73a4d72fe8aae967","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Threat
Hunting:Investigations","backport:version","v8.18.0","v9.1.0","v8.17.3","v8.16.5"],"title":"[Security
Solution][Expandable flyout] fix flyout flickering when opening/closing
left
panel","number":210225,"url":"https://github.com/elastic/kibana/pull/210225","mergeCommit":{"message":"[Security
Solution][Expandable flyout] fix flyout flickering when opening/closing
left panel (#210225)\n\n## Summary\r\n\r\nWe recently improved the
expandable flyout by adding support for a\r\n[fully resizable
flyout](https://github.com/elastic/kibana/pull/192906).\r\nThis work
introduce a minor inconvenience, where the right panel
gets\r\nre-rendered every time the user expands or collapses the
flyout.\r\n\r\nThis PR fixes this issue by better using the EUI
resizable container\r\n(see how to externally control a resizable
container\r\n[here](https://eui.elastic.co/#/layout/resizable-container#collapsible-panels-with-external-control)).\r\nThe
flyout is now always showing a resizable container (even in\r\ncollapsed
mode) but EUI manages internally hiding the left section and\r\nthe
resize button.\r\n\r\n#### Old
behavior\r\n\r\n\r\nhttps://github.com/user-attachments/assets/4d7589ec-0edf-4690-9ce4-7b969ae0bb44\r\n\r\n####
New
behavior\r\n\r\n\r\nhttps://github.com/user-attachments/assets/7cf720b8-5b31-4cc9-b213-21472ea880d6\r\n\r\nThe
rest of the flyout's behavior remains untouched:\r\n- identical default
widths\r\n- user selected widths are still applied\r\n- no changes to
the preview behavior\r\n\r\n### Checklist\r\n\r\n- [ ] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"7a9bf1399c39e9306bbfb23e73a4d72fe8aae967"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","8.17","8.16"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/210225","number":210225,"mergeCommit":{"message":"[Security
Solution][Expandable flyout] fix flyout flickering when opening/closing
left panel (#210225)\n\n## Summary\r\n\r\nWe recently improved the
expandable flyout by adding support for a\r\n[fully resizable
flyout](https://github.com/elastic/kibana/pull/192906).\r\nThis work
introduce a minor inconvenience, where the right panel
gets\r\nre-rendered every time the user expands or collapses the
flyout.\r\n\r\nThis PR fixes this issue by better using the EUI
resizable container\r\n(see how to externally control a resizable
container\r\n[here](https://eui.elastic.co/#/layout/resizable-container#collapsible-panels-with-external-control)).\r\nThe
flyout is now always showing a resizable container (even in\r\ncollapsed
mode) but EUI manages internally hiding the left section and\r\nthe
resize button.\r\n\r\n#### Old
behavior\r\n\r\n\r\nhttps://github.com/user-attachments/assets/4d7589ec-0edf-4690-9ce4-7b969ae0bb44\r\n\r\n####
New
behavior\r\n\r\n\r\nhttps://github.com/user-attachments/assets/7cf720b8-5b31-4cc9-b213-21472ea880d6\r\n\r\nThe
rest of the flyout's behavior remains untouched:\r\n- identical default
widths\r\n- user selected widths are still applied\r\n- no changes to
the preview behavior\r\n\r\n### Checklist\r\n\r\n- [ ] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"7a9bf1399c39e9306bbfb23e73a4d72fe8aae967"}},{"branch":"8.17","label":"v8.17.3","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.16","label":"v8.16.5","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->
PhilippeOberti added a commit that referenced this pull request Feb 8, 2025
…hen opening/closing left panel (#210225) (#210288)

# Backport

This will backport the following commits from `main` to `8.18`:
- [[Security Solution][Expandable flyout] fix flyout flickering when
opening/closing left panel
(#210225)](#210225)

<!--- Backport version: 9.6.4 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Philippe
Oberti","email":"philippe.oberti@elastic.co"},"sourceCommit":{"committedDate":"2025-02-07T22:34:27Z","message":"[Security
Solution][Expandable flyout] fix flyout flickering when opening/closing
left panel (#210225)\n\n## Summary\r\n\r\nWe recently improved the
expandable flyout by adding support for a\r\n[fully resizable
flyout](https://github.com/elastic/kibana/pull/192906).\r\nThis work
introduce a minor inconvenience, where the right panel
gets\r\nre-rendered every time the user expands or collapses the
flyout.\r\n\r\nThis PR fixes this issue by better using the EUI
resizable container\r\n(see how to externally control a resizable
container\r\n[here](https://eui.elastic.co/#/layout/resizable-container#collapsible-panels-with-external-control)).\r\nThe
flyout is now always showing a resizable container (even in\r\ncollapsed
mode) but EUI manages internally hiding the left section and\r\nthe
resize button.\r\n\r\n#### Old
behavior\r\n\r\n\r\nhttps://github.com/user-attachments/assets/4d7589ec-0edf-4690-9ce4-7b969ae0bb44\r\n\r\n####
New
behavior\r\n\r\n\r\nhttps://github.com/user-attachments/assets/7cf720b8-5b31-4cc9-b213-21472ea880d6\r\n\r\nThe
rest of the flyout's behavior remains untouched:\r\n- identical default
widths\r\n- user selected widths are still applied\r\n- no changes to
the preview behavior\r\n\r\n### Checklist\r\n\r\n- [ ] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"7a9bf1399c39e9306bbfb23e73a4d72fe8aae967","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Threat
Hunting:Investigations","backport:version","v8.18.0","v9.1.0","v8.17.3","v8.16.5"],"title":"[Security
Solution][Expandable flyout] fix flyout flickering when opening/closing
left
panel","number":210225,"url":"https://github.com/elastic/kibana/pull/210225","mergeCommit":{"message":"[Security
Solution][Expandable flyout] fix flyout flickering when opening/closing
left panel (#210225)\n\n## Summary\r\n\r\nWe recently improved the
expandable flyout by adding support for a\r\n[fully resizable
flyout](https://github.com/elastic/kibana/pull/192906).\r\nThis work
introduce a minor inconvenience, where the right panel
gets\r\nre-rendered every time the user expands or collapses the
flyout.\r\n\r\nThis PR fixes this issue by better using the EUI
resizable container\r\n(see how to externally control a resizable
container\r\n[here](https://eui.elastic.co/#/layout/resizable-container#collapsible-panels-with-external-control)).\r\nThe
flyout is now always showing a resizable container (even in\r\ncollapsed
mode) but EUI manages internally hiding the left section and\r\nthe
resize button.\r\n\r\n#### Old
behavior\r\n\r\n\r\nhttps://github.com/user-attachments/assets/4d7589ec-0edf-4690-9ce4-7b969ae0bb44\r\n\r\n####
New
behavior\r\n\r\n\r\nhttps://github.com/user-attachments/assets/7cf720b8-5b31-4cc9-b213-21472ea880d6\r\n\r\nThe
rest of the flyout's behavior remains untouched:\r\n- identical default
widths\r\n- user selected widths are still applied\r\n- no changes to
the preview behavior\r\n\r\n### Checklist\r\n\r\n- [ ] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"7a9bf1399c39e9306bbfb23e73a4d72fe8aae967"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","8.17","8.16"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/210225","number":210225,"mergeCommit":{"message":"[Security
Solution][Expandable flyout] fix flyout flickering when opening/closing
left panel (#210225)\n\n## Summary\r\n\r\nWe recently improved the
expandable flyout by adding support for a\r\n[fully resizable
flyout](https://github.com/elastic/kibana/pull/192906).\r\nThis work
introduce a minor inconvenience, where the right panel
gets\r\nre-rendered every time the user expands or collapses the
flyout.\r\n\r\nThis PR fixes this issue by better using the EUI
resizable container\r\n(see how to externally control a resizable
container\r\n[here](https://eui.elastic.co/#/layout/resizable-container#collapsible-panels-with-external-control)).\r\nThe
flyout is now always showing a resizable container (even in\r\ncollapsed
mode) but EUI manages internally hiding the left section and\r\nthe
resize button.\r\n\r\n#### Old
behavior\r\n\r\n\r\nhttps://github.com/user-attachments/assets/4d7589ec-0edf-4690-9ce4-7b969ae0bb44\r\n\r\n####
New
behavior\r\n\r\n\r\nhttps://github.com/user-attachments/assets/7cf720b8-5b31-4cc9-b213-21472ea880d6\r\n\r\nThe
rest of the flyout's behavior remains untouched:\r\n- identical default
widths\r\n- user selected widths are still applied\r\n- no changes to
the preview behavior\r\n\r\n### Checklist\r\n\r\n- [ ] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"7a9bf1399c39e9306bbfb23e73a4d72fe8aae967"}},{"branch":"8.17","label":"v8.17.3","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.16","label":"v8.16.5","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->
PhilippeOberti added a commit that referenced this pull request Feb 8, 2025
…en opening/closing left panel (#210225) (#210287)

# Backport

This will backport the following commits from `main` to `9.0`:
- [[Security Solution][Expandable flyout] fix flyout flickering when
opening/closing left panel
(#210225)](#210225)

<!--- Backport version: 9.6.4 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Philippe
Oberti","email":"philippe.oberti@elastic.co"},"sourceCommit":{"committedDate":"2025-02-07T22:34:27Z","message":"[Security
Solution][Expandable flyout] fix flyout flickering when opening/closing
left panel (#210225)\n\n## Summary\r\n\r\nWe recently improved the
expandable flyout by adding support for a\r\n[fully resizable
flyout](https://github.com/elastic/kibana/pull/192906).\r\nThis work
introduce a minor inconvenience, where the right panel
gets\r\nre-rendered every time the user expands or collapses the
flyout.\r\n\r\nThis PR fixes this issue by better using the EUI
resizable container\r\n(see how to externally control a resizable
container\r\n[here](https://eui.elastic.co/#/layout/resizable-container#collapsible-panels-with-external-control)).\r\nThe
flyout is now always showing a resizable container (even in\r\ncollapsed
mode) but EUI manages internally hiding the left section and\r\nthe
resize button.\r\n\r\n#### Old
behavior\r\n\r\n\r\nhttps://github.com/user-attachments/assets/4d7589ec-0edf-4690-9ce4-7b969ae0bb44\r\n\r\n####
New
behavior\r\n\r\n\r\nhttps://github.com/user-attachments/assets/7cf720b8-5b31-4cc9-b213-21472ea880d6\r\n\r\nThe
rest of the flyout's behavior remains untouched:\r\n- identical default
widths\r\n- user selected widths are still applied\r\n- no changes to
the preview behavior\r\n\r\n### Checklist\r\n\r\n- [ ] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"7a9bf1399c39e9306bbfb23e73a4d72fe8aae967","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Threat
Hunting:Investigations","backport:version","v8.18.0","v9.1.0","v8.17.3","v8.16.5"],"title":"[Security
Solution][Expandable flyout] fix flyout flickering when opening/closing
left
panel","number":210225,"url":"https://github.com/elastic/kibana/pull/210225","mergeCommit":{"message":"[Security
Solution][Expandable flyout] fix flyout flickering when opening/closing
left panel (#210225)\n\n## Summary\r\n\r\nWe recently improved the
expandable flyout by adding support for a\r\n[fully resizable
flyout](https://github.com/elastic/kibana/pull/192906).\r\nThis work
introduce a minor inconvenience, where the right panel
gets\r\nre-rendered every time the user expands or collapses the
flyout.\r\n\r\nThis PR fixes this issue by better using the EUI
resizable container\r\n(see how to externally control a resizable
container\r\n[here](https://eui.elastic.co/#/layout/resizable-container#collapsible-panels-with-external-control)).\r\nThe
flyout is now always showing a resizable container (even in\r\ncollapsed
mode) but EUI manages internally hiding the left section and\r\nthe
resize button.\r\n\r\n#### Old
behavior\r\n\r\n\r\nhttps://github.com/user-attachments/assets/4d7589ec-0edf-4690-9ce4-7b969ae0bb44\r\n\r\n####
New
behavior\r\n\r\n\r\nhttps://github.com/user-attachments/assets/7cf720b8-5b31-4cc9-b213-21472ea880d6\r\n\r\nThe
rest of the flyout's behavior remains untouched:\r\n- identical default
widths\r\n- user selected widths are still applied\r\n- no changes to
the preview behavior\r\n\r\n### Checklist\r\n\r\n- [ ] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"7a9bf1399c39e9306bbfb23e73a4d72fe8aae967"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","8.17","8.16"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/210225","number":210225,"mergeCommit":{"message":"[Security
Solution][Expandable flyout] fix flyout flickering when opening/closing
left panel (#210225)\n\n## Summary\r\n\r\nWe recently improved the
expandable flyout by adding support for a\r\n[fully resizable
flyout](https://github.com/elastic/kibana/pull/192906).\r\nThis work
introduce a minor inconvenience, where the right panel
gets\r\nre-rendered every time the user expands or collapses the
flyout.\r\n\r\nThis PR fixes this issue by better using the EUI
resizable container\r\n(see how to externally control a resizable
container\r\n[here](https://eui.elastic.co/#/layout/resizable-container#collapsible-panels-with-external-control)).\r\nThe
flyout is now always showing a resizable container (even in\r\ncollapsed
mode) but EUI manages internally hiding the left section and\r\nthe
resize button.\r\n\r\n#### Old
behavior\r\n\r\n\r\nhttps://github.com/user-attachments/assets/4d7589ec-0edf-4690-9ce4-7b969ae0bb44\r\n\r\n####
New
behavior\r\n\r\n\r\nhttps://github.com/user-attachments/assets/7cf720b8-5b31-4cc9-b213-21472ea880d6\r\n\r\nThe
rest of the flyout's behavior remains untouched:\r\n- identical default
widths\r\n- user selected widths are still applied\r\n- no changes to
the preview behavior\r\n\r\n### Checklist\r\n\r\n- [ ] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"7a9bf1399c39e9306bbfb23e73a4d72fe8aae967"}},{"branch":"8.17","label":"v8.17.3","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.16","label":"v8.16.5","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->
PhilippeOberti added a commit that referenced this pull request Feb 8, 2025
…en opening/closing left panel (#210225) (#210292)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Security Solution][Expandable flyout] fix flyout flickering when
opening/closing left panel
(#210225)](#210225)

<!--- Backport version: 9.6.4 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Philippe
Oberti","email":"philippe.oberti@elastic.co"},"sourceCommit":{"committedDate":"2025-02-07T22:34:27Z","message":"[Security
Solution][Expandable flyout] fix flyout flickering when opening/closing
left panel (#210225)\n\n## Summary\r\n\r\nWe recently improved the
expandable flyout by adding support for a\r\n[fully resizable
flyout](https://github.com/elastic/kibana/pull/192906).\r\nThis work
introduce a minor inconvenience, where the right panel
gets\r\nre-rendered every time the user expands or collapses the
flyout.\r\n\r\nThis PR fixes this issue by better using the EUI
resizable container\r\n(see how to externally control a resizable
container\r\n[here](https://eui.elastic.co/#/layout/resizable-container#collapsible-panels-with-external-control)).\r\nThe
flyout is now always showing a resizable container (even in\r\ncollapsed
mode) but EUI manages internally hiding the left section and\r\nthe
resize button.\r\n\r\n#### Old
behavior\r\n\r\n\r\nhttps://github.com/user-attachments/assets/4d7589ec-0edf-4690-9ce4-7b969ae0bb44\r\n\r\n####
New
behavior\r\n\r\n\r\nhttps://github.com/user-attachments/assets/7cf720b8-5b31-4cc9-b213-21472ea880d6\r\n\r\nThe
rest of the flyout's behavior remains untouched:\r\n- identical default
widths\r\n- user selected widths are still applied\r\n- no changes to
the preview behavior\r\n\r\n### Checklist\r\n\r\n- [ ] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"7a9bf1399c39e9306bbfb23e73a4d72fe8aae967","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Threat
Hunting:Investigations","backport:version","v8.18.0","v9.1.0","v8.17.3","v8.16.5"],"title":"[Security
Solution][Expandable flyout] fix flyout flickering when opening/closing
left
panel","number":210225,"url":"https://github.com/elastic/kibana/pull/210225","mergeCommit":{"message":"[Security
Solution][Expandable flyout] fix flyout flickering when opening/closing
left panel (#210225)\n\n## Summary\r\n\r\nWe recently improved the
expandable flyout by adding support for a\r\n[fully resizable
flyout](https://github.com/elastic/kibana/pull/192906).\r\nThis work
introduce a minor inconvenience, where the right panel
gets\r\nre-rendered every time the user expands or collapses the
flyout.\r\n\r\nThis PR fixes this issue by better using the EUI
resizable container\r\n(see how to externally control a resizable
container\r\n[here](https://eui.elastic.co/#/layout/resizable-container#collapsible-panels-with-external-control)).\r\nThe
flyout is now always showing a resizable container (even in\r\ncollapsed
mode) but EUI manages internally hiding the left section and\r\nthe
resize button.\r\n\r\n#### Old
behavior\r\n\r\n\r\nhttps://github.com/user-attachments/assets/4d7589ec-0edf-4690-9ce4-7b969ae0bb44\r\n\r\n####
New
behavior\r\n\r\n\r\nhttps://github.com/user-attachments/assets/7cf720b8-5b31-4cc9-b213-21472ea880d6\r\n\r\nThe
rest of the flyout's behavior remains untouched:\r\n- identical default
widths\r\n- user selected widths are still applied\r\n- no changes to
the preview behavior\r\n\r\n### Checklist\r\n\r\n- [ ] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"7a9bf1399c39e9306bbfb23e73a4d72fe8aae967"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/210287","number":210287,"state":"OPEN"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/210288","number":210288,"state":"OPEN"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/210225","number":210225,"mergeCommit":{"message":"[Security
Solution][Expandable flyout] fix flyout flickering when opening/closing
left panel (#210225)\n\n## Summary\r\n\r\nWe recently improved the
expandable flyout by adding support for a\r\n[fully resizable
flyout](https://github.com/elastic/kibana/pull/192906).\r\nThis work
introduce a minor inconvenience, where the right panel
gets\r\nre-rendered every time the user expands or collapses the
flyout.\r\n\r\nThis PR fixes this issue by better using the EUI
resizable container\r\n(see how to externally control a resizable
container\r\n[here](https://eui.elastic.co/#/layout/resizable-container#collapsible-panels-with-external-control)).\r\nThe
flyout is now always showing a resizable container (even in\r\ncollapsed
mode) but EUI manages internally hiding the left section and\r\nthe
resize button.\r\n\r\n#### Old
behavior\r\n\r\n\r\nhttps://github.com/user-attachments/assets/4d7589ec-0edf-4690-9ce4-7b969ae0bb44\r\n\r\n####
New
behavior\r\n\r\n\r\nhttps://github.com/user-attachments/assets/7cf720b8-5b31-4cc9-b213-21472ea880d6\r\n\r\nThe
rest of the flyout's behavior remains untouched:\r\n- identical default
widths\r\n- user selected widths are still applied\r\n- no changes to
the preview behavior\r\n\r\n### Checklist\r\n\r\n- [ ] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"7a9bf1399c39e9306bbfb23e73a4d72fe8aae967"}},{"branch":"8.17","label":"v8.17.3","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/210289","number":210289,"state":"OPEN"},{"branch":"8.16","label":"v8.16.5","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/210291","number":210291,"state":"OPEN"}]}]
BACKPORT-->
@mistic
Copy link
Copy Markdown
Contributor

mistic commented Feb 11, 2025

This PR didn't make it into the latest BC for v8.16.4 and v8.17.2. Updating the labels.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:version Backport to applied version labels release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting:Investigations Security Solution Threat Hunting Investigations Team v8.16.5 v8.17.3 v8.18.0 v8.19.0 v9.0.0 v9.1.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants