[8.x] [Security Solution][Expandable flyout] fix flyout flickering when opening/closing left panel (#210225)#210292
Merged
PhilippeOberti merged 1 commit intoelastic:8.xfrom Feb 8, 2025
Conversation
…ning/closing left panel (elastic#210225) ## Summary We recently improved the expandable flyout by adding support for a [fully resizable flyout](elastic#192906). This work introduce a minor inconvenience, where the right panel gets re-rendered every time the user expands or collapses the flyout. This PR fixes this issue by better using the EUI resizable container (see how to externally control a resizable container [here](https://eui.elastic.co/#/layout/resizable-container#collapsible-panels-with-external-control)). The flyout is now always showing a resizable container (even in collapsed mode) but EUI manages internally hiding the left section and the resize button. #### Old behavior https://github.com/user-attachments/assets/4d7589ec-0edf-4690-9ce4-7b969ae0bb44 #### New behavior https://github.com/user-attachments/assets/7cf720b8-5b31-4cc9-b213-21472ea880d6 The rest of the flyout's behavior remains untouched: - identical default widths - user selected widths are still applied - no changes to the preview behavior ### Checklist - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit 7a9bf13)
Contributor
💚 Build Succeeded
Metrics [docs]Async chunks
|
christineweng
approved these changes
Feb 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.x:Questions ?
Please refer to the Backport tool documentation