[9.0] [Dashboard] Ensure resize handle does not overlap sticky header#209937
Merged
Heenawter merged 1 commit intoelastic:9.0from Feb 6, 2025
Merged
Conversation
Contributor
|
Pinging @elastic/kibana-presentation (Team:Presentation) |
Contributor
💚 Build Succeeded
Metrics [docs]Async chunks
cc @Heenawter |
nreese
approved these changes
Feb 6, 2025
Contributor
nreese
left a comment
There was a problem hiding this comment.
LGTM. Thanks for getting this fix backported to 8.18 and 9.0
code review only
Contributor
Author
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
Heenawter
added a commit
to Heenawter/kibana
that referenced
this pull request
Feb 6, 2025
…elastic#209937) ## Summary Since elastic#207275 is too large to backport to `9.0`/`8.18` and will only be in `9.1`/`8.19`, I wanted to at least backport **just** the z-index fix for the resize handler as described [here](https://github.com/elastic/kibana/pull/207275/files#r1931305375) . Unfortunately, the z-index used in that PR (`euiTheme.levels.maskBelowHeader`) only works thanks to other hover-action style changes, so I've had to set a hardcoded z-index (`2000`) in this PR instead. This acts as a "quick fix" for a pretty annoying bug while avoiding the risk of backporting the entire presentation panel refactor PR to `9.0`/`8.18` | Before | After | |--------|--------| |  |  | (cherry picked from commit 7ebe1bf)
Heenawter
added a commit
that referenced
this pull request
Feb 6, 2025
… header (#209937) (#210031) # Backport This will backport the following commits from `9.0` to `8.18`: - [[9.0] [Dashboard] Ensure resize handle does not overlap sticky header (#209937)](#209937) <!--- Backport version: 9.6.4 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Hannah Mudge","email":"Heenawter@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-02-06T15:03:28Z","message":"[9.0] [Dashboard] Ensure resize handle does not overlap sticky header (#209937)\n\n## Summary\r\n\r\nSince #207275 is too large to\r\nbackport to `9.0`/`8.18` and will only be in `9.1`/`8.19`, I wanted to\r\nat least backport **just** the z-index fix for the resize handler as\r\ndescribed\r\n[here](https://github.com/elastic/kibana/pull/207275/files#r1931305375)\r\n. Unfortunately, the z-index used in that PR\r\n(`euiTheme.levels.maskBelowHeader`) only works thanks to other\r\nhover-action style changes, so I've had to set a hardcoded z-index\r\n(`2000`) in this PR instead. This acts as a \"quick fix\" for a pretty\r\nannoying bug while avoiding the risk of backporting the entire\r\npresentation panel refactor PR to `9.0`/`8.18`\r\n\r\n\r\n| Before | After |\r\n|--------|--------|\r\n| \r\n|\r\n\r\n|","sha":"7ebe1bf8d020e5b732b22aa2a23adaae8bb5bb48","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Presentation","loe:small","release_note:skip","impact:low","backport:version","v8.18.0"],"title":"[9.0] [Dashboard] Ensure resize handle does not overlap sticky header","number":209937,"url":"https://github.com/elastic/kibana/pull/209937","mergeCommit":{"message":"[9.0] [Dashboard] Ensure resize handle does not overlap sticky header (#209937)\n\n## Summary\r\n\r\nSince #207275 is too large to\r\nbackport to `9.0`/`8.18` and will only be in `9.1`/`8.19`, I wanted to\r\nat least backport **just** the z-index fix for the resize handler as\r\ndescribed\r\n[here](https://github.com/elastic/kibana/pull/207275/files#r1931305375)\r\n. Unfortunately, the z-index used in that PR\r\n(`euiTheme.levels.maskBelowHeader`) only works thanks to other\r\nhover-action style changes, so I've had to set a hardcoded z-index\r\n(`2000`) in this PR instead. This acts as a \"quick fix\" for a pretty\r\nannoying bug while avoiding the risk of backporting the entire\r\npresentation panel refactor PR to `9.0`/`8.18`\r\n\r\n\r\n| Before | After |\r\n|--------|--------|\r\n| \r\n|\r\n\r\n|","sha":"7ebe1bf8d020e5b732b22aa2a23adaae8bb5bb48"}},"sourceBranch":"9.0","suggestedTargetBranches":["8.18"],"targetPullRequestStates":[{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT-->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Since #207275 is too large to backport to
9.0/8.18and will only be in9.1/8.19, I wanted to at least backport just the z-index fix for the resize handler as described here . Unfortunately, the z-index used in that PR (euiTheme.levels.maskBelowHeader) only works thanks to other hover-action style changes, so I've had to set a hardcoded z-index (2000) in this PR instead. This acts as a "quick fix" for a pretty annoying bug while avoiding the risk of backporting the entire presentation panel refactor PR to9.0/8.18