Skip to content

[8.18] [9.0] [Dashboard] Ensure resize handle does not overlap sticky header (#209937)#210031

Merged
Heenawter merged 1 commit intoelastic:8.18from
Heenawter:backport/8.18/pr-209937
Feb 6, 2025
Merged

[8.18] [9.0] [Dashboard] Ensure resize handle does not overlap sticky header (#209937)#210031
Heenawter merged 1 commit intoelastic:8.18from
Heenawter:backport/8.18/pr-209937

Conversation

@Heenawter
Copy link
Copy Markdown
Contributor

Backport

This will backport the following commits from 9.0 to 8.18:

Questions ?

Please refer to the Backport tool documentation

…elastic#209937)

## Summary

Since elastic#207275 is too large to
backport to `9.0`/`8.18` and will only be in `9.1`/`8.19`, I wanted to
at least backport **just** the z-index fix for the resize handler as
described
[here](https://github.com/elastic/kibana/pull/207275/files#r1931305375)
. Unfortunately, the z-index used in that PR
(`euiTheme.levels.maskBelowHeader`) only works thanks to other
hover-action style changes, so I've had to set a hardcoded z-index
(`2000`) in this PR instead. This acts as a "quick fix" for a pretty
annoying bug while avoiding the risk of backporting the entire
presentation panel refactor PR to `9.0`/`8.18`

| Before | After |
|--------|--------|
| ![Screenshot 2025-01-23 at 5 49
13 PM](https://github.com/user-attachments/assets/ea5f2ffe-46bd-4259-920a-8798a1a08775)
|
![image](https://github.com/user-attachments/assets/52a6ac63-5bb3-4cc0-a77d-99cac756aaa4)
|

(cherry picked from commit 7ebe1bf)
@Heenawter Heenawter added the backport This PR is a backport of another PR label Feb 6, 2025
@Heenawter Heenawter enabled auto-merge (squash) February 6, 2025 15:11
@elasticmachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
dashboard 596.6KB 596.5KB -13.0B

@Heenawter Heenawter merged commit b97ae80 into elastic:8.18 Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants