[Fleet] Re-enable kibana version checks in 9.0#208169
[Fleet] Re-enable kibana version checks in 9.0#208169jsoriano merged 13 commits intoelastic:mainfrom
Conversation
|
Pinging @elastic/fleet (Team:Fleet) |
|
Looks like the |
|
We need to add a 9.0.0 condition to the integration, publish a new version, and let the |
Doing this in elastic/integrations#12460 Another option by now would be to keep the disable in the kibana config used for testing, as we were doing in https://github.com/elastic/kibana/pull/198172/files#diff-292c3f307d3d0d341a361d12416d04609a3f525be268242c2a06be06fd8d5810L188 |
|
Tests also expect for the apache package to be available. |
|
Looks like there are test failures with brittle assertions that are expecting a certain number of packages to exist, etc. I think we should probably skip these tests and replace them with something more robust. @nchaulet what do you think? I think we have run into problems like this before and wondering what your take is. |
I am not sure what will be the best solution here, as we are running test with Also disabling that flag in tests is kind of tricky as we will not test the same behaviour. Should we wait to have the most important packages available? merging this without having |
|
9.0 has been branched, we will have to backport this change. |
|
@kpollich @nchaulet wdyt about disabling by now the constraint via config for tests, adding this to (it was initially done this way https://github.com/elastic/kibana/pull/198172/files#diff-292c3f307d3d0d341a361d12416d04609a3f525be268242c2a06be06fd8d5810L188) |
827eff0 to
e2d83ca
Compare
…-9.0' into re-enable-kibana-version-check-9.0
|
I have modified some test configs so we keep version constraints disabled for these tests, but not for anything else. @juliaElastic @nchaulet could any of you please do another review? Thanks! |
pheyos
left a comment
There was a problem hiding this comment.
x-pack/test/functional/config.base.js changes LGTM
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]
History
cc @jsoriano |
|
@elastic/kibana-cloud-security-posture could you please take a look 🙏 Thanks! |
|
Starting backport for target branches: 9.0 |
Revert the change in elastic#198172. It re-enables version constraints for packages in 9.0 by default, following the plan described in internal issue elastic/ingest-dev#4484. We already have some packages ready for 9.0, and many more coming, so it should be enough for testing purposes during the FF. Adjust some tests config so they continue disabling the constraints, as they expect more packages than the ones available now. (cherry picked from commit a25dc3f)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
# Backport This will backport the following commits from `main` to `9.0`: - [[Fleet] Re-enable kibana version checks in 9.0 (#208169)](#208169) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Jaime Soriano Pastor","email":"jaime.soriano@elastic.co"},"sourceCommit":{"committedDate":"2025-02-11T13:58:08Z","message":"[Fleet] Re-enable kibana version checks in 9.0 (#208169)\n\nRevert the change in https://github.com/elastic/kibana/issues/198172.\n\nIt re-enables version constraints for packages in 9.0 by default,\nfollowing the plan described in internal issue\nhttps://github.com/elastic/ingest-dev/issues/4484.\n\nWe already have some packages ready for 9.0, and many more coming, so it\nshould be enough for testing purposes during the FF.\n\nAdjust some tests config so they continue disabling the constraints, as they\nexpect more packages than the ones available now.","sha":"a25dc3f530f52a37e55f35c584b1b85cd34f4fcc","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Fleet","backport:prev-minor","v9.1.0"],"title":"[Fleet] Re-enable kibana version checks in 9.0","number":208169,"url":"https://github.com/elastic/kibana/pull/208169","mergeCommit":{"message":"[Fleet] Re-enable kibana version checks in 9.0 (#208169)\n\nRevert the change in https://github.com/elastic/kibana/issues/198172.\n\nIt re-enables version constraints for packages in 9.0 by default,\nfollowing the plan described in internal issue\nhttps://github.com/elastic/ingest-dev/issues/4484.\n\nWe already have some packages ready for 9.0, and many more coming, so it\nshould be enough for testing purposes during the FF.\n\nAdjust some tests config so they continue disabling the constraints, as they\nexpect more packages than the ones available now.","sha":"a25dc3f530f52a37e55f35c584b1b85cd34f4fcc"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/208169","number":208169,"mergeCommit":{"message":"[Fleet] Re-enable kibana version checks in 9.0 (#208169)\n\nRevert the change in https://github.com/elastic/kibana/issues/198172.\n\nIt re-enables version constraints for packages in 9.0 by default,\nfollowing the plan described in internal issue\nhttps://github.com/elastic/ingest-dev/issues/4484.\n\nWe already have some packages ready for 9.0, and many more coming, so it\nshould be enough for testing purposes during the FF.\n\nAdjust some tests config so they continue disabling the constraints, as they\nexpect more packages than the ones available now.","sha":"a25dc3f530f52a37e55f35c584b1b85cd34f4fcc"}}]}] BACKPORT--> Co-authored-by: Jaime Soriano Pastor <jaime.soriano@elastic.co>
…212382) ## Summary We re-enabled registry version checks in elastic#208169 but missed this Docker template. cc @jsoriano (cherry picked from commit 6d6db2f)
…12382) (#212428) # Backport This will backport the following commits from `main` to `9.0`: - [[Fleet] Re-enable registry version check in Docker template (#212382)](#212382) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Kyle Pollich","email":"kyle.pollich@elastic.co"},"sourceCommit":{"committedDate":"2025-02-25T17:33:59Z","message":"[Fleet] Re-enable registry version check in Docker template (#212382)\n\n## Summary\n\nWe re-enabled registry version checks in\nhttps://github.com//pull/208169 but missed this Docker\ntemplate.\n\ncc @jsoriano","sha":"6d6db2fe669e34503d987fef5651d447869a3eba","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Fleet","backport:prev-minor","v9.1.0"],"title":"[Fleet] Re-enable registry version check in Docker template","number":212382,"url":"https://github.com/elastic/kibana/pull/212382","mergeCommit":{"message":"[Fleet] Re-enable registry version check in Docker template (#212382)\n\n## Summary\n\nWe re-enabled registry version checks in\nhttps://github.com//pull/208169 but missed this Docker\ntemplate.\n\ncc @jsoriano","sha":"6d6db2fe669e34503d987fef5651d447869a3eba"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/212382","number":212382,"mergeCommit":{"message":"[Fleet] Re-enable registry version check in Docker template (#212382)\n\n## Summary\n\nWe re-enabled registry version checks in\nhttps://github.com//pull/208169 but missed this Docker\ntemplate.\n\ncc @jsoriano","sha":"6d6db2fe669e34503d987fef5651d447869a3eba"}}]}] BACKPORT--> Co-authored-by: Kyle Pollich <kyle.pollich@elastic.co>
…212382) ## Summary We re-enabled registry version checks in elastic#208169 but missed this Docker template. cc @jsoriano
…212382) ## Summary We re-enabled registry version checks in elastic#208169 but missed this Docker template. cc @jsoriano
Summary
Revert the change in #198172.
It re-enables version constraints for packages in 9.0 by default, following the plan described in internal issue https://github.com/elastic/ingest-dev/issues/4484.
We already have some packages ready for 9.0, and many more coming, so it should be enough for testing purposes during the FF.
Checklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.
Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n supportDocumentation was added for features that require explanation or tutorialsUnit or functional tests were updated or added to match the most common scenariosIf a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker listThis was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. Therelease_note:breakinglabel should be applied in these situations.Flaky Test Runner was used on any tests changedrelease_note:*label is applied per the guidelinesIdentify risks
List of packages will be reduced to some few till more packages are prepared to 9.0. This situation will be addressed soon as most packages are being migrated these days.