[UII] Replace kibanaVersionCheckEnabled default value instead of config setting#198172
Merged
jen-huang merged 4 commits intoelastic:mainfrom Oct 30, 2024
Merged
[UII] Replace kibanaVersionCheckEnabled default value instead of config setting#198172jen-huang merged 4 commits intoelastic:mainfrom
kibanaVersionCheckEnabled default value instead of config setting#198172jen-huang merged 4 commits intoelastic:mainfrom
Conversation
Contributor
|
Pinging @elastic/fleet (Team:Fleet) |
6 tasks
kpollich
approved these changes
Oct 29, 2024
Member
kpollich
left a comment
There was a problem hiding this comment.
Makes sense to me from the Fleet side of things.
Contributor
💚 Build Succeeded
Metrics [docs]
History
cc @jen-huang |
jen-huang
commented
Oct 30, 2024
| capabilities: [], | ||
| excludePackages: [], | ||
| spec: { | ||
| internal: schema.object({ |
Contributor
Author
There was a problem hiding this comment.
made this schema object non-optional (removed schema.maybe wrapper), because the default values do not populate when it is optional, i.e. kibanaVersionCheckEnabled is undefined instead of false
afharo
approved these changes
Oct 30, 2024
Member
afharo
left a comment
There was a problem hiding this comment.
LGTM. Q: Should this PR be flagged as breaking change?
Contributor
Author
@afharo No, we plan on restoring the original behavior after elastic/package-registry#1226 is addressed. |
7 tasks
jsoriano
added a commit
that referenced
this pull request
Feb 11, 2025
Revert the change in #198172. It re-enables version constraints for packages in 9.0 by default, following the plan described in internal issue elastic/ingest-dev#4484. We already have some packages ready for 9.0, and many more coming, so it should be enough for testing purposes during the FF. Adjust some tests config so they continue disabling the constraints, as they expect more packages than the ones available now.
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 11, 2025
Revert the change in elastic#198172. It re-enables version constraints for packages in 9.0 by default, following the plan described in internal issue elastic/ingest-dev#4484. We already have some packages ready for 9.0, and many more coming, so it should be enough for testing purposes during the FF. Adjust some tests config so they continue disabling the constraints, as they expect more packages than the ones available now. (cherry picked from commit a25dc3f)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes
xpack.fleet.internal.registry.kibanaVersionCheckEnabled: falsefromkibana.ymlin favor of changing the default value that Fleet populates, so that we do not apply the Kibana version constraint to EPR requests for >= 9.0 deployments.Prior to this change, this setting was not applied to ESS deployments as
kibana.ymlis overridden there.I updated the related task in #192624 to reflect this change.