[AI Connector] Migrates AI inference Connector to use a shared components from '@kbn/inference-endpoint-ui-common'#204885
Merged
YulNaumenko merged 25 commits intoelastic:mainfrom Jan 7, 2025
Conversation
…tor through flyout
…ents from '@kbn/inference-endpoint-ui-common'
3 tasks
…hared-ui-components # Conflicts: # .github/CODEOWNERS # package.json # tsconfig.base.json # x-pack/.i18nrc.json # x-pack/packages/kbn-inference-endpoint-ui-common/src/components/additional_options_fields.tsx # x-pack/packages/kbn-inference-endpoint-ui-common/src/components/configuration/configuration_field.tsx # x-pack/packages/kbn-inference-endpoint-ui-common/src/components/configuration/configuration_form_items.tsx # x-pack/packages/kbn-inference-endpoint-ui-common/src/components/configuration/configuration_utils.ts # x-pack/packages/kbn-inference-endpoint-ui-common/src/components/providers/assets/images/alibaba_cloud.svg # x-pack/packages/kbn-inference-endpoint-ui-common/src/components/providers/assets/images/amazon_bedrock.svg # x-pack/packages/kbn-inference-endpoint-ui-common/src/components/providers/assets/images/anthropic.svg # x-pack/packages/kbn-inference-endpoint-ui-common/src/components/providers/assets/images/azure_ai_studio.svg # x-pack/packages/kbn-inference-endpoint-ui-common/src/components/providers/assets/images/azure_open_ai.svg # x-pack/packages/kbn-inference-endpoint-ui-common/src/components/providers/assets/images/cohere.svg # x-pack/packages/kbn-inference-endpoint-ui-common/src/components/providers/assets/images/elastic.svg # x-pack/packages/kbn-inference-endpoint-ui-common/src/components/providers/assets/images/google_ai_studio.svg # x-pack/packages/kbn-inference-endpoint-ui-common/src/components/providers/assets/images/hugging_face.svg # x-pack/packages/kbn-inference-endpoint-ui-common/src/components/providers/assets/images/ibm_watsonx.svg # x-pack/packages/kbn-inference-endpoint-ui-common/src/components/providers/assets/images/mistral.svg # x-pack/packages/kbn-inference-endpoint-ui-common/src/components/providers/assets/images/open_ai.svg # x-pack/packages/kbn-inference-endpoint-ui-common/src/components/providers/render_service_provider/service_provider.test.tsx # x-pack/packages/kbn-inference-endpoint-ui-common/src/components/providers/render_service_provider/service_provider.tsx # x-pack/packages/kbn-inference-endpoint-ui-common/src/components/providers/selectable.tsx # x-pack/platform/packages/shared/kbn-inference-endpoint-ui-common/src/components/providers/assets/images/alibaba_cloud.svg # x-pack/platform/packages/shared/kbn-inference-endpoint-ui-common/src/components/providers/assets/images/amazon_bedrock.svg # x-pack/platform/packages/shared/kbn-inference-endpoint-ui-common/src/components/providers/assets/images/anthropic.svg # x-pack/platform/packages/shared/kbn-inference-endpoint-ui-common/src/components/providers/assets/images/azure_ai_studio.svg # x-pack/platform/packages/shared/kbn-inference-endpoint-ui-common/src/components/providers/assets/images/azure_open_ai.svg # x-pack/platform/packages/shared/kbn-inference-endpoint-ui-common/src/components/providers/assets/images/cohere.svg # x-pack/platform/packages/shared/kbn-inference-endpoint-ui-common/src/components/providers/assets/images/elastic.svg # x-pack/platform/packages/shared/kbn-inference-endpoint-ui-common/src/components/providers/assets/images/google_ai_studio.svg # x-pack/platform/packages/shared/kbn-inference-endpoint-ui-common/src/components/providers/assets/images/hugging_face.svg # x-pack/platform/packages/shared/kbn-inference-endpoint-ui-common/src/components/providers/assets/images/ibm_watsonx.svg # x-pack/platform/packages/shared/kbn-inference-endpoint-ui-common/src/components/providers/assets/images/mistral.svg # x-pack/platform/packages/shared/kbn-inference-endpoint-ui-common/src/components/providers/assets/images/open_ai.svg # x-pack/platform/plugins/shared/stack_connectors/public/connector_types/inference/additional_options_fields.tsx # x-pack/platform/plugins/shared/stack_connectors/public/connector_types/inference/providers/get_providers.test.tsx # x-pack/platform/plugins/shared/stack_connectors/public/connector_types/inference/providers/render_service_provider/service_provider.test.tsx # x-pack/platform/plugins/shared/stack_connectors/public/connector_types/inference/providers/render_service_provider/service_provider.tsx # x-pack/platform/plugins/shared/stack_connectors/public/connector_types/inference/providers/selectable/index.test.tsx # x-pack/platform/plugins/shared/stack_connectors/public/connector_types/inference/providers/selectable/index.tsx # x-pack/platform/plugins/shared/stack_connectors/public/connector_types/lib/dynamic_config/connector_configuration_field.tsx # x-pack/platform/plugins/shared/stack_connectors/public/connector_types/lib/dynamic_config/connector_configuration_form_items.tsx # x-pack/platform/plugins/shared/stack_connectors/public/connector_types/lib/dynamic_config/connector_configuration_utils.ts # x-pack/plugins/stack_connectors/public/connector_types/inference/additional_options_fields.tsx # x-pack/plugins/stack_connectors/public/connector_types/inference/providers/assets/images/alibaba_cloud.svg # x-pack/plugins/stack_connectors/public/connector_types/inference/providers/assets/images/amazon_bedrock.svg # x-pack/plugins/stack_connectors/public/connector_types/inference/providers/assets/images/anthropic.svg # x-pack/plugins/stack_connectors/public/connector_types/inference/providers/assets/images/azure_ai_studio.svg # x-pack/plugins/stack_connectors/public/connector_types/inference/providers/assets/images/azure_open_ai.svg # x-pack/plugins/stack_connectors/public/connector_types/inference/providers/assets/images/cohere.svg # x-pack/plugins/stack_connectors/public/connector_types/inference/providers/assets/images/elastic.svg # x-pack/plugins/stack_connectors/public/connector_types/inference/providers/assets/images/google_ai_studio.svg # x-pack/plugins/stack_connectors/public/connector_types/inference/providers/assets/images/hugging_face.svg # x-pack/plugins/stack_connectors/public/connector_types/inference/providers/assets/images/ibm_watsonx.svg # x-pack/plugins/stack_connectors/public/connector_types/inference/providers/assets/images/mistral.svg # x-pack/plugins/stack_connectors/public/connector_types/inference/providers/assets/images/open_ai.svg # x-pack/plugins/stack_connectors/public/connector_types/inference/providers/render_service_provider/service_provider.test.tsx # x-pack/plugins/stack_connectors/public/connector_types/inference/providers/render_service_provider/service_provider.tsx # x-pack/plugins/stack_connectors/public/connector_types/inference/providers/selectable/index.tsx # x-pack/plugins/stack_connectors/public/connector_types/lib/dynamic_config/connector_configuration_field.tsx # x-pack/plugins/stack_connectors/public/connector_types/lib/dynamic_config/connector_configuration_form_items.tsx # x-pack/plugins/stack_connectors/public/connector_types/lib/dynamic_config/connector_configuration_utils.ts # x-pack/solutions/search/plugins/search_inference_endpoints/public/hooks/use_add_endpoint.test.tsx # x-pack/solutions/search/plugins/search_inference_endpoints/public/hooks/use_add_endpoint.ts # x-pack/solutions/search/plugins/search_inference_endpoints/public/hooks/use_providers.ts # x-pack/solutions/search/plugins/search_inference_endpoints/server/lib/add_inference_endpoint.test.ts # x-pack/solutions/search/plugins/search_inference_endpoints/server/lib/add_inference_endpoint.ts # x-pack/solutions/search/plugins/search_inference_endpoints/server/lib/fetch_inference_services.test.ts # x-pack/solutions/search/plugins/search_inference_endpoints/server/lib/fetch_inference_services.ts # x-pack/solutions/search/plugins/search_inference_endpoints/server/routes.ts # x-pack/solutions/search/plugins/search_inference_endpoints/server/utils/unflatten_object.ts # yarn.lock
…ulNaumenko/kibana into ai-connector-uses-shared-ui-components
stephmilovic
approved these changes
Jan 2, 2025
Contributor
stephmilovic
left a comment
There was a problem hiding this comment.
LGTM, thanks for the improvements!
adcoelho
approved these changes
Jan 3, 2025
ymao1
reviewed
Jan 3, 2025
| </> | ||
| ); | ||
| return !isLoading ? ( | ||
| <InferenceServiceFormFields providers={providers ?? []} isEdit={isEdit} /> |
Contributor
There was a problem hiding this comment.
since you're using the shared components now and it looks like the shared components have their own routes for getting the services configuration (hard-coded for now), should we also remove the server side routes in the stack_connectors folder?
…ulNaumenko/kibana into ai-connector-uses-shared-ui-components
Contributor
💔 Build Failed
Failed CI StepsHistory
cc @YulNaumenko |
Contributor
|
Starting backport for target branches: 8.x |
Contributor
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
Contributor
Author
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
This was referenced Jan 7, 2025
Contributor
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
3 similar comments
Contributor
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
Contributor
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
Contributor
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
Contributor
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
Contributor
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
1 similar comment
Contributor
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
Contributor
Author
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
Contributor
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
YulNaumenko
added a commit
that referenced
this pull request
Jan 17, 2025
…components from '@kbn/inference-endpoint-ui-common' (#204885) (#205671) # Backport This will backport the following commits from `main` to `8.x`: - [[AI Connector] Migrates AI inference Connector to use a shared components from '@kbn/inference-endpoint-ui-common' (#204885)](#204885) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Yuliia Naumenko","email":"jo.naumenko@gmail.com"},"sourceCommit":{"committedDate":"2025-01-07T04:22:20Z","message":"[AI Connector] Migrates AI inference Connector to use a shared components from '@kbn/inference-endpoint-ui-common' (#204885)\n\n1. Migrated stack-connector `.inference` to use share UI components\r\nhttps://github.com//pull/203204\r\n2. Extended package `@kbn/inference-endpoint-ui-common` to support edit\r\nmode for the form of the connector, by adding the optional property\r\n`isEdit` to `InferenceServiceFormFields` component\r\n3. Resolves flaky timing out test\r\nhttps://github.com//issues/205129\r\n\r\n---------\r\n\r\nCo-authored-by: Samiul Monir <samiul.monir@elastic.co>\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"47b19ba29c707eabf6c2bc12e21b714aae91ebed","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:version","8.18 candidate","v8.18.0"],"number":204885,"url":"https://github.com/elastic/kibana/pull/204885","mergeCommit":{"message":"[AI Connector] Migrates AI inference Connector to use a shared components from '@kbn/inference-endpoint-ui-common' (#204885)\n\n1. Migrated stack-connector `.inference` to use share UI components\r\nhttps://github.com//pull/203204\r\n2. Extended package `@kbn/inference-endpoint-ui-common` to support edit\r\nmode for the form of the connector, by adding the optional property\r\n`isEdit` to `InferenceServiceFormFields` component\r\n3. Resolves flaky timing out test\r\nhttps://github.com//issues/205129\r\n\r\n---------\r\n\r\nCo-authored-by: Samiul Monir <samiul.monir@elastic.co>\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"47b19ba29c707eabf6c2bc12e21b714aae91ebed"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/204885","number":204885,"mergeCommit":{"message":"[AI Connector] Migrates AI inference Connector to use a shared components from '@kbn/inference-endpoint-ui-common' (#204885)\n\n1. Migrated stack-connector `.inference` to use share UI components\r\nhttps://github.com//pull/203204\r\n2. Extended package `@kbn/inference-endpoint-ui-common` to support edit\r\nmode for the form of the connector, by adding the optional property\r\n`isEdit` to `InferenceServiceFormFields` component\r\n3. Resolves flaky timing out test\r\nhttps://github.com//issues/205129\r\n\r\n---------\r\n\r\nCo-authored-by: Samiul Monir <samiul.monir@elastic.co>\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"47b19ba29c707eabf6c2bc12e21b714aae91ebed"}},{"branch":"8.x","label":"v8.18.0","labelRegex":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT-->
viduni94
pushed a commit
to viduni94/kibana
that referenced
this pull request
Jan 23, 2025
…ents from '@kbn/inference-endpoint-ui-common' (elastic#204885) 1. Migrated stack-connector `.inference` to use share UI components elastic#203204 2. Extended package `@kbn/inference-endpoint-ui-common` to support edit mode for the form of the connector, by adding the optional property `isEdit` to `InferenceServiceFormFields` component 3. Resolves flaky timing out test elastic#205129 --------- Co-authored-by: Samiul Monir <samiul.monir@elastic.co> Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.inferenceto use share UI components [Search] Add Inference endpoint Flyout in Inference Management UI #203204@kbn/inference-endpoint-ui-commonto support edit mode for the form of the connector, by adding the optional propertyisEdittoInferenceServiceFormFieldscomponent