Skip to content

[Search] Add Inference endpoint Flyout in Inference Management UI#203204

Merged
Samiul-TheSoccerFan merged 19 commits intoelastic:mainfrom
Samiul-TheSoccerFan:package-ai-connector-ui-components
Dec 25, 2024
Merged

[Search] Add Inference endpoint Flyout in Inference Management UI#203204
Samiul-TheSoccerFan merged 19 commits intoelastic:mainfrom
Samiul-TheSoccerFan:package-ai-connector-ui-components

Conversation

@Samiul-TheSoccerFan
Copy link
Copy Markdown
Contributor

@Samiul-TheSoccerFan Samiul-TheSoccerFan commented Dec 6, 2024 •
edited by kibanamachine
Loading

Summary

This PR includes

  • Create a UI component package to share AI connector form between multiple plugins
  • Integrate the packaged components into the Search Inference Endpoint plugin.
open-ai.mov

Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

TattdCodeMonkey
TattdCodeMonkey reviewed Dec 6, 2024
View reviewed changes
@Samiul-TheSoccerFan Samiul-TheSoccerFan force-pushed the package-ai-connector-ui-components branch from f7b0a64 to 054e402 Compare December 8, 2024 23:31
YulNaumenko
YulNaumenko reviewed Dec 9, 2024
View reviewed changes
@Samiul-TheSoccerFan Samiul-TheSoccerFan changed the title [Search] Add Inference endpoint from Kibana [Search] Shared Package and Add Inference endpoint Flyout Dec 10, 2024
@Samiul-TheSoccerFan Samiul-TheSoccerFan force-pushed the package-ai-connector-ui-components branch from d4eac29 to 42763ea Compare December 16, 2024 15:57
@Samiul-TheSoccerFan Samiul-TheSoccerFan changed the title [Search] Shared Package and Add Inference endpoint Flyout [Search] Add Inference endpoint Flyout in Inference Management UI Dec 18, 2024
@Samiul-TheSoccerFan Samiul-TheSoccerFan added Team:Core Platform Core services: plugins, logging, config, saved objects, http, ES client, i18n, etc t// release_note:skip Skip the PR/issue when compiling release notes v9.0.0 Team:ML Team label for ML (also use :ml) t// Team:Search backport:version Backport to applied version labels v8.18.0 labels Dec 18, 2024
@Samiul-TheSoccerFan Samiul-TheSoccerFan force-pushed the package-ai-connector-ui-components branch from 42763ea to dc0465b Compare December 18, 2024 22:13
@Samiul-TheSoccerFan Samiul-TheSoccerFan marked this pull request as ready for review December 18, 2024 22:13
@Samiul-TheSoccerFan Samiul-TheSoccerFan requested review from a team as code owners December 18, 2024 22:13
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Dec 18, 2024

Pinging @elastic/kibana-core (Team:Core)

TinaHeiligers
TinaHeiligers approved these changes Dec 18, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@TinaHeiligers TinaHeiligers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to the plugin's manifest LGTM

YulNaumenko
YulNaumenko approved these changes Dec 19, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@YulNaumenko YulNaumenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for making the shared package, awesome work! I have a draft PR where AI connector fully migrated to use a new shared components #204885
I left a few minor clean up comments, but it could be done as a follow up.

gsoldevila
gsoldevila reviewed Dec 19, 2024
View reviewed changes
x-pack/packages/kbn-inference-endpoint-ui-common/kibana.jsonc
],
"group": "platform",
"visibility": "shared"
}
Copy link
Copy Markdown
Member

@gsoldevila gsoldevila Dec 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this package is going to be used from both Search solution and connectors, then I believe it makes sense to categorise it as platform/shared like you did.

However, the package should be placed under x-pack/platform/packages/shared.
Can you relocate it and update the PR?

Copy link
Copy Markdown
Contributor Author

@Samiul-TheSoccerFan Samiul-TheSoccerFan Dec 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gsoldevila : moved the package into x-pack/platform/packages/shared

@Samiul-TheSoccerFan
Copy link
Copy Markdown
Contributor Author

Samiul-TheSoccerFan commented Dec 23, 2024

@efegurkan Addressed most of the comments. The package is kind of shared and copied from AI connector so I can not make a huge change at this moment as it might break AI connector too. I have created few tickets to address these comments(which did not resolved in this PR) later part of the project.

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Dec 23, 2024 •
edited
Loading

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #1 / AddInferenceFlyout valid submission
  • [job] [logs] FTR Configs #1 / Spaces app space solution tour solution tour does not show the solution tour after deleting spaces and leave only the default

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
searchInferenceEndpoints 163 264 +101

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/inference-endpoint-ui-common - 30 +30

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
searchInferenceEndpoints 99.7KB 219.4KB +119.7KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
searchInferenceEndpoints 6.3KB 7.0KB +672.0B
Unknown metric groups

API count

id before after diff
@kbn/inference-endpoint-ui-common - 30 +30

ESLint disabled line counts

id before after diff
@kbn/inference-endpoint-ui-common - 1 +1

Total ESLint disabled count

id before after diff
@kbn/inference-endpoint-ui-common - 1 +1

History

efegurkan
efegurkan approved these changes Dec 24, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@efegurkan efegurkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@Samiul-TheSoccerFan Samiul-TheSoccerFan merged commit bc466ea into elastic:main Dec 25, 2024
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Dec 25, 2024

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12488907363

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Dec 25, 2024

💔 All backports failed

Status Branch Result
❌ 8.x Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 203204

Questions ?

Please refer to the Backport tool documentation

@Samiul-TheSoccerFan Samiul-TheSoccerFan mentioned this pull request Dec 26, 2024
Closed
@Samiul-TheSoccerFan
Copy link
Copy Markdown
Contributor Author

Samiul-TheSoccerFan commented Dec 26, 2024

💚 All backports created successfully

Status Branch Result
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

Samiul-TheSoccerFan added a commit to Samiul-TheSoccerFan/kibana that referenced this pull request Dec 26, 2024
@Samiul-TheSoccerFan
[Search] Add Inference endpoint Flyout in Inference Management UI (el…
0ab7bb6 
…astic#203204)

## Summary

This PR includes
- Create a UI component package to share AI connector form between
multiple plugins
- Integrate the packaged components into the `Search Inference Endpoint`
plugin.

https://github.com/user-attachments/assets/2b447b44-3d1d-4422-b76d-8d8fd160b2bc

### Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

- [X] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [X] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [X] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
(cherry picked from commit bc466ea)

# Conflicts:
#	.github/CODEOWNERS
#	x-pack/.i18nrc.json
@Samiul-TheSoccerFan Samiul-TheSoccerFan mentioned this pull request Dec 26, 2024
Merged
@Samiul-TheSoccerFan
Copy link
Copy Markdown
Contributor Author

Samiul-TheSoccerFan commented Dec 26, 2024

💚 All backports created successfully

Status Branch Result
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

Samiul-TheSoccerFan added a commit to Samiul-TheSoccerFan/kibana that referenced this pull request Dec 26, 2024
@Samiul-TheSoccerFan
[Search] Add Inference endpoint Flyout in Inference Management UI (el…
317d795 
…astic#203204)

## Summary

This PR includes
- Create a UI component package to share AI connector form between
multiple plugins
- Integrate the packaged components into the `Search Inference Endpoint`
plugin.

https://github.com/user-attachments/assets/2b447b44-3d1d-4422-b76d-8d8fd160b2bc

### Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

- [X] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [X] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [X] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
(cherry picked from commit bc466ea)

# Conflicts:
#	.github/CODEOWNERS
#	x-pack/.i18nrc.json
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Dec 27, 2024
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Dec 27, 2024

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

Samiul-TheSoccerFan added a commit that referenced this pull request Dec 27, 2024
@Samiul-TheSoccerFan @kibanamachine
[8.x] [Search] Add Inference endpoint Flyout in Inference Management …
a0c0c8c 
…UI (#203204) (#205172)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Search] Add Inference endpoint Flyout in Inference Management UI
(#203204)](#203204)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Samiul
Monir","email":"150824886+Samiul-TheSoccerFan@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-12-25T03:23:25Z","message":"[Search]
Add Inference endpoint Flyout in Inference Management UI (#203204)\n\n##
Summary\r\n\r\nThis PR includes\r\n- Create a UI component package to
share AI connector form between\r\nmultiple plugins\r\n- Integrate the
packaged components into the `Search Inference
Endpoint`\r\nplugin.\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/2b447b44-3d1d-4422-b76d-8d8fd160b2bc\r\n\r\n\r\n###
Checklist\r\n\r\nCheck the PR satisfies following conditions.
\r\n\r\nReviewers should verify this PR satisfies this list as
well.\r\n\r\n- [X] Any text added follows [EUI's
writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\r\nsentence case text and includes
[i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n-
[X] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [X] [Flaky
Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1)
was\r\nused on any tests changed\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by:
Elastic Machine
<elasticmachine@users.noreply.github.com>","sha":"bc466ea738107b00a8dbba216630369ff729d729","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Core","release_note:skip","v9.0.0","Team:Search","Team:ML","ci:project-deploy-elasticsearch","backport:version","v8.18.0"],"number":203204,"url":"https://github.com/elastic/kibana/pull/203204","mergeCommit":{"message":"[Search]
Add Inference endpoint Flyout in Inference Management UI (#203204)\n\n##
Summary\r\n\r\nThis PR includes\r\n- Create a UI component package to
share AI connector form between\r\nmultiple plugins\r\n- Integrate the
packaged components into the `Search Inference
Endpoint`\r\nplugin.\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/2b447b44-3d1d-4422-b76d-8d8fd160b2bc\r\n\r\n\r\n###
Checklist\r\n\r\nCheck the PR satisfies following conditions.
\r\n\r\nReviewers should verify this PR satisfies this list as
well.\r\n\r\n- [X] Any text added follows [EUI's
writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\r\nsentence case text and includes
[i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n-
[X] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [X] [Flaky
Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1)
was\r\nused on any tests changed\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by:
Elastic Machine
<elasticmachine@users.noreply.github.com>","sha":"bc466ea738107b00a8dbba216630369ff729d729"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/203204","number":203204,"mergeCommit":{"message":"[Search]
Add Inference endpoint Flyout in Inference Management UI (#203204)\n\n##
Summary\r\n\r\nThis PR includes\r\n- Create a UI component package to
share AI connector form between\r\nmultiple plugins\r\n- Integrate the
packaged components into the `Search Inference
Endpoint`\r\nplugin.\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/2b447b44-3d1d-4422-b76d-8d8fd160b2bc\r\n\r\n\r\n###
Checklist\r\n\r\nCheck the PR satisfies following conditions.
\r\n\r\nReviewers should verify this PR satisfies this list as
well.\r\n\r\n- [X] Any text added follows [EUI's
writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\r\nsentence case text and includes
[i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n-
[X] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [X] [Flaky
Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1)
was\r\nused on any tests changed\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by:
Elastic Machine
<elasticmachine@users.noreply.github.com>","sha":"bc466ea738107b00a8dbba216630369ff729d729"}},{"branch":"8.x","label":"v8.18.0","labelRegex":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Dec 27, 2024
@YulNaumenko YulNaumenko mentioned this pull request Dec 30, 2024
Merged
stratoula pushed a commit to stratoula/kibana that referenced this pull request Jan 2, 2025
@Samiul-TheSoccerFan @kibanamachine
@elasticmachine @stratoula
[Search] Add Inference endpoint Flyout in Inference Management UI (el…
cce91e5 
…astic#203204)

## Summary

This PR includes
- Create a UI component package to share AI connector form between
multiple plugins
- Integrate the packaged components into the `Search Inference Endpoint`
plugin.



https://github.com/user-attachments/assets/2b447b44-3d1d-4422-b76d-8d8fd160b2bc


### Checklist

Check the PR satisfies following conditions. 

Reviewers should verify this PR satisfies this list as well.

- [X] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [X] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [X] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
benakansara pushed a commit to benakansara/kibana that referenced this pull request Jan 2, 2025
@Samiul-TheSoccerFan @kibanamachine
@elasticmachine @benakansara
[Search] Add Inference endpoint Flyout in Inference Management UI (el…
ff12902 
…astic#203204)

## Summary

This PR includes
- Create a UI component package to share AI connector form between
multiple plugins
- Integrate the packaged components into the `Search Inference Endpoint`
plugin.



https://github.com/user-attachments/assets/2b447b44-3d1d-4422-b76d-8d8fd160b2bc


### Checklist

Check the PR satisfies following conditions. 

Reviewers should verify this PR satisfies this list as well.

- [X] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [X] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [X] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
YulNaumenko added a commit that referenced this pull request Jan 7, 2025
@YulNaumenko @Samiul-TheSoccerFan @kibanamachine
[AI Connector] Migrates AI inference Connector to use a shared compon…
47b19ba 
…ents from '@kbn/inference-endpoint-ui-common' (#204885)

1. Migrated stack-connector `.inference` to use share UI components
#203204
2. Extended package `@kbn/inference-endpoint-ui-common` to support edit
mode for the form of the connector, by adding the optional property
`isEdit` to `InferenceServiceFormFields` component
3. Resolves flaky timing out test
#205129

---------

Co-authored-by: Samiul Monir <samiul.monir@elastic.co>
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
YulNaumenko added a commit that referenced this pull request Jan 17, 2025
@YulNaumenko
[8.x] [AI Connector] Migrates AI inference Connector to use a shared …
7437653 
…components from '@kbn/inference-endpoint-ui-common' (#204885) (#205671)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[AI Connector] Migrates AI inference Connector to use a shared
components from '@kbn/inference-endpoint-ui-common'
(#204885)](#204885)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Yuliia
Naumenko","email":"jo.naumenko@gmail.com"},"sourceCommit":{"committedDate":"2025-01-07T04:22:20Z","message":"[AI
Connector] Migrates AI inference Connector to use a shared components
from '@kbn/inference-endpoint-ui-common' (#204885)\n\n1. Migrated
stack-connector `.inference` to use share UI
components\r\nhttps://github.com//pull/203204\r\n2.
Extended package `@kbn/inference-endpoint-ui-common` to support
edit\r\nmode for the form of the connector, by adding the optional
property\r\n`isEdit` to `InferenceServiceFormFields` component\r\n3.
Resolves flaky timing out
test\r\nhttps://github.com//issues/205129\r\n\r\n---------\r\n\r\nCo-authored-by:
Samiul Monir <samiul.monir@elastic.co>\r\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"47b19ba29c707eabf6c2bc12e21b714aae91ebed","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:version","8.18
candidate","v8.18.0"],"number":204885,"url":"https://github.com/elastic/kibana/pull/204885","mergeCommit":{"message":"[AI
Connector] Migrates AI inference Connector to use a shared components
from '@kbn/inference-endpoint-ui-common' (#204885)\n\n1. Migrated
stack-connector `.inference` to use share UI
components\r\nhttps://github.com//pull/203204\r\n2.
Extended package `@kbn/inference-endpoint-ui-common` to support
edit\r\nmode for the form of the connector, by adding the optional
property\r\n`isEdit` to `InferenceServiceFormFields` component\r\n3.
Resolves flaky timing out
test\r\nhttps://github.com//issues/205129\r\n\r\n---------\r\n\r\nCo-authored-by:
Samiul Monir <samiul.monir@elastic.co>\r\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"47b19ba29c707eabf6c2bc12e21b714aae91ebed"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/204885","number":204885,"mergeCommit":{"message":"[AI
Connector] Migrates AI inference Connector to use a shared components
from '@kbn/inference-endpoint-ui-common' (#204885)\n\n1. Migrated
stack-connector `.inference` to use share UI
components\r\nhttps://github.com//pull/203204\r\n2.
Extended package `@kbn/inference-endpoint-ui-common` to support
edit\r\nmode for the form of the connector, by adding the optional
property\r\n`isEdit` to `InferenceServiceFormFields` component\r\n3.
Resolves flaky timing out
test\r\nhttps://github.com//issues/205129\r\n\r\n---------\r\n\r\nCo-authored-by:
Samiul Monir <samiul.monir@elastic.co>\r\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"47b19ba29c707eabf6c2bc12e21b714aae91ebed"}},{"branch":"8.x","label":"v8.18.0","labelRegex":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->
viduni94 pushed a commit to viduni94/kibana that referenced this pull request Jan 23, 2025
@Samiul-TheSoccerFan @kibanamachine
@elasticmachine @viduni94
[Search] Add Inference endpoint Flyout in Inference Management UI (el…
0583f04 
…astic#203204)

## Summary

This PR includes
- Create a UI component package to share AI connector form between
multiple plugins
- Integrate the packaged components into the `Search Inference Endpoint`
plugin.



https://github.com/user-attachments/assets/2b447b44-3d1d-4422-b76d-8d8fd160b2bc


### Checklist

Check the PR satisfies following conditions. 

Reviewers should verify this PR satisfies this list as well.

- [X] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [X] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [X] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
viduni94 pushed a commit to viduni94/kibana that referenced this pull request Jan 23, 2025
@YulNaumenko @Samiul-TheSoccerFan
@kibanamachine @viduni94
[AI Connector] Migrates AI inference Connector to use a shared compon…
583279b 
…ents from '@kbn/inference-endpoint-ui-common' (elastic#204885)

1. Migrated stack-connector `.inference` to use share UI components
elastic#203204
2. Extended package `@kbn/inference-endpoint-ui-common` to support edit
mode for the form of the connector, by adding the optional property
`isEdit` to `InferenceServiceFormFields` component
3. Resolves flaky timing out test
elastic#205129

---------

Co-authored-by: Samiul Monir <samiul.monir@elastic.co>
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pgayvallet pgayvallet pgayvallet left review comments

@TattdCodeMonkey TattdCodeMonkey TattdCodeMonkey left review comments

@gsoldevila gsoldevila gsoldevila left review comments

@efegurkan efegurkan efegurkan approved these changes

@TinaHeiligers TinaHeiligers TinaHeiligers approved these changes

@YulNaumenko YulNaumenko YulNaumenko approved these changes

Assignees

No one assigned

Labels

backport:version Backport to applied version labels ci:project-deploy-elasticsearch Create an Elasticsearch Serverless project release_note:skip Skip the PR/issue when compiling release notes Team:Core Platform Core services: plugins, logging, config, saved objects, http, ES client, i18n, etc t// Team:ML Team label for ML (also use :ml) t// Team:Search v8.18.0 v9.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@Samiul-TheSoccerFan @elasticmachine @kibanamachine @efegurkan @pgayvallet @TattdCodeMonkey @TinaHeiligers @gsoldevila @YulNaumenko