[ResponseOps][Connectors] Optional field blocks editing of case Webhook connector#198314
Merged
georgianaonoleata1904 merged 17 commits intoelastic:mainfrom Nov 19, 2024
Merged
Conversation
Contributor
|
Pinging @elastic/response-ops (Team:ResponseOps) |
Contributor
|
I tested the PR and found a couple of bugs.
Screen.Recording.2024-11-07.at.11.56.20.mov
|
adcoelho
requested changes
Nov 7, 2024
| expect(await screen.findByTestId('webhookCreateCommentJson')).toBeInTheDocument(); | ||
| }); | ||
|
|
||
| it('Add comment to case section is rendered only when the toggle button is on', async () => { |
Contributor
There was a problem hiding this comment.
Maybe add a test that guarantees that webhookAddCommentToggle is active when those fields have data.
Contributor
Author
There was a problem hiding this comment.
done, thanks :)
x-pack/plugins/stack_connectors/public/connector_types/cases_webhook/validator.ts
Show resolved
Hide resolved
| ); | ||
| {isAddCommentToggled && ( | ||
| <> | ||
| <EuiSpacer size="s" /> |
Contributor
There was a problem hiding this comment.
This spacer felt too small imo.
Suggested change
| <EuiSpacer size="s" /> | |
| <EuiSpacer size="m" /> |
But let's see how things look like when you add the missing text I mentioned in the other comment
| <EuiSpacer size="m" /> | ||
| <EuiSwitch | ||
| label={i18n.STEP_4B} | ||
| showLabel={true} |
Contributor
There was a problem hiding this comment.
nit:
Suggested change
| showLabel={true} | |
| showLabel |
| showButtonTitle: true, | ||
| }} | ||
| export const UpdateStep: FunctionComponent<Props> = ({ display, readOnly }) => { | ||
| const [isAddCommentToggled, setIsAddCommentToggled] = useState(false); |
Contributor
There was a problem hiding this comment.
The default value here should depend on whether or not the form fields are populated(instead of being false)
Contributor
Author
There was a problem hiding this comment.
done, thanks :)
adcoelho
approved these changes
Nov 13, 2024
Member
|
@elasticmachine merge upstream |
Contributor
💚 Build Succeeded
Metrics [docs]Async chunks
History
|
Contributor
|
Starting backport for target branches: 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 19, 2024
…ok connector (elastic#198314) Closes elastic#191915 ## Summary When editing an existing Webhook - Case Management connector clicking Save will fail if the optional step 4 "Add a comment in case" is not populated - added extra checks for null, undefined or empty string: returns "undefined" immediately, skipping any further validation - this ensures that the "comment url" and "comment object" fields can remain empty without triggering a validation error (previously, if the fields were empty, the value passed was null). - the header of the add comment section was changed to a toggle element, when it's on, all the elements in the add comment section are visible https://github.com/user-attachments/assets/49839173-e99b-4ee8-be6d-b682ad0b8a80 --------- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> (cherry picked from commit d278387)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Nov 19, 2024
… Webhook connector (#198314) (#200724) # Backport This will backport the following commits from `main` to `8.x`: - [[ResponseOps][Connectors] Optional field blocks editing of case Webhook connector (#198314)](#198314) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Georgiana-Andreea Onoleață","email":"georgiana.onoleata@elastic.co"},"sourceCommit":{"committedDate":"2024-11-19T12:46:39Z","message":"[ResponseOps][Connectors] Optional field blocks editing of case Webhook connector (#198314)\n\nCloses https://github.com/elastic/kibana/issues/191915\r\n\r\n## Summary\r\n\r\nWhen editing an existing Webhook - Case Management connector clicking\r\nSave will fail if the optional step 4 \"Add a comment in case\" is not\r\npopulated\r\n- added extra checks for null, undefined or empty string: returns\r\n\"undefined\" immediately, skipping any further validation - this ensures\r\nthat the \"comment url\" and \"comment object\" fields can remain empty\r\nwithout triggering a validation error (previously, if the fields were\r\nempty, the value passed was null).\r\n- the header of the add comment section was changed to a toggle element,\r\nwhen it's on, all the elements in the add comment section are visible\r\n\r\n\r\nhttps://github.com/user-attachments/assets/49839173-e99b-4ee8-be6d-b682ad0b8a80\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"d27838795681817657508c78422732f0dbe8dd3a","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","Team:ResponseOps","v9.0.0","backport:prev-minor","v8.17.0"],"title":"[ResponseOps][Connectors] Optional field blocks editing of case Webhook connector","number":198314,"url":"https://github.com/elastic/kibana/pull/198314","mergeCommit":{"message":"[ResponseOps][Connectors] Optional field blocks editing of case Webhook connector (#198314)\n\nCloses https://github.com/elastic/kibana/issues/191915\r\n\r\n## Summary\r\n\r\nWhen editing an existing Webhook - Case Management connector clicking\r\nSave will fail if the optional step 4 \"Add a comment in case\" is not\r\npopulated\r\n- added extra checks for null, undefined or empty string: returns\r\n\"undefined\" immediately, skipping any further validation - this ensures\r\nthat the \"comment url\" and \"comment object\" fields can remain empty\r\nwithout triggering a validation error (previously, if the fields were\r\nempty, the value passed was null).\r\n- the header of the add comment section was changed to a toggle element,\r\nwhen it's on, all the elements in the add comment section are visible\r\n\r\n\r\nhttps://github.com/user-attachments/assets/49839173-e99b-4ee8-be6d-b682ad0b8a80\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"d27838795681817657508c78422732f0dbe8dd3a"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/198314","number":198314,"mergeCommit":{"message":"[ResponseOps][Connectors] Optional field blocks editing of case Webhook connector (#198314)\n\nCloses https://github.com/elastic/kibana/issues/191915\r\n\r\n## Summary\r\n\r\nWhen editing an existing Webhook - Case Management connector clicking\r\nSave will fail if the optional step 4 \"Add a comment in case\" is not\r\npopulated\r\n- added extra checks for null, undefined or empty string: returns\r\n\"undefined\" immediately, skipping any further validation - this ensures\r\nthat the \"comment url\" and \"comment object\" fields can remain empty\r\nwithout triggering a validation error (previously, if the fields were\r\nempty, the value passed was null).\r\n- the header of the add comment section was changed to a toggle element,\r\nwhen it's on, all the elements in the add comment section are visible\r\n\r\n\r\nhttps://github.com/user-attachments/assets/49839173-e99b-4ee8-be6d-b682ad0b8a80\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"d27838795681817657508c78422732f0dbe8dd3a"}},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Georgiana-Andreea Onoleață <georgiana.onoleata@elastic.co>
paulinashakirova
pushed a commit
to paulinashakirova/kibana
that referenced
this pull request
Nov 26, 2024
…ok connector (elastic#198314) Closes elastic#191915 ## Summary When editing an existing Webhook - Case Management connector clicking Save will fail if the optional step 4 "Add a comment in case" is not populated - added extra checks for null, undefined or empty string: returns "undefined" immediately, skipping any further validation - this ensures that the "comment url" and "comment object" fields can remain empty without triggering a validation error (previously, if the fields were empty, the value passed was null). - the header of the add comment section was changed to a toggle element, when it's on, all the elements in the add comment section are visible https://github.com/user-attachments/assets/49839173-e99b-4ee8-be6d-b682ad0b8a80 --------- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Dec 12, 2024
…ok connector (elastic#198314) Closes elastic#191915 ## Summary When editing an existing Webhook - Case Management connector clicking Save will fail if the optional step 4 "Add a comment in case" is not populated - added extra checks for null, undefined or empty string: returns "undefined" immediately, skipping any further validation - this ensures that the "comment url" and "comment object" fields can remain empty without triggering a validation error (previously, if the fields were empty, the value passed was null). - the header of the add comment section was changed to a toggle element, when it's on, all the elements in the add comment section are visible https://github.com/user-attachments/assets/49839173-e99b-4ee8-be6d-b682ad0b8a80 --------- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #191915
Summary
When editing an existing Webhook - Case Management connector clicking Save will fail if the optional step 4 "Add a comment in case" is not populated
Screen.Recording.2024-10-31.at.13.22.37.mov