Skip to content

[8.x] [ResponseOps][Connectors] Optional field blocks editing of case Webhook connector (#198314)#200724

Merged
kibanamachine merged 1 commit intoelastic:8.xfrom
kibanamachine:backport/8.x/pr-198314
Nov 19, 2024
Merged

[8.x] [ResponseOps][Connectors] Optional field blocks editing of case Webhook connector (#198314)#200724
kibanamachine merged 1 commit intoelastic:8.xfrom
kibanamachine:backport/8.x/pr-198314

Conversation

@kibanamachine
Copy link
Copy Markdown
Contributor

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

…ok connector (elastic#198314)

Closes elastic#191915

## Summary

When editing an existing Webhook - Case Management connector clicking
Save will fail if the optional step 4 "Add a comment in case" is not
populated
- added extra checks for null, undefined or empty string: returns
"undefined" immediately, skipping any further validation - this ensures
that the "comment url" and "comment object" fields can remain empty
without triggering a validation error (previously, if the fields were
empty, the value passed was null).
- the header of the add comment section was changed to a toggle element,
when it's on, all the elements in the add comment section are visible

https://github.com/user-attachments/assets/49839173-e99b-4ee8-be6d-b682ad0b8a80

---------

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
(cherry picked from commit d278387)
@kibanamachine kibanamachine merged commit b7dad96 into elastic:8.x Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants