[Synthetics] URL validation softens to allow vars usage !!#197797
Merged
shahzad31 merged 1 commit intoelastic:mainfrom Oct 25, 2024
Merged
[Synthetics] URL validation softens to allow vars usage !!#197797shahzad31 merged 1 commit intoelastic:mainfrom
shahzad31 merged 1 commit intoelastic:mainfrom
Conversation
Contributor
|
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
Contributor
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]
|
Contributor
|
Starting backport for target branches: 8.15, 8.16, 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 25, 2024
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 25, 2024
Contributor
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
Contributor
Author
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
shahzad31
added a commit
to shahzad31/kibana
that referenced
this pull request
Oct 25, 2024
…97797) ## Summary URL validation softens to allow vars usage !! For example ` should urls: "${url}" interpolate --params '{"url": "my-url"}'` (cherry picked from commit 3b05b6a) # Conflicts: # x-pack/plugins/observability_solution/synthetics/server/synthetics_service/project_monitor/normalizers/common_fields.ts
kibanamachine
added a commit
that referenced
this pull request
Oct 25, 2024
…7797) (#197839) # Backport This will backport the following commits from `main` to `8.x`: - [[Synthetics] URL validation softens to allow vars usage !! (#197797)](#197797) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Shahzad","email":"shahzad31comp@gmail.com"},"sourceCommit":{"committedDate":"2024-10-25T14:33:26Z","message":"[Synthetics] URL validation softens to allow vars usage !! (#197797)\n\n## Summary\r\n\r\nURL validation softens to allow vars usage !!\r\n\r\nFor example \r\n\r\n` should urls: \"${url}\" interpolate --params '{\"url\": \"my-url\"}'`","sha":"3b05b6a7a83df7ff8b929dbbb60c639cc11101d8","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-major","ci:project-deploy-observability","Team:obs-ux-management"],"title":"[Synthetics] URL validation softens to allow vars usage !!","number":197797,"url":"https://github.com/elastic/kibana/pull/197797","mergeCommit":{"message":"[Synthetics] URL validation softens to allow vars usage !! (#197797)\n\n## Summary\r\n\r\nURL validation softens to allow vars usage !!\r\n\r\nFor example \r\n\r\n` should urls: \"${url}\" interpolate --params '{\"url\": \"my-url\"}'`","sha":"3b05b6a7a83df7ff8b929dbbb60c639cc11101d8"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/197797","number":197797,"mergeCommit":{"message":"[Synthetics] URL validation softens to allow vars usage !! (#197797)\n\n## Summary\r\n\r\nURL validation softens to allow vars usage !!\r\n\r\nFor example \r\n\r\n` should urls: \"${url}\" interpolate --params '{\"url\": \"my-url\"}'`","sha":"3b05b6a7a83df7ff8b929dbbb60c639cc11101d8"}}]}] BACKPORT--> Co-authored-by: Shahzad <shahzad31comp@gmail.com>
shahzad31
added a commit
that referenced
this pull request
Oct 28, 2024
…97797) (#197841) # Backport This will backport the following commits from `main` to `8.15`: - [[Synthetics] URL validation softens to allow vars usage !! (#197797)](#197797) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Shahzad","email":"shahzad31comp@gmail.com"},"sourceCommit":{"committedDate":"2024-10-25T14:33:26Z","message":"[Synthetics] URL validation softens to allow vars usage !! (#197797)\n\n## Summary\r\n\r\nURL validation softens to allow vars usage !!\r\n\r\nFor example \r\n\r\n` should urls: \"${url}\" interpolate --params '{\"url\": \"my-url\"}'`","sha":"3b05b6a7a83df7ff8b929dbbb60c639cc11101d8","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-major","ci:project-deploy-observability","Team:obs-ux-management"],"number":197797,"url":"https://github.com/elastic/kibana/pull/197797","mergeCommit":{"message":"[Synthetics] URL validation softens to allow vars usage !! (#197797)\n\n## Summary\r\n\r\nURL validation softens to allow vars usage !!\r\n\r\nFor example \r\n\r\n` should urls: \"${url}\" interpolate --params '{\"url\": \"my-url\"}'`","sha":"3b05b6a7a83df7ff8b929dbbb60c639cc11101d8"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/197797","number":197797,"mergeCommit":{"message":"[Synthetics] URL validation softens to allow vars usage !! (#197797)\n\n## Summary\r\n\r\nURL validation softens to allow vars usage !!\r\n\r\nFor example \r\n\r\n` should urls: \"${url}\" interpolate --params '{\"url\": \"my-url\"}'`","sha":"3b05b6a7a83df7ff8b929dbbb60c639cc11101d8"}},{"url":"https://github.com/elastic/kibana/pull/197838","number":197838,"branch":"8.16","state":"OPEN"},{"url":"https://github.com/elastic/kibana/pull/197839","number":197839,"branch":"8.x","state":"OPEN"}]}] BACKPORT-->
Contributor
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
Contributor
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
3 similar comments
Contributor
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
Contributor
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
Contributor
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
kibanamachine
added a commit
that referenced
this pull request
Nov 5, 2024
…97797) (#197838) # Backport This will backport the following commits from `main` to `8.16`: - [[Synthetics] URL validation softens to allow vars usage !! (#197797)](#197797) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Shahzad","email":"shahzad31comp@gmail.com"},"sourceCommit":{"committedDate":"2024-10-25T14:33:26Z","message":"[Synthetics] URL validation softens to allow vars usage !! (#197797)\n\n## Summary\r\n\r\nURL validation softens to allow vars usage !!\r\n\r\nFor example \r\n\r\n` should urls: \"${url}\" interpolate --params '{\"url\": \"my-url\"}'`","sha":"3b05b6a7a83df7ff8b929dbbb60c639cc11101d8","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-major","ci:project-deploy-observability","Team:obs-ux-management"],"title":"[Synthetics] URL validation softens to allow vars usage !!","number":197797,"url":"https://github.com/elastic/kibana/pull/197797","mergeCommit":{"message":"[Synthetics] URL validation softens to allow vars usage !! (#197797)\n\n## Summary\r\n\r\nURL validation softens to allow vars usage !!\r\n\r\nFor example \r\n\r\n` should urls: \"${url}\" interpolate --params '{\"url\": \"my-url\"}'`","sha":"3b05b6a7a83df7ff8b929dbbb60c639cc11101d8"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/197797","number":197797,"mergeCommit":{"message":"[Synthetics] URL validation softens to allow vars usage !! (#197797)\n\n## Summary\r\n\r\nURL validation softens to allow vars usage !!\r\n\r\nFor example \r\n\r\n` should urls: \"${url}\" interpolate --params '{\"url\": \"my-url\"}'`","sha":"3b05b6a7a83df7ff8b929dbbb60c639cc11101d8"}}]}] BACKPORT--> Co-authored-by: Shahzad <shahzad31comp@gmail.com> Co-authored-by: Maryam Saeidi <maryam.saeidi@elastic.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
URL validation softens to allow vars usage !!
For example
should urls: "${url}" interpolate --params '{"url": "my-url"}'