Skip to content

[8.15] [Synthetics] URL validation softens to allow vars usage !! (#197797)#197841

Merged
shahzad31 merged 2 commits intoelastic:8.15from
shahzad31:backport/8.15/pr-197797
Oct 28, 2024
Merged

[8.15] [Synthetics] URL validation softens to allow vars usage !! (#197797)#197841
shahzad31 merged 2 commits intoelastic:8.15from
shahzad31:backport/8.15/pr-197797

Conversation

@shahzad31
Copy link
Copy Markdown
Contributor

Backport

This will backport the following commits from main to 8.15:

Questions ?

Please refer to the Backport tool documentation

…97797)

## Summary

URL validation softens to allow vars usage !!

For example

` should urls: "${url}" interpolate --params '{"url": "my-url"}'`

(cherry picked from commit 3b05b6a)

# Conflicts:
#	x-pack/plugins/observability_solution/synthetics/server/synthetics_service/project_monitor/normalizers/common_fields.ts
@shahzad31 shahzad31 added the backport This PR is a backport of another PR label Oct 25, 2024
@shahzad31 shahzad31 enabled auto-merge (squash) October 25, 2024 14:48
@botelastic botelastic bot added ci:project-deploy-observability Create an Observability project Team:obs-ux-infra_services - DEPRECATED DEPRECATED - Use Team:obs-presentation. labels Oct 25, 2024
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

@github-actions
Copy link
Copy Markdown
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with: - `/oblt-deploy` : Deploy a Kibana instance using the Observability test environments. - `run` `docs-build` : Re-trigger the docs validation. (use unformatted text in the comment!)

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Oct 28, 2024

💚 Build Succeeded

  • Buildkite Build
  • Commit: a112e8b
  • Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-197841-a112e8bb4b9f

Metrics [docs]

✅ unchanged

History

Copy link
Copy Markdown
Contributor

@dominiqueclarke dominiqueclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shahzad31 shahzad31 merged commit 60d1b09 into elastic:8.15 Oct 28, 2024
@shahzad31 shahzad31 deleted the backport/8.15/pr-197797 branch October 28, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR ci:project-deploy-observability Create an Observability project Team:obs-ux-infra_services - DEPRECATED DEPRECATED - Use Team:obs-presentation.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants