[APM] Update onboarding link to use locator with "application" as category parameter#197780
Merged
iblancof merged 5 commits intoelastic:mainfrom Oct 25, 2024
Conversation
Contributor
|
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
Contributor
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
jennypavlova
approved these changes
Oct 25, 2024
x-pack/plugins/observability_solution/apm/public/components/shared/add_data_buttons/buttons.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/observability_solution/apm/public/components/shared/add_data_buttons/buttons.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/observability_solution/apm/public/locator/onboarding_locator.ts
Show resolved
Hide resolved
Contributor
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Historycc @iblancof |
Contributor
|
Starting backport for target branches: 8.16, 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 25, 2024
…egory parameter (elastic#197780) ## Summary Closes elastic#197590. This PR addresses an issue with the onboarding link used by the `addApmData` constant, where the "Application" option fails to preselect. The issue is caused by the URL being incorrectly formed, with the category parameter set to `apm` instead of `application`. To resolve this, the PR introduces two main changes: - Update to use the correct locator - Modify the category parameter to use `application` instead of `apm` |Before|After| |-|-| ||| (cherry picked from commit 4798c59)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 25, 2024
…egory parameter (elastic#197780) ## Summary Closes elastic#197590. This PR addresses an issue with the onboarding link used by the `addApmData` constant, where the "Application" option fails to preselect. The issue is caused by the URL being incorrectly formed, with the category parameter set to `apm` instead of `application`. To resolve this, the PR introduces two main changes: - Update to use the correct locator - Modify the category parameter to use `application` instead of `apm` |Before|After| |-|-| ||| (cherry picked from commit 4798c59)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 25, 2024
…ion" as category parameter (#197780) (#197820) # Backport This will backport the following commits from `main` to `8.x`: - [[APM] Update onboarding link to use locator with "application" as category parameter (#197780)](#197780) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Irene Blanco","email":"irene.blanco@elastic.co"},"sourceCommit":{"committedDate":"2024-10-25T12:27:55Z","message":"[APM] Update onboarding link to use locator with \"application\" as category parameter (#197780)\n\n## Summary\r\n\r\nCloses https://github.com/elastic/kibana/issues/197590.\r\n\r\nThis PR addresses an issue with the onboarding link used by the\r\n`addApmData` constant, where the \"Application\" option fails to\r\npreselect. The issue is caused by the URL being incorrectly formed, with\r\nthe category parameter set to `apm` instead of `application`.\r\n\r\nTo resolve this, the PR introduces two main changes:\r\n- Update to use the correct locator\r\n- Modify the category parameter to use `application` instead of `apm`\r\n\r\n|Before|After|\r\n|-|-|\r\n\r\n|||","sha":"4798c59158f2bd7dc09bfd07c8ab69bcfb23c0b8","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-infra_services","v8.16.0","v8.17.0"],"title":"[APM] Update onboarding link to use locator with \"application\" as category parameter","number":197780,"url":"https://github.com/elastic/kibana/pull/197780","mergeCommit":{"message":"[APM] Update onboarding link to use locator with \"application\" as category parameter (#197780)\n\n## Summary\r\n\r\nCloses https://github.com/elastic/kibana/issues/197590.\r\n\r\nThis PR addresses an issue with the onboarding link used by the\r\n`addApmData` constant, where the \"Application\" option fails to\r\npreselect. The issue is caused by the URL being incorrectly formed, with\r\nthe category parameter set to `apm` instead of `application`.\r\n\r\nTo resolve this, the PR introduces two main changes:\r\n- Update to use the correct locator\r\n- Modify the category parameter to use `application` instead of `apm`\r\n\r\n|Before|After|\r\n|-|-|\r\n\r\n|||","sha":"4798c59158f2bd7dc09bfd07c8ab69bcfb23c0b8"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/197780","number":197780,"mergeCommit":{"message":"[APM] Update onboarding link to use locator with \"application\" as category parameter (#197780)\n\n## Summary\r\n\r\nCloses https://github.com/elastic/kibana/issues/197590.\r\n\r\nThis PR addresses an issue with the onboarding link used by the\r\n`addApmData` constant, where the \"Application\" option fails to\r\npreselect. The issue is caused by the URL being incorrectly formed, with\r\nthe category parameter set to `apm` instead of `application`.\r\n\r\nTo resolve this, the PR introduces two main changes:\r\n- Update to use the correct locator\r\n- Modify the category parameter to use `application` instead of `apm`\r\n\r\n|Before|After|\r\n|-|-|\r\n\r\n|||","sha":"4798c59158f2bd7dc09bfd07c8ab69bcfb23c0b8"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Irene Blanco <irene.blanco@elastic.co>
kibanamachine
added a commit
that referenced
this pull request
Oct 25, 2024
…tion" as category parameter (#197780) (#197819) # Backport This will backport the following commits from `main` to `8.16`: - [[APM] Update onboarding link to use locator with "application" as category parameter (#197780)](#197780) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Irene Blanco","email":"irene.blanco@elastic.co"},"sourceCommit":{"committedDate":"2024-10-25T12:27:55Z","message":"[APM] Update onboarding link to use locator with \"application\" as category parameter (#197780)\n\n## Summary\r\n\r\nCloses https://github.com/elastic/kibana/issues/197590.\r\n\r\nThis PR addresses an issue with the onboarding link used by the\r\n`addApmData` constant, where the \"Application\" option fails to\r\npreselect. The issue is caused by the URL being incorrectly formed, with\r\nthe category parameter set to `apm` instead of `application`.\r\n\r\nTo resolve this, the PR introduces two main changes:\r\n- Update to use the correct locator\r\n- Modify the category parameter to use `application` instead of `apm`\r\n\r\n|Before|After|\r\n|-|-|\r\n\r\n|||","sha":"4798c59158f2bd7dc09bfd07c8ab69bcfb23c0b8","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-infra_services","v8.16.0","v8.17.0"],"title":"[APM] Update onboarding link to use locator with \"application\" as category parameter","number":197780,"url":"https://github.com/elastic/kibana/pull/197780","mergeCommit":{"message":"[APM] Update onboarding link to use locator with \"application\" as category parameter (#197780)\n\n## Summary\r\n\r\nCloses https://github.com/elastic/kibana/issues/197590.\r\n\r\nThis PR addresses an issue with the onboarding link used by the\r\n`addApmData` constant, where the \"Application\" option fails to\r\npreselect. The issue is caused by the URL being incorrectly formed, with\r\nthe category parameter set to `apm` instead of `application`.\r\n\r\nTo resolve this, the PR introduces two main changes:\r\n- Update to use the correct locator\r\n- Modify the category parameter to use `application` instead of `apm`\r\n\r\n|Before|After|\r\n|-|-|\r\n\r\n|||","sha":"4798c59158f2bd7dc09bfd07c8ab69bcfb23c0b8"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/197780","number":197780,"mergeCommit":{"message":"[APM] Update onboarding link to use locator with \"application\" as category parameter (#197780)\n\n## Summary\r\n\r\nCloses https://github.com/elastic/kibana/issues/197590.\r\n\r\nThis PR addresses an issue with the onboarding link used by the\r\n`addApmData` constant, where the \"Application\" option fails to\r\npreselect. The issue is caused by the URL being incorrectly formed, with\r\nthe category parameter set to `apm` instead of `application`.\r\n\r\nTo resolve this, the PR introduces two main changes:\r\n- Update to use the correct locator\r\n- Modify the category parameter to use `application` instead of `apm`\r\n\r\n|Before|After|\r\n|-|-|\r\n\r\n|||","sha":"4798c59158f2bd7dc09bfd07c8ab69bcfb23c0b8"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Irene Blanco <irene.blanco@elastic.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #197590.
This PR addresses an issue with the onboarding link used by the
addApmDataconstant, where the "Application" option fails to preselect. The issue is caused by the URL being incorrectly formed, with the category parameter set toapminstead ofapplication.To resolve this, the PR introduces two main changes:
applicationinstead ofapm