Skip to content

[8.16] [APM] Update onboarding link to use locator with "application" as category parameter (#197780)#197819

Merged
kibanamachine merged 2 commits intoelastic:8.16from
kibanamachine:backport/8.16/pr-197780
Oct 25, 2024
Merged

[8.16] [APM] Update onboarding link to use locator with "application" as category parameter (#197780)#197819
kibanamachine merged 2 commits intoelastic:8.16from
kibanamachine:backport/8.16/pr-197780

Conversation

@kibanamachine
Copy link
Copy Markdown
Contributor

@kibanamachine kibanamachine commented Oct 25, 2024

Backport

This will backport the following commits from main to 8.16:

Questions ?

Please refer to the Backport tool documentation

@iblancof
[APM] Update onboarding link to use locator with "application" as cat…
5338bdd 
…egory parameter (elastic#197780)

## Summary

Closes elastic#197590.

This PR addresses an issue with the onboarding link used by the
`addApmData` constant, where the "Application" option fails to
preselect. The issue is caused by the URL being incorrectly formed, with
the category parameter set to `apm` instead of `application`.

To resolve this, the PR introduces two main changes:
- Update to use the correct locator
- Modify the category parameter to use `application` instead of `apm`

|Before|After|
|-|-|

|![before](https://github.com/user-attachments/assets/650066b8-85a8-4ff4-a7eb-fef46708ea9d)|![after](https://github.com/user-attachments/assets/508bb258-e2c2-4057-9242-653864548e4a)|

(cherry picked from commit 4798c59)
@kibanamachine kibanamachine added the backport This PR is a backport of another PR label Oct 25, 2024
@kibanamachine kibanamachine enabled auto-merge (squash) October 25, 2024 12:32
@botelastic botelastic bot added ci:project-deploy-observability Create an Observability project Team:obs-ux-infra_services - DEPRECATED DEPRECATED - Use Team:obs-presentation. labels Oct 25, 2024
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Oct 25, 2024

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

@kibanamachine kibanamachine mentioned this pull request Oct 25, 2024
Merged
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 25, 2024

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Oct 25, 2024 •
edited
Loading

💚 Build Succeeded

  • Buildkite Build
  • Commit: 3e6ca6b
  • Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-197819-3e6ca6b4f32f

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
apm 1886 1887 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 3.5MB 3.5MB +202.0B

History

cc @iblancof

@kibanamachine kibanamachine merged commit 724be35 into elastic:8.16 Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees

@iblancof iblancof

Labels

backport This PR is a backport of another PR ci:project-deploy-observability Create an Observability project Team:obs-ux-infra_services - DEPRECATED DEPRECATED - Use Team:obs-presentation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kibanamachine @elasticmachine @iblancof