[Security Assistant] Revert open AI Assistant settings in new tab#197725
Merged
stephmilovic merged 1 commit intoelastic:mainfrom Oct 24, 2024
Merged
[Security Assistant] Revert open AI Assistant settings in new tab#197725stephmilovic merged 1 commit intoelastic:mainfrom
stephmilovic merged 1 commit intoelastic:mainfrom
Conversation
Contributor
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
patrykkopycinski
approved these changes
Oct 24, 2024
Contributor
💚 Build Succeeded
Metrics [docs]Async chunks
|
Contributor
|
Starting backport for target branches: 8.x |
Contributor
|
Starting backport for target branches: 8.16, 8.x |
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 24, 2024
…astic#197725) (cherry picked from commit d2aa007)
Contributor
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 25, 2024
…ab (#197725) (#197746) # Backport This will backport the following commits from `main` to `8.x`: - [[Security Assistant] Revert open AI Assistant settings in new tab (#197725)](#197725) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Steph Milovic","email":"stephanie.milovic@elastic.co"},"sourceCommit":{"committedDate":"2024-10-24T22:44:45Z","message":"[Security Assistant] Revert open AI Assistant settings in new tab (#197725)","sha":"d2aa00708309fdf85deb03870f65960ec78161cf","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team: SecuritySolution","backport:prev-minor","Team:Security Generative AI"],"title":"[Security Assistant] Revert open AI Assistant settings in new tab","number":197725,"url":"https://github.com/elastic/kibana/pull/197725","mergeCommit":{"message":"[Security Assistant] Revert open AI Assistant settings in new tab (#197725)","sha":"d2aa00708309fdf85deb03870f65960ec78161cf"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/197725","number":197725,"mergeCommit":{"message":"[Security Assistant] Revert open AI Assistant settings in new tab (#197725)","sha":"d2aa00708309fdf85deb03870f65960ec78161cf"}}]}] BACKPORT--> Co-authored-by: Steph Milovic <stephanie.milovic@elastic.co>
Contributor
Author
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
stephmilovic
added a commit
to stephmilovic/kibana
that referenced
this pull request
Oct 25, 2024
…astic#197725) (cherry picked from commit d2aa007)
stephmilovic
added a commit
that referenced
this pull request
Oct 25, 2024
…tab (#197725) (#197857) # Backport This will backport the following commits from `main` to `8.16`: - [[Security Assistant] Revert open AI Assistant settings in new tab (#197725)](#197725) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Steph Milovic","email":"stephanie.milovic@elastic.co"},"sourceCommit":{"committedDate":"2024-10-24T22:44:45Z","message":"[Security Assistant] Revert open AI Assistant settings in new tab (#197725)","sha":"d2aa00708309fdf85deb03870f65960ec78161cf","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team: SecuritySolution","Team:Security Generative AI","v8.16.0","backport:version","v8.17.0"],"number":197725,"url":"https://github.com/elastic/kibana/pull/197725","mergeCommit":{"message":"[Security Assistant] Revert open AI Assistant settings in new tab (#197725)","sha":"d2aa00708309fdf85deb03870f65960ec78161cf"}},"sourceBranch":"main","suggestedTargetBranches":["8.16"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/197725","number":197725,"mergeCommit":{"message":"[Security Assistant] Revert open AI Assistant settings in new tab (#197725)","sha":"d2aa00708309fdf85deb03870f65960ec78161cf"}},{"branch":"8.16","label":"v8.16.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.17.0","labelRegex":"^v8.17.0$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/197746","number":197746,"state":"MERGED","mergeCommit":{"sha":"67abfdc08366f041b0de3542deb5ac80fd2eed29","message":"[8.x] [Security Assistant] Revert open AI Assistant settings in new tab (#197725) (#197746)\n\n# Backport\n\nThis will backport the following commits from `main` to `8.x`:\n- [[Security Assistant] Revert open AI Assistant settings in new tab\n(#197725)](https://github.com/elastic/kibana/pull/197725)\n\n<!--- Backport version: 9.4.3 -->\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sqren/backport)\n\n<!--BACKPORT [{\"author\":{\"name\":\"Steph\nMilovic\",\"email\":\"stephanie.milovic@elastic.co\"},\"sourceCommit\":{\"committedDate\":\"2024-10-24T22:44:45Z\",\"message\":\"[Security\nAssistant] Revert open AI Assistant settings in new tab\n(#197725)\",\"sha\":\"d2aa00708309fdf85deb03870f65960ec78161cf\",\"branchLabelMapping\":{\"^v9.0.0$\":\"main\",\"^v8.17.0$\":\"8.x\",\"^v(\\\\d+).(\\\\d+).\\\\d+$\":\"$1.$2\"}},\"sourcePullRequest\":{\"labels\":[\"release_note:skip\",\"v9.0.0\",\"Team:\nSecuritySolution\",\"backport:prev-minor\",\"Team:Security Generative\nAI\"],\"title\":\"[Security Assistant] Revert open AI Assistant settings in\nnew\ntab\",\"number\":197725,\"url\":\"https://github.com/elastic/kibana/pull/197725\",\"mergeCommit\":{\"message\":\"[Security\nAssistant] Revert open AI Assistant settings in new tab\n(#197725)\",\"sha\":\"d2aa00708309fdf85deb03870f65960ec78161cf\"}},\"sourceBranch\":\"main\",\"suggestedTargetBranches\":[],\"targetPullRequestStates\":[{\"branch\":\"main\",\"label\":\"v9.0.0\",\"branchLabelMappingKey\":\"^v9.0.0$\",\"isSourceBranch\":true,\"state\":\"MERGED\",\"url\":\"https://github.com/elastic/kibana/pull/197725\",\"number\":197725,\"mergeCommit\":{\"message\":\"[Security\nAssistant] Revert open AI Assistant settings in new tab\n(#197725)\",\"sha\":\"d2aa00708309fdf85deb03870f65960ec78161cf\"}}]}]\nBACKPORT-->\n\nCo-authored-by: Steph Milovic <stephanie.milovic@elastic.co>"}}]}] BACKPORT-->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Revert changes made in this PR #197323 to open assistant settings in new tab from context menu. This had unintended consequences, so we are reverting back to opening the assistant settings in the same tab. Below is a recording of the behavior we are moving forward with:
a.mov