[Security Assistant] Fix Security Assistant settings link behavior and adjust initial settings tab#197323
Merged
stephmilovic merged 5 commits intoelastic:mainfrom Oct 23, 2024
Conversation
Contributor
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
andrew-goldstein
approved these changes
Oct 22, 2024
Contributor
andrew-goldstein
left a comment
There was a problem hiding this comment.
Thanks @stephmilovic for these updates!
✅ Desk tested locally
LGTM 🚀
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
|
Starting backport for target branches: 8.x |
Contributor
💚 Build Succeeded
Metrics [docs]Async chunks
History
|
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 23, 2024
…d adjust initial settings tab (elastic#197323) (cherry picked from commit a6dc47d)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 23, 2024
…ior and adjust initial settings tab (#197323) (#197493) # Backport This will backport the following commits from `main` to `8.x`: - [[Security Assistant] Fix Security Assistant settings link behavior and adjust initial settings tab (#197323)](#197323) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Steph Milovic","email":"stephanie.milovic@elastic.co"},"sourceCommit":{"committedDate":"2024-10-23T16:06:47Z","message":"[Security Assistant] Fix Security Assistant settings link behavior and adjust initial settings tab (#197323)","sha":"a6dc47ddeb15d6c7b91e1abaaf83fba3eee2fef2","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team: SecuritySolution","backport:prev-minor","Team:Security Generative AI"],"title":"[Security Assistant] Fix Security Assistant settings link behavior and adjust initial settings tab","number":197323,"url":"https://github.com/elastic/kibana/pull/197323","mergeCommit":{"message":"[Security Assistant] Fix Security Assistant settings link behavior and adjust initial settings tab (#197323)","sha":"a6dc47ddeb15d6c7b91e1abaaf83fba3eee2fef2"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/197323","number":197323,"mergeCommit":{"message":"[Security Assistant] Fix Security Assistant settings link behavior and adjust initial settings tab (#197323)","sha":"a6dc47ddeb15d6c7b91e1abaaf83fba3eee2fef2"}}]}] BACKPORT--> Co-authored-by: Steph Milovic <stephanie.milovic@elastic.co>
Contributor
|
Starting backport for target branches: 8.16, 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 24, 2024
…d adjust initial settings tab (elastic#197323) (cherry picked from commit a6dc47d)
Contributor
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 25, 2024
…vior and adjust initial settings tab (#197323) (#197748) # Backport This will backport the following commits from `main` to `8.16`: - [[Security Assistant] Fix Security Assistant settings link behavior and adjust initial settings tab (#197323)](#197323) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Steph Milovic","email":"stephanie.milovic@elastic.co"},"sourceCommit":{"committedDate":"2024-10-23T16:06:47Z","message":"[Security Assistant] Fix Security Assistant settings link behavior and adjust initial settings tab (#197323)","sha":"a6dc47ddeb15d6c7b91e1abaaf83fba3eee2fef2","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team: SecuritySolution","Team:Security Generative AI","v8.16.0","backport:version","v8.17.0"],"title":"[Security Assistant] Fix Security Assistant settings link behavior and adjust initial settings tab","number":197323,"url":"https://github.com/elastic/kibana/pull/197323","mergeCommit":{"message":"[Security Assistant] Fix Security Assistant settings link behavior and adjust initial settings tab (#197323)","sha":"a6dc47ddeb15d6c7b91e1abaaf83fba3eee2fef2"}},"sourceBranch":"main","suggestedTargetBranches":["8.16"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/197323","number":197323,"mergeCommit":{"message":"[Security Assistant] Fix Security Assistant settings link behavior and adjust initial settings tab (#197323)","sha":"a6dc47ddeb15d6c7b91e1abaaf83fba3eee2fef2"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/197493","number":197493,"state":"MERGED","mergeCommit":{"sha":"942827df09a03a7356f66e98753a3e356e644371","message":"[8.x] [Security Assistant] Fix Security Assistant settings link behavior and adjust initial settings tab (#197323) (#197493)\n\n# Backport\n\nThis will backport the following commits from `main` to `8.x`:\n- [[Security Assistant] Fix Security Assistant settings link behavior\nand adjust initial settings tab\n(#197323)](https://github.com/elastic/kibana/pull/197323)\n\n<!--- Backport version: 9.4.3 -->\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sqren/backport)\n\n<!--BACKPORT [{\"author\":{\"name\":\"Steph\nMilovic\",\"email\":\"stephanie.milovic@elastic.co\"},\"sourceCommit\":{\"committedDate\":\"2024-10-23T16:06:47Z\",\"message\":\"[Security\nAssistant] Fix Security Assistant settings link behavior and adjust\ninitial settings tab\n(#197323)\",\"sha\":\"a6dc47ddeb15d6c7b91e1abaaf83fba3eee2fef2\",\"branchLabelMapping\":{\"^v9.0.0$\":\"main\",\"^v8.17.0$\":\"8.x\",\"^v(\\\\d+).(\\\\d+).\\\\d+$\":\"$1.$2\"}},\"sourcePullRequest\":{\"labels\":[\"release_note:skip\",\"v9.0.0\",\"Team:\nSecuritySolution\",\"backport:prev-minor\",\"Team:Security Generative\nAI\"],\"title\":\"[Security Assistant] Fix Security Assistant settings link\nbehavior and adjust initial settings\ntab\",\"number\":197323,\"url\":\"https://github.com/elastic/kibana/pull/197323\",\"mergeCommit\":{\"message\":\"[Security\nAssistant] Fix Security Assistant settings link behavior and adjust\ninitial settings tab\n(#197323)\",\"sha\":\"a6dc47ddeb15d6c7b91e1abaaf83fba3eee2fef2\"}},\"sourceBranch\":\"main\",\"suggestedTargetBranches\":[],\"targetPullRequestStates\":[{\"branch\":\"main\",\"label\":\"v9.0.0\",\"branchLabelMappingKey\":\"^v9.0.0$\",\"isSourceBranch\":true,\"state\":\"MERGED\",\"url\":\"https://github.com/elastic/kibana/pull/197323\",\"number\":197323,\"mergeCommit\":{\"message\":\"[Security\nAssistant] Fix Security Assistant settings link behavior and adjust\ninitial settings tab\n(#197323)\",\"sha\":\"a6dc47ddeb15d6c7b91e1abaaf83fba3eee2fef2\"}}]}]\nBACKPORT-->\n\nCo-authored-by: Steph Milovic <stephanie.milovic@elastic.co>"}}]}] BACKPORT--> Co-authored-by: Steph Milovic <stephanie.milovic@elastic.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR makes 3 design changes:
Updates the Security AI Assistant context menu items that open links to the assistant settings (AI Assistant settings and Knowledge Base) to open them in a new tab, and adds the
popouticon to indicate this.Note: The
popouticon is a short term solution as @bojanasan is going to create another popout type icon for Eui to indicate Kibana link, but that will take a bit. Tracked here: https://github.com/elastic/security-team/issues/10286Changes the first and initially selected tab of Security AI Assistant settings from
ConnectorstoConversations, as theConnectorstab is a redirect to Stack Management > ConnectorsChanges the capitalization of the streaming heading from STREAMING to Streaming. This seems to be inadvertently changed previously.