[OAS] Removing staging files#197455
Merged
jloleysens merged 4 commits intoelastic:mainfrom Oct 24, 2024
Merged
Conversation
Contributor
|
Pinging @elastic/kibana-core (Team:Core) |
maximpn
approved these changes
Oct 24, 2024
.buildkite/scripts/steps/checks.sh
Outdated
| @@ -14,4 +14,3 @@ fi | |||
| .buildkite/scripts/steps/code_generation/security_solution_codegen.sh | |||
| .buildkite/scripts/steps/openapi_bundling/security_solution_openapi_bundling.sh | |||
Contributor
There was a problem hiding this comment.
nit: It looks like .buildkite/scripts/steps/openapi_bundling/security_solution_openapi_bundling.sh script could be moved to .buildkite/scripts/steps/checks/capture_oas_snapshot.sh since it has a similar purpose but limited to Security Solution only.
Contributor
💚 Build Succeeded
Metrics [docs]
History
cc @jloleysens |
Contributor
|
Starting backport for target branches: 8.x |
Contributor
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
Contributor
Author
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Oct 25, 2024
## Summary Removing staging files for now. We can always revert this if it turns out we need them. ## Reviewers * I might be missing something in removing these, but right now I think they are making commit noise and not really serving a purpose * I moved the `final_merge` step to after the OAS snapshot capture (cherry picked from commit 77ce0fc) # Conflicts: # .buildkite/scripts/steps/capture_oas_snapshot.sh # oas_docs/output/kibana.serverless.staging.yaml # oas_docs/output/kibana.staging.yaml # oas_docs/scripts/merge_ess_oas_staging.js # oas_docs/scripts/merge_serverless_oas_staging.js
jloleysens
added a commit
that referenced
this pull request
Oct 28, 2024
# Backport This will backport the following commits from `main` to `8.x`: - [[OAS] Removing staging files (#197455)](#197455) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Jean-Louis Leysens","email":"jeanlouis.leysens@elastic.co"},"sourceCommit":{"committedDate":"2024-10-24T14:52:13Z","message":"[OAS] Removing staging files (#197455)\n\n## Summary\r\n\r\nRemoving staging files for now. We can always revert this if it turns\r\nout we need them.\r\n\r\n## Reviewers\r\n\r\n* I might be missing something in removing these, but right now I think\r\nthey are making commit noise and not really serving a purpose\r\n* I moved the `final_merge` step to after the OAS snapshot capture","sha":"77ce0fcbcf18805d2ae1ac2d21a449c03deec022","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Core","release_note:skip","v9.0.0","Feature:OAS","backport:version","v8.17.0"],"number":197455,"url":"https://github.com/elastic/kibana/pull/197455","mergeCommit":{"message":"[OAS] Removing staging files (#197455)\n\n## Summary\r\n\r\nRemoving staging files for now. We can always revert this if it turns\r\nout we need them.\r\n\r\n## Reviewers\r\n\r\n* I might be missing something in removing these, but right now I think\r\nthey are making commit noise and not really serving a purpose\r\n* I moved the `final_merge` step to after the OAS snapshot capture","sha":"77ce0fcbcf18805d2ae1ac2d21a449c03deec022"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/197455","number":197455,"mergeCommit":{"message":"[OAS] Removing staging files (#197455)\n\n## Summary\r\n\r\nRemoving staging files for now. We can always revert this if it turns\r\nout we need them.\r\n\r\n## Reviewers\r\n\r\n* I might be missing something in removing these, but right now I think\r\nthey are making commit noise and not really serving a purpose\r\n* I moved the `final_merge` step to after the OAS snapshot capture","sha":"77ce0fcbcf18805d2ae1ac2d21a449c03deec022"}},{"branch":"8.x","label":"v8.17.0","labelRegex":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT-->
jloleysens
pushed a commit
that referenced
this pull request
Nov 1, 2024
) ## Summary Relates to #197455 Some of the staging and serverless OpenAPI files persist in 8.x and earlier branches, so this PR removes them to hopefully reduce merge conflicts.
lcawl
pushed a commit
to lcawl/kibana
that referenced
this pull request
Nov 8, 2024
Removing staging files for now. We can always revert this if it turns out we need them. * I might be missing something in removing these, but right now I think they are making commit noise and not really serving a purpose * I moved the `final_merge` step to after the OAS snapshot capture (cherry picked from commit 77ce0fc)
lcawl
added a commit
that referenced
this pull request
Nov 9, 2024
# Backport This will backport the following commits from `main` to `8.16`: - [OAS] Removing staging files (#197455) (77ce0fc) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Jean-Louis Leysens","email":"jeanlouis.leysens@elastic.co"},"sourceCommit":{"committedDate":"2024-10-24T14:52:13Z","message":"[OAS] Removing staging files (#197455)\n\n## Summary\r\n\r\nRemoving staging files for now. We can always revert this if it turns\r\nout we need them.\r\n\r\n## Reviewers\r\n\r\n* I might be missing something in removing these, but right now I think\r\nthey are making commit noise and not really serving a purpose\r\n* I moved the `final_merge` step to after the OAS snapshot capture","sha":"77ce0fcbcf18805d2ae1ac2d21a449c03deec022"},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[]}] BACKPORT--> Co-authored-by: Jean-Louis Leysens <jeanlouis.leysens@elastic.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removing staging files for now. We can always revert this if it turns out we need them.
Reviewers
final_mergestep to after the OAS snapshot capture