[Side navigation] bring back getIsActive to o11y solution navigation#196057
Merged
mgiota merged 1 commit intoelastic:mainfrom Oct 14, 2024
Merged
[Side navigation] bring back getIsActive to o11y solution navigation#196057mgiota merged 1 commit intoelastic:mainfrom
mgiota merged 1 commit intoelastic:mainfrom
Conversation
Contributor
|
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
shahzad31
approved these changes
Oct 14, 2024
maryam-saeidi
approved these changes
Oct 14, 2024
Contributor
|
FYI: the |
Contributor
|
Starting backport for target branches: 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 14, 2024
…lastic#196057) ## Summary I realized that as part of this [PR](https://github.com/elastic/kibana/pull/192805/files#diff-8f26b8327cc9fc31bef2b22bb53b82256edc9cf05cfc9c766d746a7aa4532437L144), `getIsActive` method was accidentally removed from `Applications` and `Infrastructure` menus. This PR brings `getIsActive` back. I didn't find any bug with the absence of `getIsActive`. Purpose of this PR is to not remove something that was there before. (cherry picked from commit 6aa1bc6)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 14, 2024
…ation (#196057) (#196104) # Backport This will backport the following commits from `main` to `8.x`: - [[Side navigation] bring back getIsActive to o11y solution navigation (#196057)](#196057) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Panagiota Mitsopoulou","email":"panagiota.mitsopoulou@elastic.co"},"sourceCommit":{"committedDate":"2024-10-14T10:50:33Z","message":"[Side navigation] bring back getIsActive to o11y solution navigation (#196057)\n\n## Summary\r\n\r\nI realized that as part of this\r\n[PR](https://github.com/elastic/kibana/pull/192805/files#diff-8f26b8327cc9fc31bef2b22bb53b82256edc9cf05cfc9c766d746a7aa4532437L144),\r\n`getIsActive` method was accidentally removed from `Applications` and\r\n`Infrastructure` menus. This PR brings `getIsActive` back. I didn't find\r\nany bug with the absence of `getIsActive`. Purpose of this PR is to not\r\nremove something that was there before.","sha":"6aa1bc6fd9aa05cec1af90b7b1dcc191141cc183","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-management","v8.16.0"],"title":"[Side navigation] bring back getIsActive to o11y solution navigation","number":196057,"url":"https://github.com/elastic/kibana/pull/196057","mergeCommit":{"message":"[Side navigation] bring back getIsActive to o11y solution navigation (#196057)\n\n## Summary\r\n\r\nI realized that as part of this\r\n[PR](https://github.com/elastic/kibana/pull/192805/files#diff-8f26b8327cc9fc31bef2b22bb53b82256edc9cf05cfc9c766d746a7aa4532437L144),\r\n`getIsActive` method was accidentally removed from `Applications` and\r\n`Infrastructure` menus. This PR brings `getIsActive` back. I didn't find\r\nany bug with the absence of `getIsActive`. Purpose of this PR is to not\r\nremove something that was there before.","sha":"6aa1bc6fd9aa05cec1af90b7b1dcc191141cc183"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196057","number":196057,"mergeCommit":{"message":"[Side navigation] bring back getIsActive to o11y solution navigation (#196057)\n\n## Summary\r\n\r\nI realized that as part of this\r\n[PR](https://github.com/elastic/kibana/pull/192805/files#diff-8f26b8327cc9fc31bef2b22bb53b82256edc9cf05cfc9c766d746a7aa4532437L144),\r\n`getIsActive` method was accidentally removed from `Applications` and\r\n`Infrastructure` menus. This PR brings `getIsActive` back. I didn't find\r\nany bug with the absence of `getIsActive`. Purpose of this PR is to not\r\nremove something that was there before.","sha":"6aa1bc6fd9aa05cec1af90b7b1dcc191141cc183"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Panagiota Mitsopoulou <panagiota.mitsopoulou@elastic.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I realized that as part of this PR,
getIsActivemethod was accidentally removed fromApplicationsandInfrastructuremenus. This PR bringsgetIsActiveback. I didn't find any bug with the absence ofgetIsActive. Purpose of this PR is to not remove something that was there before.