Skip to content

[8.x] [Side navigation] bring back getIsActive to o11y solution navigation (#196057)#196104

Merged
kibanamachine merged 1 commit intoelastic:8.xfrom
kibanamachine:backport/8.x/pr-196057
Oct 14, 2024
Merged

[8.x] [Side navigation] bring back getIsActive to o11y solution navigation (#196057)#196104
kibanamachine merged 1 commit intoelastic:8.xfrom
kibanamachine:backport/8.x/pr-196057

Conversation

@kibanamachine
Copy link
Copy Markdown
Contributor

@kibanamachine kibanamachine commented Oct 14, 2024

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

@mgiota
[Side navigation] bring back getIsActive to o11y solution navigation (e…
486e991 
…lastic#196057)

## Summary

I realized that as part of this
[PR](https://github.com/elastic/kibana/pull/192805/files#diff-8f26b8327cc9fc31bef2b22bb53b82256edc9cf05cfc9c766d746a7aa4532437L144),
`getIsActive` method was accidentally removed from `Applications` and
`Infrastructure` menus. This PR brings `getIsActive` back. I didn't find
any bug with the absence of `getIsActive`. Purpose of this PR is to not
remove something that was there before.

(cherry picked from commit 6aa1bc6)
@kibanamachine kibanamachine added the backport This PR is a backport of another PR label Oct 14, 2024
@kibanamachine kibanamachine enabled auto-merge (squash) October 14, 2024 10:55
@botelastic botelastic bot added ci:project-deploy-observability Create an Observability project Team:actionable-obs Formerly "obs-ux-management", responsible for SLO, o11y alerting, significant events, & synthetics. labels Oct 14, 2024
@kibanamachine kibanamachine mentioned this pull request Oct 14, 2024
Merged
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Oct 14, 2024

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

@kibanamachine kibanamachine merged commit 9b2ffa7 into elastic:8.x Oct 14, 2024
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Oct 14, 2024

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
observability 467.5KB 468.0KB +418.0B

cc @mgiota

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees

@mgiota mgiota

Labels

backport This PR is a backport of another PR ci:project-deploy-observability Create an Observability project Team:actionable-obs Formerly "obs-ux-management", responsible for SLO, o11y alerting, significant events, & synthetics.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kibanamachine @elasticmachine @mgiota