Remove Sass @euiPanel mixin usage#194646
Merged
cee-chen merged 2 commits intoelastic:mainfrom Oct 2, 2024
Merged
Conversation
…h CSS output - the mixin mostly adds modifier classes, none of which are being used here 🤷
- the mixin mostly adds modifier classes, none of which are being used - the parents of these elements aren't flex, so adding flex-grow: 1 does nothing
💚 Build Succeeded
Metrics [docs]Async chunks
Page load bundle
To update your PR or re-run it, just comment with: |
Contributor
|
Pinging @elastic/eui-team (EUI) |
1 task
MichaelMarcialis
approved these changes
Oct 2, 2024
Contributor
|
Starting backport for target branches: 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 2, 2024
## Summary This PR is part of EUI's ongoing Emotion migration. We are actively deprecating/removing Sass mixins and variables that are component-specific. In this case, the `@mixin euiPanel` **only** sets `flex-grow: 1;` as its default CSS and creates a bunch of modifier classes, none of which were being used in Kibana - hence various removals (see git commits for more specifics). ### QA - [x] Checked Search Profiler for visual regressions - [x] Checked Visualize Library > TSVB for visual regressions ### Checklist - [x] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [x] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) (cherry picked from commit cf72f3e)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 2, 2024
# Backport This will backport the following commits from `main` to `8.x`: - [Remove Sass `@euiPanel` mixin usage (#194646)](#194646) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Cee Chen","email":"549407+cee-chen@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-10-02T15:36:34Z","message":"Remove Sass `@euiPanel` mixin usage (#194646)\n\n## Summary\r\n\r\nThis PR is part of EUI's ongoing Emotion migration. We are actively\r\ndeprecating/removing Sass mixins and variables that are\r\ncomponent-specific.\r\n\r\nIn this case, the `@mixin euiPanel` **only** sets `flex-grow: 1;` as its\r\ndefault CSS and creates a bunch of modifier classes, none of which were\r\nbeing used in Kibana - hence various removals (see git commits for more\r\nspecifics).\r\n\r\n### QA\r\n\r\n- [x] Checked Search Profiler for visual regressions\r\n- [x] Checked Visualize Library > TSVB for visual regressions\r\n\r\n### Checklist\r\n\r\n- [x] This renders correctly on smaller devices using a responsive\r\nlayout. (You can test this [in your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n- [x] This was checked for [cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)","sha":"cf72f3e8113c8ab26f0188c56d047ab54927f7ee","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","EUI","v9.0.0","v8.16.0","backport:version"],"title":"Remove Sass `@euiPanel` mixin usage","number":194646,"url":"https://github.com/elastic/kibana/pull/194646","mergeCommit":{"message":"Remove Sass `@euiPanel` mixin usage (#194646)\n\n## Summary\r\n\r\nThis PR is part of EUI's ongoing Emotion migration. We are actively\r\ndeprecating/removing Sass mixins and variables that are\r\ncomponent-specific.\r\n\r\nIn this case, the `@mixin euiPanel` **only** sets `flex-grow: 1;` as its\r\ndefault CSS and creates a bunch of modifier classes, none of which were\r\nbeing used in Kibana - hence various removals (see git commits for more\r\nspecifics).\r\n\r\n### QA\r\n\r\n- [x] Checked Search Profiler for visual regressions\r\n- [x] Checked Visualize Library > TSVB for visual regressions\r\n\r\n### Checklist\r\n\r\n- [x] This renders correctly on smaller devices using a responsive\r\nlayout. (You can test this [in your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n- [x] This was checked for [cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)","sha":"cf72f3e8113c8ab26f0188c56d047ab54927f7ee"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/194646","number":194646,"mergeCommit":{"message":"Remove Sass `@euiPanel` mixin usage (#194646)\n\n## Summary\r\n\r\nThis PR is part of EUI's ongoing Emotion migration. We are actively\r\ndeprecating/removing Sass mixins and variables that are\r\ncomponent-specific.\r\n\r\nIn this case, the `@mixin euiPanel` **only** sets `flex-grow: 1;` as its\r\ndefault CSS and creates a bunch of modifier classes, none of which were\r\nbeing used in Kibana - hence various removals (see git commits for more\r\nspecifics).\r\n\r\n### QA\r\n\r\n- [x] Checked Search Profiler for visual regressions\r\n- [x] Checked Visualize Library > TSVB for visual regressions\r\n\r\n### Checklist\r\n\r\n- [x] This renders correctly on smaller devices using a responsive\r\nlayout. (You can test this [in your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n- [x] This was checked for [cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)","sha":"cf72f3e8113c8ab26f0188c56d047ab54927f7ee"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Cee Chen <549407+cee-chen@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR is part of EUI's ongoing Emotion migration. We are actively deprecating/removing Sass mixins and variables that are component-specific.
In this case, the
@mixin euiPanelonly setsflex-grow: 1;as its default CSS and creates a bunch of modifier classes, none of which were being used in Kibana - hence various removals (see git commits for more specifics).QA
Checklist