Skip to content

Remove Sass @euiPanel mixin usage#194646

Merged
cee-chen merged 2 commits intoelastic:mainfrom
cee-chen:eui/remove-panel-mixin
Oct 2, 2024
Merged

Remove Sass @euiPanel mixin usage#194646
cee-chen merged 2 commits intoelastic:mainfrom
cee-chen:eui/remove-panel-mixin

Conversation

@cee-chen
Copy link
Copy Markdown
Contributor

@cee-chen cee-chen commented Oct 1, 2024

Summary

This PR is part of EUI's ongoing Emotion migration. We are actively deprecating/removing Sass mixins and variables that are component-specific.

In this case, the @mixin euiPanel only sets flex-grow: 1; as its default CSS and creates a bunch of modifier classes, none of which were being used in Kibana - hence various removals (see git commits for more specifics).

QA

  • Checked Search Profiler for visual regressions
  • Checked Visualize Library > TSVB for visual regressions

Checklist

…h CSS output

- the mixin mostly adds modifier classes, none of which are being used here 🤷
- the mixin mostly adds modifier classes, none of which are being used

- the parents of these elements aren't flex, so adding flex-grow: 1 does nothing
@cee-chen cee-chen added release_note:skip Skip the PR/issue when compiling release notes EUI v9.0.0 v8.16.0 backport:version Backport to applied version labels labels Oct 1, 2024
@kibana-ci
Copy link
Copy Markdown

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
visTypeTimeseries 513.0KB 506.9KB -6.0KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
searchprofiler 18.9KB 16.0KB -2.9KB

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@cee-chen cee-chen marked this pull request as ready for review October 1, 2024 23:57
@cee-chen cee-chen requested a review from a team as a code owner October 1, 2024 23:57
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/eui-team (EUI)

@cee-chen cee-chen merged commit cf72f3e into elastic:main Oct 2, 2024
@cee-chen cee-chen deleted the eui/remove-panel-mixin branch October 2, 2024 15:36
@kibanamachine
Copy link
Copy Markdown
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/11146956293

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 2, 2024
## Summary

This PR is part of EUI's ongoing Emotion migration. We are actively
deprecating/removing Sass mixins and variables that are
component-specific.

In this case, the `@mixin euiPanel` **only** sets `flex-grow: 1;` as its
default CSS and creates a bunch of modifier classes, none of which were
being used in Kibana - hence various removals (see git commits for more
specifics).

### QA

- [x] Checked Search Profiler for visual regressions
- [x] Checked Visualize Library > TSVB for visual regressions

### Checklist

- [x] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [x] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)

(cherry picked from commit cf72f3e)
@kibanamachine
Copy link
Copy Markdown
Contributor

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Oct 2, 2024
# Backport

This will backport the following commits from `main` to `8.x`:
- [Remove Sass `@euiPanel` mixin usage
(#194646)](#194646)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Cee
Chen","email":"549407+cee-chen@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-10-02T15:36:34Z","message":"Remove
Sass `@euiPanel` mixin usage (#194646)\n\n## Summary\r\n\r\nThis PR is
part of EUI's ongoing Emotion migration. We are
actively\r\ndeprecating/removing Sass mixins and variables that
are\r\ncomponent-specific.\r\n\r\nIn this case, the `@mixin euiPanel`
**only** sets `flex-grow: 1;` as its\r\ndefault CSS and creates a bunch
of modifier classes, none of which were\r\nbeing used in Kibana - hence
various removals (see git commits for more\r\nspecifics).\r\n\r\n###
QA\r\n\r\n- [x] Checked Search Profiler for visual regressions\r\n- [x]
Checked Visualize Library > TSVB for visual regressions\r\n\r\n###
Checklist\r\n\r\n- [x] This renders correctly on smaller devices using a
responsive\r\nlayout. (You can test this [in
your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n-
[x] This was checked for
[cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)","sha":"cf72f3e8113c8ab26f0188c56d047ab54927f7ee","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","EUI","v9.0.0","v8.16.0","backport:version"],"title":"Remove
Sass `@euiPanel` mixin
usage","number":194646,"url":"https://github.com/elastic/kibana/pull/194646","mergeCommit":{"message":"Remove
Sass `@euiPanel` mixin usage (#194646)\n\n## Summary\r\n\r\nThis PR is
part of EUI's ongoing Emotion migration. We are
actively\r\ndeprecating/removing Sass mixins and variables that
are\r\ncomponent-specific.\r\n\r\nIn this case, the `@mixin euiPanel`
**only** sets `flex-grow: 1;` as its\r\ndefault CSS and creates a bunch
of modifier classes, none of which were\r\nbeing used in Kibana - hence
various removals (see git commits for more\r\nspecifics).\r\n\r\n###
QA\r\n\r\n- [x] Checked Search Profiler for visual regressions\r\n- [x]
Checked Visualize Library > TSVB for visual regressions\r\n\r\n###
Checklist\r\n\r\n- [x] This renders correctly on smaller devices using a
responsive\r\nlayout. (You can test this [in
your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n-
[x] This was checked for
[cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)","sha":"cf72f3e8113c8ab26f0188c56d047ab54927f7ee"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/194646","number":194646,"mergeCommit":{"message":"Remove
Sass `@euiPanel` mixin usage (#194646)\n\n## Summary\r\n\r\nThis PR is
part of EUI's ongoing Emotion migration. We are
actively\r\ndeprecating/removing Sass mixins and variables that
are\r\ncomponent-specific.\r\n\r\nIn this case, the `@mixin euiPanel`
**only** sets `flex-grow: 1;` as its\r\ndefault CSS and creates a bunch
of modifier classes, none of which were\r\nbeing used in Kibana - hence
various removals (see git commits for more\r\nspecifics).\r\n\r\n###
QA\r\n\r\n- [x] Checked Search Profiler for visual regressions\r\n- [x]
Checked Visualize Library > TSVB for visual regressions\r\n\r\n###
Checklist\r\n\r\n- [x] This renders correctly on smaller devices using a
responsive\r\nlayout. (You can test this [in
your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n-
[x] This was checked for
[cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)","sha":"cf72f3e8113c8ab26f0188c56d047ab54927f7ee"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Cee Chen <549407+cee-chen@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:version Backport to applied version labels EUI release_note:skip Skip the PR/issue when compiling release notes v8.16.0 v9.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants