[8.x] Remove Sass `@euiPanel` mixin usage (#194646)#194728
Merged
kibanamachine merged 1 commit intoelastic:8.xfrom Oct 2, 2024
Merged
[8.x] Remove Sass `@euiPanel` mixin usage (#194646)#194728kibanamachine merged 1 commit intoelastic:8.xfrom
kibanamachine merged 1 commit intoelastic:8.xfrom
Conversation
## Summary This PR is part of EUI's ongoing Emotion migration. We are actively deprecating/removing Sass mixins and variables that are component-specific. In this case, the `@mixin euiPanel` **only** sets `flex-grow: 1;` as its default CSS and creates a bunch of modifier classes, none of which were being used in Kibana - hence various removals (see git commits for more specifics). ### QA - [x] Checked Search Profiler for visual regressions - [x] Checked Visualize Library > TSVB for visual regressions ### Checklist - [x] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [x] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) (cherry picked from commit cf72f3e)
4 tasks
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
Page load bundle
To update your PR or re-run it, just comment with: cc @cee-chen |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.x:Questions ?
Please refer to the Backport tool documentation