Delete imports/references to EUI's distributed .css files#194237
Merged
cee-chen merged 4 commits intoelastic:mainfrom Sep 30, 2024
Merged
Delete imports/references to EUI's distributed .css files#194237cee-chen merged 4 commits intoelastic:mainfrom
.css files#194237cee-chen merged 4 commits intoelastic:mainfrom
Conversation
- no longer contains any meaningful or used CSS as of the finished Emotion migration
- does not contain any CSS other than EUI's, and confirmed by KibanaOps as not likely contain any in the future
0d85d39 to
c1d98bb
Compare
Contributor
|
Pinging @elastic/eui-team (EUI) |
nreese
approved these changes
Sep 27, 2024
Contributor
nreese
left a comment
There was a problem hiding this comment.
kibana-presentation changes LGTM
code review only
elena-shostak
approved these changes
Sep 27, 2024
Contributor
elena-shostak
left a comment
There was a problem hiding this comment.
Security changes LGTM!
Contributor
|
Mind if we add one (any) of the project deploy labels? It's where we caught the issue last time, I'll do a validation run on it. |
Contributor
Author
|
Please do! Thanks so much Jon!
|
Contributor
|
buildkite test this |
jbudz
approved these changes
Sep 27, 2024
2 tasks
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Page load bundle
History
To update your PR or re-run it, just comment with: |
Contributor
|
Starting backport for target branches: 8.x |
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 30, 2024
…194237) ## Summary Trying elastic#194082 again, this time wholly deleting `kbn-ui-shared-deps-npm.v8.light/dark.css` as well 🤞 Original PR description: > These files no longer contain any meaningful CSS used within Kibana as of EUI's completed Emotion migration, and can be safely removed. EUI will shortly no longer distribute these static `.css` files (although `.scss` src files will still remain exported for the near future). --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 866adf3)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Sep 30, 2024
…#x60; files (#194237) (#194474) # Backport This will backport the following commits from `main` to `8.x`: - [Delete imports/references to EUI's distributed `.css` files (#194237)](#194237) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Cee Chen","email":"549407+cee-chen@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-09-30T18:37:47Z","message":"Delete imports/references to EUI's distributed `.css` files (#194237)\n\n## Summary\r\n\r\nTrying #194082 again, this time wholly deleting\r\n`kbn-ui-shared-deps-npm.v8.light/dark.css` as well 🤞\r\n\r\nOriginal PR description: \r\n\r\n> These files no longer contain any meaningful CSS used within Kibana as\r\nof EUI's completed Emotion migration, and can be safely removed. EUI\r\nwill shortly no longer distribute these static `.css` files (although\r\n`.scss` src files will still remain exported for the near future).\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"866adf37f13c79c06fe426fa822231940132de03","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","EUI","v9.0.0","ci:project-deploy-elasticsearch","v8.16.0","backport:version"],"title":"Delete imports/references to EUI's distributed `.css` files","number":194237,"url":"https://github.com/elastic/kibana/pull/194237","mergeCommit":{"message":"Delete imports/references to EUI's distributed `.css` files (#194237)\n\n## Summary\r\n\r\nTrying #194082 again, this time wholly deleting\r\n`kbn-ui-shared-deps-npm.v8.light/dark.css` as well 🤞\r\n\r\nOriginal PR description: \r\n\r\n> These files no longer contain any meaningful CSS used within Kibana as\r\nof EUI's completed Emotion migration, and can be safely removed. EUI\r\nwill shortly no longer distribute these static `.css` files (although\r\n`.scss` src files will still remain exported for the near future).\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"866adf37f13c79c06fe426fa822231940132de03"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/194237","number":194237,"mergeCommit":{"message":"Delete imports/references to EUI's distributed `.css` files (#194237)\n\n## Summary\r\n\r\nTrying #194082 again, this time wholly deleting\r\n`kbn-ui-shared-deps-npm.v8.light/dark.css` as well 🤞\r\n\r\nOriginal PR description: \r\n\r\n> These files no longer contain any meaningful CSS used within Kibana as\r\nof EUI's completed Emotion migration, and can be safely removed. EUI\r\nwill shortly no longer distribute these static `.css` files (although\r\n`.scss` src files will still remain exported for the near future).\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"866adf37f13c79c06fe426fa822231940132de03"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Cee Chen <549407+cee-chen@users.noreply.github.com>
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Trying #194082 again, this time wholly deleting
kbn-ui-shared-deps-npm.v8.light/dark.cssas well 🤞Original PR description: