Delete imports/references to EUI's distributed .css files#194082
Delete imports/references to EUI's distributed .css files#194082cee-chen merged 1 commit intoelastic:mainfrom
.css files#194082Conversation
- no longer contains any meaningful or used CSS as of the finished Emotion migration
675c833 to
902f610
Compare
💚 Build Succeeded
Metrics [docs]Page load bundle
History
To update your PR or re-run it, just comment with: |
|
Pinging @elastic/eui-team (EUI) |
nreese
left a comment
There was a problem hiding this comment.
kibana-presentation changes LGTM
code review only
…194082) ## Summary These files no longer contain any meaningful CSS used within Kibana as of EUI's completed Emotion migration, and can be safely removed. EUI will shortly no longer distribute these static `.css` files (although `.scss` src files will still remain exported for the near future). (cherry picked from commit 9956c9a)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
|
This was reverted with b79dee5. |
|
Shucks, was worried about that. It's not totally clear to me what's even in |
## Summary Trying #194082 again, this time wholly deleting `kbn-ui-shared-deps-npm.v8.light/dark.css` as well 🤞 Original PR description: > These files no longer contain any meaningful CSS used within Kibana as of EUI's completed Emotion migration, and can be safely removed. EUI will shortly no longer distribute these static `.css` files (although `.scss` src files will still remain exported for the near future). --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
…194237) ## Summary Trying elastic#194082 again, this time wholly deleting `kbn-ui-shared-deps-npm.v8.light/dark.css` as well 🤞 Original PR description: > These files no longer contain any meaningful CSS used within Kibana as of EUI's completed Emotion migration, and can be safely removed. EUI will shortly no longer distribute these static `.css` files (although `.scss` src files will still remain exported for the near future). --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 866adf3)
…#x60; files (#194237) (#194474) # Backport This will backport the following commits from `main` to `8.x`: - [Delete imports/references to EUI's distributed `.css` files (#194237)](#194237) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Cee Chen","email":"549407+cee-chen@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-09-30T18:37:47Z","message":"Delete imports/references to EUI's distributed `.css` files (#194237)\n\n## Summary\r\n\r\nTrying #194082 again, this time wholly deleting\r\n`kbn-ui-shared-deps-npm.v8.light/dark.css` as well 🤞\r\n\r\nOriginal PR description: \r\n\r\n> These files no longer contain any meaningful CSS used within Kibana as\r\nof EUI's completed Emotion migration, and can be safely removed. EUI\r\nwill shortly no longer distribute these static `.css` files (although\r\n`.scss` src files will still remain exported for the near future).\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"866adf37f13c79c06fe426fa822231940132de03","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","EUI","v9.0.0","ci:project-deploy-elasticsearch","v8.16.0","backport:version"],"title":"Delete imports/references to EUI's distributed `.css` files","number":194237,"url":"https://github.com/elastic/kibana/pull/194237","mergeCommit":{"message":"Delete imports/references to EUI's distributed `.css` files (#194237)\n\n## Summary\r\n\r\nTrying #194082 again, this time wholly deleting\r\n`kbn-ui-shared-deps-npm.v8.light/dark.css` as well 🤞\r\n\r\nOriginal PR description: \r\n\r\n> These files no longer contain any meaningful CSS used within Kibana as\r\nof EUI's completed Emotion migration, and can be safely removed. EUI\r\nwill shortly no longer distribute these static `.css` files (although\r\n`.scss` src files will still remain exported for the near future).\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"866adf37f13c79c06fe426fa822231940132de03"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/194237","number":194237,"mergeCommit":{"message":"Delete imports/references to EUI's distributed `.css` files (#194237)\n\n## Summary\r\n\r\nTrying #194082 again, this time wholly deleting\r\n`kbn-ui-shared-deps-npm.v8.light/dark.css` as well 🤞\r\n\r\nOriginal PR description: \r\n\r\n> These files no longer contain any meaningful CSS used within Kibana as\r\nof EUI's completed Emotion migration, and can be safely removed. EUI\r\nwill shortly no longer distribute these static `.css` files (although\r\n`.scss` src files will still remain exported for the near future).\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"866adf37f13c79c06fe426fa822231940132de03"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Cee Chen <549407+cee-chen@users.noreply.github.com>
Summary
These files no longer contain any meaningful CSS used within Kibana as of EUI's completed Emotion migration, and can be safely removed. EUI will shortly no longer distribute these static
.cssfiles (although.scsssrc files will still remain exported for the near future).