[Security Solution] Integration tests for rule type field diff algorithms#193375
Conversation
…rithm-integration-tests
|
Pinging @elastic/security-detections-response (Team:Detections and Resp) |
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
|
Pinging @elastic/security-detection-rule-management (Team:Detection Rule Management) |
Flaky Test Runner Stats🟠 Some tests failed. - kibana-flaky-test-suite-runner#7044[❌] x-pack/test/security_solution_api_integration/test_suites/detections_response/rules_management/prebuilt_rules/management/trial_license_complete_tier/configs/ess.config.ts: 0/100 tests passed. |
Flaky Test Runner Stats🎉 All tests passed! - kibana-flaky-test-suite-runner#7046[✅] x-pack/test/security_solution_api_integration/test_suites/detections_response/rules_management/prebuilt_rules/management/trial_license_complete_tier/configs/ess.config.ts: 100/100 tests passed. |
…rithm-integration-tests
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]
History
To update your PR or re-run it, just comment with: cc @dplumlee |
…rithm-integration-tests
...les/management/trial_license_complete_tier/upgrade_review_prebuilt_rules.rule_type_fields.ts
Outdated
Show resolved
Hide resolved
jpdjere
left a comment
There was a problem hiding this comment.
Approving, left a comment cause I think an explanation is still outdated about conflicts. But LGTM after that is fixed 👍
…rithm-integration-tests
|
Starting backport for target branches: 8.x |
💚 Build Succeeded
Metrics [docs]
History
cc @dplumlee |
…rithms (elastic#193375) ## Summary Completes elastic#190482 Switches rule `type` field to use the implemented diff algorithms assigned to them in elastic#193369 Adds integration tests in accordance to elastic#193372 for the `upgrade/_review` API endpoint for the rule `type` field diff algorithm. Also fixes some nested bracket misalignment that occurred in earlier PRs with some test files ### Checklist Delete any items that are not applicable to this PR. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) (cherry picked from commit e119d83)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
… field diff algorithms (#193375) (#195518) # Backport This will backport the following commits from `main` to `8.x`: - [[Security Solution] Integration tests for rule `type` field diff algorithms (#193375)](#193375) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Davis Plumlee","email":"56367316+dplumlee@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-10-08T22:46:33Z","message":"[Security Solution] Integration tests for rule `type` field diff algorithms (#193375)\n\n## Summary\r\n\r\nCompletes https://github.com/elastic/kibana/issues/190482\r\n\r\n\r\nSwitches rule `type` field to use the implemented diff algorithms\r\nassigned to them in https://github.com/elastic/kibana/pull/193369\r\n\r\n\r\nAdds integration tests in accordance to\r\nhttps://github.com//pull/193372 for the `upgrade/_review`\r\nAPI endpoint for the rule `type` field diff algorithm.\r\n\r\nAlso fixes some nested bracket misalignment that occurred in earlier PRs\r\nwith some test files\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] [Flaky Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\r\nused on any tests changed\r\n\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"e119d83c26387e85e9fdf3cc5d5eeceeebb04edb","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["test","release_note:skip","v9.0.0","Team:Detections and Resp","Team: SecuritySolution","Team:Detection Rule Management","Feature:Prebuilt Detection Rules","backport:prev-minor","v8.16.0"],"title":"[Security Solution] Integration tests for rule `type` field diff algorithms","number":193375,"url":"https://github.com/elastic/kibana/pull/193375","mergeCommit":{"message":"[Security Solution] Integration tests for rule `type` field diff algorithms (#193375)\n\n## Summary\r\n\r\nCompletes https://github.com/elastic/kibana/issues/190482\r\n\r\n\r\nSwitches rule `type` field to use the implemented diff algorithms\r\nassigned to them in https://github.com/elastic/kibana/pull/193369\r\n\r\n\r\nAdds integration tests in accordance to\r\nhttps://github.com//pull/193372 for the `upgrade/_review`\r\nAPI endpoint for the rule `type` field diff algorithm.\r\n\r\nAlso fixes some nested bracket misalignment that occurred in earlier PRs\r\nwith some test files\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] [Flaky Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\r\nused on any tests changed\r\n\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"e119d83c26387e85e9fdf3cc5d5eeceeebb04edb"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/193375","number":193375,"mergeCommit":{"message":"[Security Solution] Integration tests for rule `type` field diff algorithms (#193375)\n\n## Summary\r\n\r\nCompletes https://github.com/elastic/kibana/issues/190482\r\n\r\n\r\nSwitches rule `type` field to use the implemented diff algorithms\r\nassigned to them in https://github.com/elastic/kibana/pull/193369\r\n\r\n\r\nAdds integration tests in accordance to\r\nhttps://github.com//pull/193372 for the `upgrade/_review`\r\nAPI endpoint for the rule `type` field diff algorithm.\r\n\r\nAlso fixes some nested bracket misalignment that occurred in earlier PRs\r\nwith some test files\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] [Flaky Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\r\nused on any tests changed\r\n\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"e119d83c26387e85e9fdf3cc5d5eeceeebb04edb"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Davis Plumlee <56367316+dplumlee@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Summary
Completes #190482
Switches rule
typefield to use the implemented diff algorithms assigned to them in #193369Adds integration tests in accordance to #193372 for the
upgrade/_reviewAPI endpoint for the ruletypefield diff algorithm.Also fixes some nested bracket misalignment that occurred in earlier PRs with some test files
Checklist
Delete any items that are not applicable to this PR.
For maintainers