Skip to content

[Security Solution] Implement rule type diff algorithm #190482

@xcrzx

Description

@xcrzx

Epics: https://github.com/elastic/security-team/issues/1974 (internal), #174168
Related to: #180395

Summary

Implement an algorithm for diffing the type field of detection rules. Requirements:

  • The algorithm should always return the target version as the merged one.
  • Any change to the rule type (i.e. current version != target version) should yield an unsolvable conflict.
  • In the upgrade/_review API response such rules should be marked as having unsolvable conflicts.
  • Users should not be able to upgrade the type to any version other than the target. This should be implemented under the hood in the upgrade/_perform endpoint in [Security Solution] Extend the POST /upgrade/_perform API endpoint's contract and functionality #166376. The type field shouldn't be part of upgradeable fields that can be passed in the request body -- FYI @jpdjere

Context from the Rule Customization RFC:

To do

Metadata

Metadata

Assignees

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions