Skip to content

[Screenshotting/7.17] Server package for stateless code#189326

Closed
tsullivan wants to merge 11 commits intoelastic:7.17from
tsullivan:screenshotting/server-package-7.17
Closed

[Screenshotting/7.17] Server package for stateless code#189326
tsullivan wants to merge 11 commits intoelastic:7.17from
tsullivan:screenshotting/server-package-7.17

Conversation

@tsullivan
Copy link
Copy Markdown
Member

@tsullivan tsullivan commented Jul 26, 2024

Corresponds with #188390

Replaced with #190950

@tsullivan tsullivan force-pushed the screenshotting/server-package-7.17 branch 4 times, most recently from fd9d151 to ff544d8 Compare July 30, 2024 17:00
@elastic elastic deleted a comment from kibana-ci Jul 30, 2024
@tsullivan tsullivan added the backport This PR is a backport of another PR label Jul 30, 2024
@elastic elastic deleted a comment from kibana-ci Jul 30, 2024
@tsullivan tsullivan force-pushed the screenshotting/server-package-7.17 branch 3 times, most recently from 0428486 to 950858d Compare July 30, 2024 23:51
@tsullivan
Copy link
Copy Markdown
Member Author

/ci

@tsullivan tsullivan force-pushed the screenshotting/server-package-7.17 branch from 14f0aa3 to cad9a39 Compare August 2, 2024 05:11
@tsullivan
Copy link
Copy Markdown
Member Author

/ci

@tsullivan
Copy link
Copy Markdown
Member Author

/ci

@tsullivan
Copy link
Copy Markdown
Member Author

/ci

…e-7.17

use same chromium path install method is invoked with for background install
@eokoneyo eokoneyo added the ci:cloud-deploy Create or update a Cloud deployment label Aug 13, 2024
@eokoneyo
Copy link
Copy Markdown
Contributor

/ci

1 similar comment
@tsullivan
Copy link
Copy Markdown
Member Author

/ci

@tsullivan
Copy link
Copy Markdown
Member Author

/ci

@eokoneyo
Copy link
Copy Markdown
Contributor

/ci

@eokoneyo eokoneyo marked this pull request as ready for review August 19, 2024 13:58
@eokoneyo
Copy link
Copy Markdown
Contributor

@elasticmachine merge upstream

@eokoneyo
Copy link
Copy Markdown
Contributor

/ci

@eokoneyo
Copy link
Copy Markdown
Contributor

@elasticmachine merge upstream

@kibana-ci
Copy link
Copy Markdown

💔 Build Failed

Failed CI Steps

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@tsullivan
Copy link
Copy Markdown
Member Author

Replaced with #190950

@tsullivan tsullivan closed this Aug 21, 2024
eokoneyo added a commit that referenced this pull request Aug 22, 2024
Corresponds with #188390, branched
from #189326

<!--
### Checklist

Delete any items that are not applicable to this PR.

- [ ] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
- [ ] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
- [ ] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
- [ ] If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
- [ ] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [ ] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)


### Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to
identify risks that should be tested prior to the change/feature
release.

When forming the risk matrix, consider some of the following examples
and how they may potentially impact the change:

| Risk | Probability | Severity | Mitigation/Notes |

|---------------------------|-------------|----------|-------------------------|
| Multiple Spaces&mdash;unexpected behavior in non-default Kibana Space.
| Low | High | Integration tests will verify that all features are still
supported in non-default Kibana Space and when user switches between
spaces. |
| Multiple nodes&mdash;Elasticsearch polling might have race conditions
when multiple Kibana nodes are polling for the same tasks. | High | Low
| Tasks are idempotent, so executing them multiple times will not result
in logical error, but will degrade performance. To test for this case we
add plenty of unit tests around this logic and document manual testing
procedure. |
| Code should gracefully handle cases when feature X or plugin Y are
disabled. | Medium | High | Unit tests will verify that any feature flag
or plugin combination still results in our service operational. |
| [See more potential risk
examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) |


### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

-->

---------

Co-authored-by: Timothy Sullivan <tsullivan@elastic.co>
Co-authored-by: Tim Sullivan <tsullivan@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR ci:cloud-deploy Create or update a Cloud deployment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants