Skip to content

[Screenshotting/7.17] Server package for stateless code#190950

Merged
eokoneyo merged 12 commits intoelastic:7.17from
eokoneyo:screenshotting/server-package-7.17
Aug 22, 2024
Merged

[Screenshotting/7.17] Server package for stateless code#190950
eokoneyo merged 12 commits intoelastic:7.17from
eokoneyo:screenshotting/server-package-7.17

Conversation

@eokoneyo
Copy link
Copy Markdown
Contributor

@eokoneyo eokoneyo commented Aug 21, 2024

Corresponds with #188390, branched from #189326

@eokoneyo eokoneyo self-assigned this Aug 21, 2024
@eokoneyo eokoneyo added release_note:fix release_note:skip Skip the PR/issue when compiling release notes and removed release_note:fix labels Aug 21, 2024
@eokoneyo eokoneyo requested a review from tsullivan August 21, 2024 16:16
Copy link
Copy Markdown
Member

@tsullivan tsullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for getting this to pass!

I have updated #188390 to put the screenshotting package in the same place, so we'll have the paths.ts file in the same path location for both branches.

@eokoneyo eokoneyo added Team:SharedUX Platform AppEx-SharedUX (formerly Global Experience) t// Feature:Reporting:Framework Reporting issues pertaining to the overall framework labels Aug 22, 2024
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/appex-sharedux (Team:SharedUX)

@eokoneyo
Copy link
Copy Markdown
Contributor Author

@elasticmachine merge upstream

@eokoneyo eokoneyo enabled auto-merge (squash) August 22, 2024 08:29
@eokoneyo eokoneyo disabled auto-merge August 22, 2024 08:32
@eokoneyo eokoneyo enabled auto-merge (squash) August 22, 2024 08:37
@kibana-ci
Copy link
Copy Markdown

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/screenshotting-server - 25 +25
Unknown metric groups

API count

id before after diff
@kbn/screenshotting-server - 25 +25

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @eokoneyo

@eokoneyo eokoneyo merged commit 07cfc46 into elastic:7.17 Aug 22, 2024
@eokoneyo eokoneyo deleted the screenshotting/server-package-7.17 branch August 22, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature:Reporting:Framework Reporting issues pertaining to the overall framework release_note:skip Skip the PR/issue when compiling release notes Team:SharedUX Platform AppEx-SharedUX (formerly Global Experience) t//

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants