Skip to content

Revert "Siem query rule - reduce field_caps usage (#184890)"#186196

Merged
dhurley14 merged 2 commits intoelastic:mainfrom
dhurley14:cherry-pick-e2ce233d824f8c54bc1c028a91e624bcf6b70509
Jun 13, 2024
Merged

Revert "Siem query rule - reduce field_caps usage (#184890)"#186196
dhurley14 merged 2 commits intoelastic:mainfrom
dhurley14:cherry-pick-e2ce233d824f8c54bc1c028a91e624bcf6b70509

Conversation

@dhurley14
Copy link
Copy Markdown
Contributor

@dhurley14 dhurley14 commented Jun 13, 2024

Reverted 257ef7f from deploy@1718000036 as part of emergency release. This PR is following the emergency release guidelines to:

In a separate PR, the fix should be "frontported" to main by manually cherry-picking the commit.

Deployed PR: #186181

@dhurley14 dhurley14 requested review from a team as code owners June 13, 2024 16:05
@dhurley14 dhurley14 requested a review from rylnd June 13, 2024 16:05
@dhurley14 dhurley14 self-assigned this Jun 13, 2024
@dhurley14 dhurley14 added release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting v8.15.0 Team:Detection Engine Security Solution Detection Engine Area labels Jun 13, 2024
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/security-detection-engine (Team:Detection Engine)

@kibana-ci
Copy link
Copy Markdown

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
data 512 511 -1

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
data 2590 2585 -5

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
data 420.1KB 420.0KB -129.0B
Unknown metric groups

API count

id before after diff
data 3199 3194 -5

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @dhurley14

Copy link
Copy Markdown
Contributor

@davismcphee davismcphee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed locally that a SIEM rule targeting the kibana_sample_data_logs data view with the Lucene query host: artifacts\.* consistently fails in main, but does not fail in this PR. Data Discovery changes LGTM 👍

@dhurley14 dhurley14 merged commit b8539da into elastic:main Jun 13, 2024
@dhurley14 dhurley14 deleted the cherry-pick-e2ce233d824f8c54bc1c028a91e624bcf6b70509 branch June 13, 2024 20:22
lukasolson added a commit that referenced this pull request Jun 14, 2024
## Summary

Same as #186211, but to avoid
conflicts after #186196.

### Checklist

Delete any items that are not applicable to this PR.

- [ ] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
- [ ] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
- [ ] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
- [ ] If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
- [ ] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [ ] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)


### Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to
identify risks that should be tested prior to the change/feature
release.

When forming the risk matrix, consider some of the following examples
and how they may potentially impact the change:

| Risk | Probability | Severity | Mitigation/Notes |

|---------------------------|-------------|----------|-------------------------|
| Multiple Spaces—unexpected behavior in non-default Kibana Space.
| Low | High | Integration tests will verify that all features are still
supported in non-default Kibana Space and when user switches between
spaces. |
| Multiple nodes—Elasticsearch polling might have race conditions
when multiple Kibana nodes are polling for the same tasks. | High | Low
| Tasks are idempotent, so executing them multiple times will not result
in logical error, but will degrade performance. To test for this case we
add plenty of unit tests around this logic and document manual testing
procedure. |
| Code should gracefully handle cases when feature X or plugin Y are
disabled. | Medium | High | Unit tests will verify that any feature flag
or plugin combination still results in our service operational. |
| [See more potential risk
examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) |


### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
lukasolson added a commit that referenced this pull request Jun 18, 2024
## Summary

#184890 was reverted in
#186196 because it contained a bug
with alerts created using Lucene queries. The bug was fixed in
#186217. This PR un-reverts the
original changes and preserves the fix. It also adds unit tests to cover
the failed cases.

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Detection Engine Security Solution Detection Engine Area v8.15.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants