Skip to content

Revert "Siem query rule - reduce field_caps usage (#184890)"#186181

Merged
mikecote merged 2 commits intoelastic:deploy-fix@1718000036from
dhurley14:deploy-fix@1718000036
Jun 13, 2024
Merged

Revert "Siem query rule - reduce field_caps usage (#184890)"#186181
mikecote merged 2 commits intoelastic:deploy-fix@1718000036from
dhurley14:deploy-fix@1718000036

Conversation

@dhurley14
Copy link
Copy Markdown
Contributor

@dhurley14 dhurley14 commented Jun 13, 2024

This reverts commit 257ef7f.

Summary

Summarize your PR. If it involves visual changes include a screenshot or gif.

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

@dhurley14 dhurley14 requested review from a team as code owners June 13, 2024 13:08
@dhurley14 dhurley14 requested a review from e40pud June 13, 2024 13:08
@kibana-ci
Copy link
Copy Markdown

kibana-ci commented Jun 13, 2024 •
edited
Loading

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #43 / machine learning - anomaly detection forecasts with single metric job displays job results
  • [job] [logs] FTR Configs #43 / machine learning - anomaly detection forecasts with single metric job displays job results
  • [job] [logs] FTR Configs #43 / machine learning - anomaly detection forecasts with single metric job displays job results

Metrics [docs]

‼️ ERROR: no builds found for mergeBase sha [cf768dc]

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mikecote mikecote merged commit e66cedc into elastic:deploy-fix@1718000036 Jun 13, 2024
@mikecote
Copy link
Copy Markdown
Contributor

mikecote commented Jun 13, 2024

Merging as the ML test is flaky and skipped on main now..

@dhurley14 dhurley14 mentioned this pull request Jun 13, 2024
Merged
dhurley14 added a commit that referenced this pull request Jun 13, 2024
@dhurley14
Revert "Siem query rule - reduce field_caps usage (#184890)" (#186196)
b8539da 
Reverted
257ef7f
from deploy@1718000036 as part of emergency release. This PR is
following the emergency release guidelines to:

`In a separate PR, the fix should be "frontported" to main by manually
cherry-picking the commit.`

Deployed PR: #186181
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@e40pud e40pud e40pud approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dhurley14 @kibana-ci @mikecote @e40pud