Skip to content

[Obs AI Assistant] Make sure arguments have a default#185691

Merged
dgieselaar merged 1 commit intoelastic:mainfrom
dgieselaar:obs-ai-assistant-empty-args-fix
Jun 10, 2024
Merged

[Obs AI Assistant] Make sure arguments have a default#185691
dgieselaar merged 1 commit intoelastic:mainfrom
dgieselaar:obs-ai-assistant-empty-args-fix

Conversation

@dgieselaar
Copy link
Copy Markdown
Contributor

@dgieselaar dgieselaar commented Jun 10, 2024

In #184933, we removed the parameters for the context function, however, OpenAI requires at least an empty arguments object, so requests fail. This PR sets arguments to an empty JSON object ("{}") if function_call.arguments is empty.

@dgieselaar dgieselaar added Team:Obs AI Assistant Observability AI Assistant v8.15.0 labels Jun 10, 2024
@dgieselaar dgieselaar self-assigned this Jun 10, 2024
@dgieselaar dgieselaar requested a review from a team as a code owner June 10, 2024 08:47
@botelastic botelastic bot added the ci:project-deploy-observability Create an Observability project label Jun 10, 2024
@dgieselaar dgieselaar enabled auto-merge (squash) June 10, 2024 08:52
@dgieselaar dgieselaar added the release_note:skip Skip the PR/issue when compiling release notes label Jun 10, 2024
@kibana-ci
Copy link
Copy Markdown

kibana-ci commented Jun 10, 2024 •
edited
Loading

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @dgieselaar

@dgieselaar dgieselaar merged commit 8f3359c into elastic:main Jun 10, 2024
@kibanamachine kibanamachine added the backport:skip This PR does not require backporting label Jun 10, 2024
@dgieselaar dgieselaar deleted the obs-ai-assistant-empty-args-fix branch July 18, 2024 12:03
@dgieselaar dgieselaar mentioned this pull request Jul 18, 2024
Merged
@dgieselaar
Copy link
Copy Markdown
Contributor Author

dgieselaar commented Jul 18, 2024

💚 All backports created successfully

Status Branch Result
✅ 8.14

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

dgieselaar added a commit to dgieselaar/kibana that referenced this pull request Jul 18, 2024
@dgieselaar
[Obs AI Assistant] Make sure arguments have a default (elastic#185691)
d63b236 
In elastic#184933, we removed the
parameters for the `context` function, however, OpenAI requires at least
an empty `arguments` object, so requests fail. This PR sets arguments to
an empty JSON object (`"{}"`) if `function_call.arguments` is empty.

(cherry picked from commit 8f3359c)
dgieselaar added a commit that referenced this pull request Jul 23, 2024
@dgieselaar @neptunian
[8.14] [Obs AI Assistant] Make sure arguments have a default (#185691) (
669df43 
#188655)

# Backport

This will backport the following commits from `main` to `8.14`:
- [[Obs AI Assistant] Make sure arguments have a default
(#185691)](#185691)

<!--- Backport version: 7.3.2 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT {commits} BACKPORT-->

Co-authored-by: Sandra G <neptunian@users.noreply.github.com>
@colleenmcginnis colleenmcginnis mentioned this pull request Jul 25, 2024
Merged
1 task
colleenmcginnis pushed a commit that referenced this pull request Jul 29, 2024
[DOCS] Add known issue to 8.14.3 release notes (#189236)
5184260 
## Summary

Fixes https://github.com/elastic/observability-docs/issues/4090

Related to #185691

This PR adds a known issue to the 8.14.3 release docs related to
function calling when using the Observability AI Assistant with the
OpenAI connector.

### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 29, 2024
[DOCS] Add known issue to 8.14.3 release notes (elastic#189236)
3d1eba5 
## Summary

Fixes https://github.com/elastic/observability-docs/issues/4090

Related to elastic#185691

This PR adds a known issue to the 8.14.3 release docs related to
function calling when using the Observability AI Assistant with the
OpenAI connector.

### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

(cherry picked from commit 5184260)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 29, 2024
[DOCS] Add known issue to 8.14.3 release notes (elastic#189236)
eb607c6 
## Summary

Fixes https://github.com/elastic/observability-docs/issues/4090

Related to elastic#185691

This PR adds a known issue to the 8.14.3 release docs related to
function calling when using the Observability AI Assistant with the
OpenAI connector.

### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

(cherry picked from commit 5184260)
kibanamachine referenced this pull request Jul 29, 2024
@kibanamachine
[8.14] [DOCS] Add known issue to 8.14.3 release notes (#189236) (#189440
00b024e 
)

# Backport

This will backport the following commits from `main` to `8.14`:
- [[DOCS] Add known issue to 8.14.3 release notes
(#189236)](#189236)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Colleen
McGinnis","email":"colleen.mcginnis@elastic.co"},"sourceCommit":{"committedDate":"2024-07-29T18:46:24Z","message":"[DOCS]
Add known issue to 8.14.3 release notes (#189236)\n\n##
Summary\r\n\r\nFixes
https://github.com/elastic/observability-docs/issues/4090\r\n\r\nRelated
to https://github.com/elastic/kibana/pull/185691\r\n\r\nThis PR adds a
known issue to the 8.14.3 release docs related to\r\nfunction calling
when using the Observability AI Assistant with the\r\nOpenAI
connector.\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for
breaking API changes and was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"518426045db64f14a19b5fae185a4ecf785cef54","branchLabelMapping":{"^v8.16.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","docs","backport:prev-minor","v8.16.0","v8.14.3"],"title":"[DOCS]
Add known issue to 8.14.3 release
notes","number":189236,"url":"https://github.com/elastic/kibana/pull/189236","mergeCommit":{"message":"[DOCS]
Add known issue to 8.14.3 release notes (#189236)\n\n##
Summary\r\n\r\nFixes
https://github.com/elastic/observability-docs/issues/4090\r\n\r\nRelated
to https://github.com/elastic/kibana/pull/185691\r\n\r\nThis PR adds a
known issue to the 8.14.3 release docs related to\r\nfunction calling
when using the Observability AI Assistant with the\r\nOpenAI
connector.\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for
breaking API changes and was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"518426045db64f14a19b5fae185a4ecf785cef54"}},"sourceBranch":"main","suggestedTargetBranches":["8.14"],"targetPullRequestStates":[{"branch":"main","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/189236","number":189236,"mergeCommit":{"message":"[DOCS]
Add known issue to 8.14.3 release notes (#189236)\n\n##
Summary\r\n\r\nFixes
https://github.com/elastic/observability-docs/issues/4090\r\n\r\nRelated
to https://github.com/elastic/kibana/pull/185691\r\n\r\nThis PR adds a
known issue to the 8.14.3 release docs related to\r\nfunction calling
when using the Observability AI Assistant with the\r\nOpenAI
connector.\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for
breaking API changes and was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"518426045db64f14a19b5fae185a4ecf785cef54"}},{"branch":"8.14","label":"v8.14.3","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Colleen McGinnis <colleen.mcginnis@elastic.co>
kibanamachine referenced this pull request Jul 29, 2024
@kibanamachine
[8.15] [DOCS] Add known issue to 8.14.3 release notes (#189236) (#189441
7ceef0d 
)

# Backport

This will backport the following commits from `main` to `8.15`:
- [[DOCS] Add known issue to 8.14.3 release notes
(#189236)](#189236)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Colleen
McGinnis","email":"colleen.mcginnis@elastic.co"},"sourceCommit":{"committedDate":"2024-07-29T18:46:24Z","message":"[DOCS]
Add known issue to 8.14.3 release notes (#189236)\n\n##
Summary\r\n\r\nFixes
https://github.com/elastic/observability-docs/issues/4090\r\n\r\nRelated
to https://github.com/elastic/kibana/pull/185691\r\n\r\nThis PR adds a
known issue to the 8.14.3 release docs related to\r\nfunction calling
when using the Observability AI Assistant with the\r\nOpenAI
connector.\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for
breaking API changes and was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"518426045db64f14a19b5fae185a4ecf785cef54","branchLabelMapping":{"^v8.16.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","docs","backport:prev-minor","v8.16.0","v8.14.3"],"title":"[DOCS]
Add known issue to 8.14.3 release
notes","number":189236,"url":"https://github.com/elastic/kibana/pull/189236","mergeCommit":{"message":"[DOCS]
Add known issue to 8.14.3 release notes (#189236)\n\n##
Summary\r\n\r\nFixes
https://github.com/elastic/observability-docs/issues/4090\r\n\r\nRelated
to https://github.com/elastic/kibana/pull/185691\r\n\r\nThis PR adds a
known issue to the 8.14.3 release docs related to\r\nfunction calling
when using the Observability AI Assistant with the\r\nOpenAI
connector.\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for
breaking API changes and was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"518426045db64f14a19b5fae185a4ecf785cef54"}},"sourceBranch":"main","suggestedTargetBranches":["8.14"],"targetPullRequestStates":[{"branch":"main","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/189236","number":189236,"mergeCommit":{"message":"[DOCS]
Add known issue to 8.14.3 release notes (#189236)\n\n##
Summary\r\n\r\nFixes
https://github.com/elastic/observability-docs/issues/4090\r\n\r\nRelated
to https://github.com/elastic/kibana/pull/185691\r\n\r\nThis PR adds a
known issue to the 8.14.3 release docs related to\r\nfunction calling
when using the Observability AI Assistant with the\r\nOpenAI
connector.\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for
breaking API changes and was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"518426045db64f14a19b5fae185a4ecf785cef54"}},{"branch":"8.14","label":"v8.14.3","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Colleen McGinnis <colleen.mcginnis@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@sorenlouv sorenlouv sorenlouv approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@dgieselaar dgieselaar

Labels

backport:skip This PR does not require backporting ci:project-deploy-observability Create an Observability project release_note:skip Skip the PR/issue when compiling release notes Team:Obs AI Assistant Observability AI Assistant v8.14.4 v8.15.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dgieselaar @kibana-ci @sorenlouv @kibanamachine