[8.14] [Obs AI Assistant] Make sure arguments have a default (#185691)#188655
Merged
dgieselaar merged 3 commits intoelastic:8.14from Jul 23, 2024
Merged
[8.14] [Obs AI Assistant] Make sure arguments have a default (#185691)#188655dgieselaar merged 3 commits intoelastic:8.14from
dgieselaar merged 3 commits intoelastic:8.14from
Conversation
In elastic#184933, we removed the parameters for the `context` function, however, OpenAI requires at least an empty `arguments` object, so requests fail. This PR sets arguments to an empty JSON object (`"{}"`) if `function_call.arguments` is empty. (cherry picked from commit 8f3359c)
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]
|
neptunian
approved these changes
Jul 23, 2024
💚 Build Succeeded
Metrics [docs]
To update your PR or re-run it, just comment with: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.14:Questions ?
Please refer to the Backport tool documentation