Skip to content

[Obs AI Assistant] Remove unneeded plugin references#182116

Merged
dgieselaar merged 4 commits intoelastic:mainfrom
dgieselaar:obs-ai-assistant-remove-refs
May 1, 2024
Merged

[Obs AI Assistant] Remove unneeded plugin references#182116
dgieselaar merged 4 commits intoelastic:mainfrom
dgieselaar:obs-ai-assistant-remove-refs

Conversation

@dgieselaar
Copy link
Copy Markdown
Contributor

@dgieselaar dgieselaar commented Apr 30, 2024 •
edited by kibanamachine
Loading

No code changes, just moving stuff around so the plugin can more easily by required by other plugins.

@dgieselaar dgieselaar added release_note:skip Skip the PR/issue when compiling release notes v8.14.0 labels Apr 30, 2024
@dgieselaar dgieselaar requested a review from a team as a code owner April 30, 2024 12:49
@botelastic botelastic bot added ci:project-deploy-observability Create an Observability project Team:Obs AI Assistant Observability AI Assistant labels Apr 30, 2024
@ghost
Copy link
Copy Markdown

ghost commented Apr 30, 2024

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@dgieselaar dgieselaar enabled auto-merge (squash) May 1, 2024 11:21
@dgieselaar
Copy link
Copy Markdown
Contributor Author

dgieselaar commented May 1, 2024

@elasticmachine merge upstream

@kibana-ci
Copy link
Copy Markdown

kibana-ci commented May 1, 2024 •
edited
Loading

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
observabilityAIAssistant 90 91 +1

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
observabilityAIAssistant 247 250 +3

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
observabilityAIAssistant 17.5KB 17.5KB -2.0B

Canvas Sharable Runtime

The Canvas "shareable runtime" is an bundle produced to enable running Canvas workpads outside of Kibana. This bundle is included in third-party webpages that embed canvas and therefor should be as slim as possible.

id before after diff
module count - 5887 +5887
total size - 6.7MB +6.7MB

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
observabilityAIAssistant 25 26 +1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
observabilityAIAssistant 45.8KB 45.8KB +11.0B
Unknown metric groups

API count

id before after diff
observabilityAIAssistant 249 252 +3

ESLint disabled line counts

id before after diff
observabilityAIAssistant 6 5 -1
observabilityAIAssistantApp 11 12 +1
total -0

Total ESLint disabled count

id before after diff
observabilityAIAssistant 9 8 -1
observabilityAIAssistantApp 11 12 +1
total -0

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@dgieselaar dgieselaar merged commit 0c8c4c1 into elastic:main May 1, 2024
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented May 1, 2024

💔 All backports failed

Status Branch Result
❌ 8.14 Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 182116

Questions ?

Please refer to the Backport tool documentation

This was referenced May 1, 2024
Merged
Merged
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented May 2, 2024

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 182116 locally

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label May 2, 2024
dgieselaar added a commit to dgieselaar/kibana that referenced this pull request May 3, 2024
@dgieselaar
[Obs AI Assistant] Remove unneeded plugin references (elastic#182116)
925aeb8 
No code changes, just moving stuff around so the plugin can more easily
by required by other plugins.

(cherry picked from commit 0c8c4c1)

# Conflicts:
#	x-pack/plugins/observability_solution/observability_ai_assistant/public/types.ts
#	x-pack/plugins/observability_solution/observability_ai_assistant/tsconfig.json
#	x-pack/plugins/observability_solution/observability_ai_assistant_app/tsconfig.json
@dgieselaar dgieselaar mentioned this pull request May 3, 2024
Merged
@dgieselaar
Copy link
Copy Markdown
Contributor Author

dgieselaar commented May 3, 2024

💚 All backports created successfully

Status Branch Result
✅ 8.14

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

dgieselaar added a commit that referenced this pull request May 3, 2024
@dgieselaar @kibanamachine
[8.14] [Obs AI Assistant] Remove unneeded plugin references (#182116) (…
e3de392 
…#182540)

# Backport

This will backport the following commits from `main` to `8.14`:
- [[Obs AI Assistant] Remove unneeded plugin references
(#182116)](#182116)

<!--- Backport version: 7.3.2 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT {commits} BACKPORT-->

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label May 3, 2024
@szaffarano szaffarano mentioned this pull request Jul 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@sorenlouv sorenlouv sorenlouv approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ci:project-deploy-observability Create an Observability project release_note:skip Skip the PR/issue when compiling release notes Team:Obs AI Assistant Observability AI Assistant v8.14.0 v8.15.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dgieselaar @kibana-ci @kibanamachine @sorenlouv