Skip to content

[8.14] [Obs AI Assistant] Remove unneeded plugin references (#182116)#182540

Merged
dgieselaar merged 3 commits intoelastic:8.14from
dgieselaar:backport/8.14/pr-182116
May 3, 2024
Merged

[8.14] [Obs AI Assistant] Remove unneeded plugin references (#182116)#182540
dgieselaar merged 3 commits intoelastic:8.14from
dgieselaar:backport/8.14/pr-182116

Conversation

@dgieselaar
Copy link
Copy Markdown
Contributor

@dgieselaar dgieselaar commented May 3, 2024

Backport

This will backport the following commits from main to 8.14:

Questions ?

Please refer to the Backport tool documentation

@dgieselaar
[Obs AI Assistant] Remove unneeded plugin references (elastic#182116)
925aeb8 
No code changes, just moving stuff around so the plugin can more easily
by required by other plugins.

(cherry picked from commit 0c8c4c1)

# Conflicts:
#	x-pack/plugins/observability_solution/observability_ai_assistant/public/types.ts
#	x-pack/plugins/observability_solution/observability_ai_assistant/tsconfig.json
#	x-pack/plugins/observability_solution/observability_ai_assistant_app/tsconfig.json
@dgieselaar dgieselaar added the backport This PR is a backport of another PR label May 3, 2024
@dgieselaar dgieselaar enabled auto-merge (squash) May 3, 2024 05:34
@dgieselaar dgieselaar mentioned this pull request May 3, 2024
Merged
@botelastic botelastic bot added the Team:Obs AI Assistant Observability AI Assistant label May 3, 2024
@ghost
Copy link
Copy Markdown

ghost commented May 3, 2024

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@kibana-ci
Copy link
Copy Markdown

kibana-ci commented May 3, 2024

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
observabilityAIAssistant 90 91 +1

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
observabilityAIAssistant 247 250 +3

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
observabilityAIAssistant 17.5KB 17.5KB -2.0B

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
observabilityAIAssistant 25 26 +1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
observabilityAIAssistant 46.2KB 46.2KB +11.0B
Unknown metric groups

API count

id before after diff
observabilityAIAssistant 249 252 +3

ESLint disabled line counts

id before after diff
observabilityAIAssistant 6 5 -1
observabilityAIAssistantApp 11 12 +1
total -0

Total ESLint disabled count

id before after diff
observabilityAIAssistant 9 8 -1
observabilityAIAssistantApp 11 12 +1
total -0

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@dgieselaar dgieselaar merged commit e3de392 into elastic:8.14 May 3, 2024
@szaffarano szaffarano mentioned this pull request Jul 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@miltonhultgren miltonhultgren miltonhultgren approved these changes

Assignees

No one assigned

Labels

backport This PR is a backport of another PR Team:Obs AI Assistant Observability AI Assistant

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dgieselaar @kibana-ci @miltonhultgren @kibanamachine