Merged
Conversation
This reverts commit 6a1b840.
Contributor
|
Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations) |
Contributor
|
@lgestc could you add the step to reproduce the issue? I'm looking at the comment but I'm not clear on what I need to test and how |
Contributor
Author
upated the desc:) |
Contributor
|
@lgestc thanks for adding the description. I was originally confused because things were working normally for me until I realized I had to add a filter from the table row actions... I now tested it and the bug is fixed! I'm ready to approve, but I'm wondering why not doing a PR just for this fix. I don't think you need the first 8 commits and unless I missed something, there aren't any files modified in the last commit that would conflict with the first 8... |
This was referenced Apr 2, 2024
Closed
770e638 to
292b560
Compare
PhilippeOberti
approved these changes
Apr 2, 2024
Contributor
PhilippeOberti
left a comment
There was a problem hiding this comment.
code LGTM and desk tested, thanks for fixing this!!
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Apr 2, 2024
## Summary The following PR needs to be merged first: elastic#178701 This fixes elastic#174764 (comment) and elastic#179030 **To reproduce:** Add whatever filter in the Threat Intelligence (via table filter in), then click it (in the top bar) - filter edit popover is not filled in with data. On Alerts page though, it is filled in correctly - and it should look like that on TI:  (cherry picked from commit da69703)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
Contributor
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
lgestc
added a commit
to lgestc/kibana
that referenced
this pull request
Apr 9, 2024
## Summary The following PR needs to be merged first: elastic#178701 This fixes elastic#174764 (comment) and elastic#179030 **To reproduce:** Add whatever filter in the Threat Intelligence (via table filter in), then click it (in the top bar) - filter edit popover is not filled in with data. On Alerts page though, it is filled in correctly - and it should look like that on TI:  (cherry picked from commit da69703)
Contributor
Author
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
lgestc
added a commit
that referenced
this pull request
Apr 9, 2024
# Backport This will backport the following commits from `main` to `8.13`: - [Fix threat intel edit filters (#179607)](#179607) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Luke G","email":"11671118+lgestc@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-04-02T11:46:07Z","message":"Fix threat intel edit filters (#179607)\n\n## Summary\r\n\r\nThe following PR needs to be merged first:\r\nhttps://github.com//pull/178701\r\n\r\nThis fixes\r\nhttps://github.com//issues/174764#issuecomment-1992363217\r\nand https://github.com/elastic/kibana/issues/179030\r\n\r\n**To reproduce:**\r\n\r\nAdd whatever filter in the Threat Intelligence (via table filter in),\r\nthen click it (in the top bar) - filter edit popover is not filled in\r\nwith data.\r\n\r\nOn Alerts page though, it is filled in correctly - and it should look\r\nlike that on TI:\r\n\r\n\r\n","sha":"da697032c7ba74a2bba8338f64354cb6b0393ea5","branchLabelMapping":{"^v8.14.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","backport missing","Team:Threat Hunting:Investigations","backport:prev-minor","8.14 candidate","v8.14.0"],"number":179607,"url":"https://github.com/elastic/kibana/pull/179607","mergeCommit":{"message":"Fix threat intel edit filters (#179607)\n\n## Summary\r\n\r\nThe following PR needs to be merged first:\r\nhttps://github.com//pull/178701\r\n\r\nThis fixes\r\nhttps://github.com//issues/174764#issuecomment-1992363217\r\nand https://github.com/elastic/kibana/issues/179030\r\n\r\n**To reproduce:**\r\n\r\nAdd whatever filter in the Threat Intelligence (via table filter in),\r\nthen click it (in the top bar) - filter edit popover is not filled in\r\nwith data.\r\n\r\nOn Alerts page though, it is filled in correctly - and it should look\r\nlike that on TI:\r\n\r\n\r\n","sha":"da697032c7ba74a2bba8338f64354cb6b0393ea5"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.14.0","labelRegex":"^v8.14.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/179607","number":179607,"mergeCommit":{"message":"Fix threat intel edit filters (#179607)\n\n## Summary\r\n\r\nThe following PR needs to be merged first:\r\nhttps://github.com//pull/178701\r\n\r\nThis fixes\r\nhttps://github.com//issues/174764#issuecomment-1992363217\r\nand https://github.com/elastic/kibana/issues/179030\r\n\r\n**To reproduce:**\r\n\r\nAdd whatever filter in the Threat Intelligence (via table filter in),\r\nthen click it (in the top bar) - filter edit popover is not filled in\r\nwith data.\r\n\r\nOn Alerts page though, it is filled in correctly - and it should look\r\nlike that on TI:\r\n\r\n\r\n","sha":"da697032c7ba74a2bba8338f64354cb6b0393ea5"}}]}] BACKPORT-->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The following PR needs to be merged first: #178701
This fixes #174764 (comment) and #179030
To reproduce:
Add whatever filter in the Threat Intelligence (via table filter in), then click it (in the top bar) - filter edit popover is not filled in with data.
On Alerts page though, it is filled in correctly - and it should look like that on TI: