fix threat intelligence loading screen#178701
Merged
lgestc merged 14 commits intoelastic:mainfrom Apr 2, 2024
Merged
Conversation
Contributor
Author
|
/ci |
1a65692 to
b677807
Compare
Contributor
Author
|
/ci |
Contributor
|
Haven't looked at the code yet, but interestingly my on-week project is to re-enable all the Threat Intelligence Cypress tests, and they all fail at the moment because of one thing that you fix in this PR... Yup I can confirm that your fix fixes the bug I was seeing on Cypress and I spent most of my afternoon looking for!! 😆 Let me know when you move this out of draft so I can give it a proper review! Thanks! |
Contributor
|
@lgestc I don't know if it's related to this fix, but right now if I don't have any data, I'm seeing an empty screen, while before - if I remember correctly - we had an empty page component |
Contributor
Author
thanks, I will look into it. no data meaning enabled integration but no entries received from abusech for example? |
Contributor
Author
|
/ci |
Contributor
Author
|
/ci |
1 similar comment
Contributor
Author
|
/ci |
Contributor
Author
|
/ci |
Contributor
|
Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations) |
Contributor
PhilippeOberti
left a comment
There was a problem hiding this comment.
code LGTM and desk tested it looks fine. Let me know what you think about the couple of test-related comments I left, otherwise I'm ready to approve
x-pack/plugins/security_solution/public/app/home/template_wrapper/index.tsx
Show resolved
Hide resolved
x-pack/plugins/threat_intelligence/public/modules/empty_page/empty_page.tsx
Show resolved
Hide resolved
Contributor
Author
|
@PhilippeOberti more tests added |
PhilippeOberti
approved these changes
Mar 29, 2024
Contributor
PhilippeOberti
left a comment
There was a problem hiding this comment.
Love it, thanks! Code LGTM and tested!
💚 Build Succeeded
Metrics [docs]Async chunks
Public APIs missing exports
Page load bundle
History
To update your PR or re-run it, just comment with: |
Dosant
approved these changes
Apr 2, 2024
Contributor
Dosant
left a comment
There was a problem hiding this comment.
packages/shared-ux/page/kibana_template changes lgtm!
Contributor
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
lgestc
added a commit
that referenced
this pull request
Apr 2, 2024
## Summary The following PR needs to be merged first: #178701 This fixes #174764 (comment) and #179030 **To reproduce:** Add whatever filter in the Threat Intelligence (via table filter in), then click it (in the top bar) - filter edit popover is not filled in with data. On Alerts page though, it is filled in correctly - and it should look like that on TI: 
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Apr 2, 2024
## Summary The following PR needs to be merged first: elastic#178701 This fixes elastic#174764 (comment) and elastic#179030 **To reproduce:** Add whatever filter in the Threat Intelligence (via table filter in), then click it (in the top bar) - filter edit popover is not filled in with data. On Alerts page though, it is filled in correctly - and it should look like that on TI:  (cherry picked from commit da69703)
Contributor
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
1 similar comment
Contributor
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
Contributor
Author
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
lgestc
added a commit
to lgestc/kibana
that referenced
this pull request
Apr 9, 2024
## Summary This PR fixes custom empty page layout in Threat Intelligence page, and also optimizes some of the loading that happens during the init phase (integrations retrieval). **Before**  Broken api calls made:  **After**  ### Checklist (cherry picked from commit 4461b86) # Conflicts: # x-pack/plugins/security_solution/public/app/home/template_wrapper/index.tsx
lgestc
added a commit
that referenced
this pull request
Apr 9, 2024
# Backport This will backport the following commits from `main` to `8.13`: - [fix threat intelligence loading screen (#178701)](#178701) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Luke G","email":"11671118+lgestc@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-04-02T09:00:03Z","message":"fix threat intelligence loading screen (#178701)\n\n## Summary\r\n\r\nThis PR fixes custom empty page layout in Threat Intelligence page, and\r\nalso optimizes some of the loading that happens during the init phase\r\n(integrations retrieval).\r\n\r\n**Before**\r\n\r\n\r\n\r\nBroken api calls made:\r\n\r\n\r\n\r\n\r\n**After**\r\n\r\n\r\n\r\n\r\n\r\n### Checklist","sha":"4461b86a7fcb844cfbd7f158266c29f38b0f0d62","branchLabelMapping":{"^v8.14.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","backport missing","Team:Threat Hunting:Investigations","backport:prev-minor","v8.14.0"],"number":178701,"url":"https://github.com/elastic/kibana/pull/178701","mergeCommit":{"message":"fix threat intelligence loading screen (#178701)\n\n## Summary\r\n\r\nThis PR fixes custom empty page layout in Threat Intelligence page, and\r\nalso optimizes some of the loading that happens during the init phase\r\n(integrations retrieval).\r\n\r\n**Before**\r\n\r\n\r\n\r\nBroken api calls made:\r\n\r\n\r\n\r\n\r\n**After**\r\n\r\n\r\n\r\n\r\n\r\n### Checklist","sha":"4461b86a7fcb844cfbd7f158266c29f38b0f0d62"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.14.0","labelRegex":"^v8.14.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/178701","number":178701,"mergeCommit":{"message":"fix threat intelligence loading screen (#178701)\n\n## Summary\r\n\r\nThis PR fixes custom empty page layout in Threat Intelligence page, and\r\nalso optimizes some of the loading that happens during the init phase\r\n(integrations retrieval).\r\n\r\n**Before**\r\n\r\n\r\n\r\nBroken api calls made:\r\n\r\n\r\n\r\n\r\n**After**\r\n\r\n\r\n\r\n\r\n\r\n### Checklist","sha":"4461b86a7fcb844cfbd7f158266c29f38b0f0d62"}}]}] BACKPORT-->
lgestc
added a commit
to lgestc/kibana
that referenced
this pull request
Apr 9, 2024
## Summary The following PR needs to be merged first: elastic#178701 This fixes elastic#174764 (comment) and elastic#179030 **To reproduce:** Add whatever filter in the Threat Intelligence (via table filter in), then click it (in the top bar) - filter edit popover is not filled in with data. On Alerts page though, it is filled in correctly - and it should look like that on TI:  (cherry picked from commit da69703)
lgestc
added a commit
that referenced
this pull request
Apr 9, 2024
# Backport This will backport the following commits from `main` to `8.13`: - [Fix threat intel edit filters (#179607)](#179607) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Luke G","email":"11671118+lgestc@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-04-02T11:46:07Z","message":"Fix threat intel edit filters (#179607)\n\n## Summary\r\n\r\nThe following PR needs to be merged first:\r\nhttps://github.com//pull/178701\r\n\r\nThis fixes\r\nhttps://github.com//issues/174764#issuecomment-1992363217\r\nand https://github.com/elastic/kibana/issues/179030\r\n\r\n**To reproduce:**\r\n\r\nAdd whatever filter in the Threat Intelligence (via table filter in),\r\nthen click it (in the top bar) - filter edit popover is not filled in\r\nwith data.\r\n\r\nOn Alerts page though, it is filled in correctly - and it should look\r\nlike that on TI:\r\n\r\n\r\n","sha":"da697032c7ba74a2bba8338f64354cb6b0393ea5","branchLabelMapping":{"^v8.14.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","backport missing","Team:Threat Hunting:Investigations","backport:prev-minor","8.14 candidate","v8.14.0"],"number":179607,"url":"https://github.com/elastic/kibana/pull/179607","mergeCommit":{"message":"Fix threat intel edit filters (#179607)\n\n## Summary\r\n\r\nThe following PR needs to be merged first:\r\nhttps://github.com//pull/178701\r\n\r\nThis fixes\r\nhttps://github.com//issues/174764#issuecomment-1992363217\r\nand https://github.com/elastic/kibana/issues/179030\r\n\r\n**To reproduce:**\r\n\r\nAdd whatever filter in the Threat Intelligence (via table filter in),\r\nthen click it (in the top bar) - filter edit popover is not filled in\r\nwith data.\r\n\r\nOn Alerts page though, it is filled in correctly - and it should look\r\nlike that on TI:\r\n\r\n\r\n","sha":"da697032c7ba74a2bba8338f64354cb6b0393ea5"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.14.0","labelRegex":"^v8.14.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/179607","number":179607,"mergeCommit":{"message":"Fix threat intel edit filters (#179607)\n\n## Summary\r\n\r\nThe following PR needs to be merged first:\r\nhttps://github.com//pull/178701\r\n\r\nThis fixes\r\nhttps://github.com//issues/174764#issuecomment-1992363217\r\nand https://github.com/elastic/kibana/issues/179030\r\n\r\n**To reproduce:**\r\n\r\nAdd whatever filter in the Threat Intelligence (via table filter in),\r\nthen click it (in the top bar) - filter edit popover is not filled in\r\nwith data.\r\n\r\nOn Alerts page though, it is filled in correctly - and it should look\r\nlike that on TI:\r\n\r\n\r\n","sha":"da697032c7ba74a2bba8338f64354cb6b0393ea5"}}]}] BACKPORT-->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes custom empty page layout in Threat Intelligence page, and also optimizes some of the loading that happens during the init phase (integrations retrieval).
Before
Broken api calls made:
After
Checklist