Skip to content

[Fleet][Kafka] Topics without quotes#166236

Merged
szwarckonrad merged 10 commits intoelastic:mainfrom
szwarckonrad:fix-kafka-topics-validation
Sep 27, 2023
Merged

[Fleet][Kafka] Topics without quotes#166236
szwarckonrad merged 10 commits intoelastic:mainfrom
szwarckonrad:fix-kafka-topics-validation

Conversation

@szwarckonrad
Copy link
Copy Markdown
Contributor

@szwarckonrad szwarckonrad commented Sep 12, 2023

Closes #166135

Depends on elastic/ingest-docs#474

This PR adds:

  1. Subtitle under Topic Processors linking to docs
  2. Removes whitespace stripping from value in key:value topic pair.

Screenshot 2023-09-25 at 18 21 27

@szwarckonrad szwarckonrad added Team:Fleet Team label for Observability Data Collection Fleet team v8.10.0 labels Sep 12, 2023
@szwarckonrad szwarckonrad self-assigned this Sep 12, 2023
@szwarckonrad szwarckonrad added bug Fixes for quality problems that affect the customer experience v8.11.0 v8.10.3 release_note:skip Skip the PR/issue when compiling release notes and removed v8.10.0 labels Sep 25, 2023
@szwarckonrad szwarckonrad marked this pull request as ready for review September 25, 2023 16:25
@szwarckonrad szwarckonrad requested a review from a team as a code owner September 25, 2023 16:25
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/fleet (Team:Fleet)

@szwarckonrad szwarckonrad changed the title [DONT MERGE][Fleet][Kafka] Topics without quotes [Fleet][Kafka] Topics without quotes Sep 25, 2023
Copy link
Copy Markdown
Member

@kilfoyle kilfoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for the docs link!

Copy link
Copy Markdown
Member

@nchaulet nchaulet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@kibana-ci
Copy link
Copy Markdown

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #22 / serverless examples UI Partial Results Example "before all" hook for "should trace mouse events"

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 1.2MB 1.2MB +429.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @szwarckonrad

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Sep 27, 2023
Closes elastic#166135

Depends on elastic/ingest-docs#474

This PR adds:
1. Subtitle under Topic Processors linking to docs
2. Removes whitespace stripping from `value` in `key:value` topic pair.

![Screenshot 2023-09-25 at 18 21
27](https://github.com/elastic/kibana/assets/29123534/45d65502-1ebe-4b4d-bda7-6032e6f6dfd1)

(cherry picked from commit 2477e40)
@kibanamachine
Copy link
Copy Markdown
Contributor

💚 All backports created successfully

Status Branch Result
8.10

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Sep 27, 2023
# Backport

This will backport the following commits from `main` to `8.10`:
- [[Fleet][Kafka] Topics without quotes
(#166236)](#166236)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Konrad
Szwarc","email":"konrad.szwarc@elastic.co"},"sourceCommit":{"committedDate":"2023-09-27T09:53:54Z","message":"[Fleet][Kafka]
Topics without quotes (#166236)\n\nCloses
https://github.com/elastic/kibana/issues/166135\r\n\r\nDepends on
https://github.com/elastic/ingest-docs/pull/474\r\n\r\nThis PR
adds:\r\n1. Subtitle under Topic Processors linking to docs\r\n2.
Removes whitespace stripping from `value` in `key:value` topic
pair.\r\n\r\n![Screenshot 2023-09-25 at 18
21\r\n27](https://github.com/elastic/kibana/assets/29123534/45d65502-1ebe-4b4d-bda7-6032e6f6dfd1)","sha":"2477e40c850f9de5eb0e3031361f4018d790d002","branchLabelMapping":{"^v8.11.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","Team:Fleet","v8.11.0","v8.10.3"],"number":166236,"url":"https://github.com/elastic/kibana/pull/166236","mergeCommit":{"message":"[Fleet][Kafka]
Topics without quotes (#166236)\n\nCloses
https://github.com/elastic/kibana/issues/166135\r\n\r\nDepends on
https://github.com/elastic/ingest-docs/pull/474\r\n\r\nThis PR
adds:\r\n1. Subtitle under Topic Processors linking to docs\r\n2.
Removes whitespace stripping from `value` in `key:value` topic
pair.\r\n\r\n![Screenshot 2023-09-25 at 18
21\r\n27](https://github.com/elastic/kibana/assets/29123534/45d65502-1ebe-4b4d-bda7-6032e6f6dfd1)","sha":"2477e40c850f9de5eb0e3031361f4018d790d002"}},"sourceBranch":"main","suggestedTargetBranches":["8.10"],"targetPullRequestStates":[{"branch":"main","label":"v8.11.0","labelRegex":"^v8.11.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/166236","number":166236,"mergeCommit":{"message":"[Fleet][Kafka]
Topics without quotes (#166236)\n\nCloses
https://github.com/elastic/kibana/issues/166135\r\n\r\nDepends on
https://github.com/elastic/ingest-docs/pull/474\r\n\r\nThis PR
adds:\r\n1. Subtitle under Topic Processors linking to docs\r\n2.
Removes whitespace stripping from `value` in `key:value` topic
pair.\r\n\r\n![Screenshot 2023-09-25 at 18
21\r\n27](https://github.com/elastic/kibana/assets/29123534/45d65502-1ebe-4b4d-bda7-6032e6f6dfd1)","sha":"2477e40c850f9de5eb0e3031361f4018d790d002"}},{"branch":"8.10","label":"v8.10.3","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Konrad Szwarc <konrad.szwarc@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.10.3 v8.11.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Fleet]: No data under Dynamic topic processor if added the key values with quotes.

7 participants