Add warning about quotation marks to Kafka output docs#474
Merged
kilfoyle merged 4 commits intoelastic:mainfrom Sep 25, 2023
Merged
Add warning about quotation marks to Kafka output docs#474kilfoyle merged 4 commits intoelastic:mainfrom
kilfoyle merged 4 commits intoelastic:mainfrom
Conversation
jlind23
approved these changes
Sep 11, 2023
mergify bot
pushed a commit
that referenced
this pull request
Sep 25, 2023
* Add warning about quotes and spaces to Kafka output docs * Move note to the processors section * Update message to indicate that quotation marks are included in the match * fixup (cherry picked from commit a7f8eed)
kilfoyle
added a commit
that referenced
this pull request
Sep 25, 2023
* Add warning about quotes and spaces to Kafka output docs * Move note to the processors section * Update message to indicate that quotation marks are included in the match * fixup (cherry picked from commit a7f8eed) Co-authored-by: David Kilfoyle <41695641+kilfoyle@users.noreply.github.com>
szwarckonrad
added a commit
to elastic/kibana
that referenced
this pull request
Sep 27, 2023
Closes #166135 Depends on elastic/ingest-docs#474 This PR adds: 1. Subtitle under Topic Processors linking to docs 2. Removes whitespace stripping from `value` in `key:value` topic pair. 
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 27, 2023
Closes elastic#166135 Depends on elastic/ingest-docs#474 This PR adds: 1. Subtitle under Topic Processors linking to docs 2. Removes whitespace stripping from `value` in `key:value` topic pair.  (cherry picked from commit 2477e40)
kibanamachine
referenced
this pull request
in elastic/kibana
Sep 27, 2023
# Backport This will backport the following commits from `main` to `8.10`: - [[Fleet][Kafka] Topics without quotes (#166236)](#166236) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Konrad Szwarc","email":"konrad.szwarc@elastic.co"},"sourceCommit":{"committedDate":"2023-09-27T09:53:54Z","message":"[Fleet][Kafka] Topics without quotes (#166236)\n\nCloses https://github.com/elastic/kibana/issues/166135\r\n\r\nDepends on https://github.com/elastic/ingest-docs/pull/474\r\n\r\nThis PR adds:\r\n1. Subtitle under Topic Processors linking to docs\r\n2. Removes whitespace stripping from `value` in `key:value` topic pair.\r\n\r\n","sha":"2477e40c850f9de5eb0e3031361f4018d790d002","branchLabelMapping":{"^v8.11.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","Team:Fleet","v8.11.0","v8.10.3"],"number":166236,"url":"https://github.com/elastic/kibana/pull/166236","mergeCommit":{"message":"[Fleet][Kafka] Topics without quotes (#166236)\n\nCloses https://github.com/elastic/kibana/issues/166135\r\n\r\nDepends on https://github.com/elastic/ingest-docs/pull/474\r\n\r\nThis PR adds:\r\n1. Subtitle under Topic Processors linking to docs\r\n2. Removes whitespace stripping from `value` in `key:value` topic pair.\r\n\r\n","sha":"2477e40c850f9de5eb0e3031361f4018d790d002"}},"sourceBranch":"main","suggestedTargetBranches":["8.10"],"targetPullRequestStates":[{"branch":"main","label":"v8.11.0","labelRegex":"^v8.11.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/166236","number":166236,"mergeCommit":{"message":"[Fleet][Kafka] Topics without quotes (#166236)\n\nCloses https://github.com/elastic/kibana/issues/166135\r\n\r\nDepends on https://github.com/elastic/ingest-docs/pull/474\r\n\r\nThis PR adds:\r\n1. Subtitle under Topic Processors linking to docs\r\n2. Removes whitespace stripping from `value` in `key:value` topic pair.\r\n\r\n","sha":"2477e40c850f9de5eb0e3031361f4018d790d002"}},{"branch":"8.10","label":"v8.10.3","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Konrad Szwarc <konrad.szwarc@elastic.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the following highlighted note to the Kafka output settings UI documentation.
Rel: elastic/kibana#166135