[Enterprise Search] fix: try in console links for code box#164766
Merged
TattdCodeMonkey merged 1 commit intoelastic:mainfrom Aug 25, 2023
Merged
Conversation
💚 Build Succeeded
Metrics [docs]Module Count
Public APIs missing comments
Async chunks
To update your PR or re-run it, just comment with: |
efegurkan
approved these changes
Aug 25, 2023
Contributor
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
TattdCodeMonkey
added a commit
to TattdCodeMonkey/kibana
that referenced
this pull request
Aug 25, 2023
…64766) ## Summary Fixed the Code box component to take the console request instead of re-using the code snippet which is specific for the language and won't work in our dev console. Since the console snippets are the same I moved it to the shared project so it can be used by both dedicated and serverless. (cherry picked from commit 5136714)
Contributor
Author
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
TattdCodeMonkey
added a commit
that referenced
this pull request
Aug 25, 2023
…64766) (#164868) # Backport This will backport the following commits from `main` to `8.10`: - [[Enterprise Search] fix: try in console links for code box (#164766)](#164766) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Rodney Norris","email":"rodney.norris@elastic.co"},"sourceCommit":{"committedDate":"2023-08-25T14:12:17Z","message":"[Enterprise Search] fix: try in console links for code box (#164766)\n\n## Summary\r\n\r\nFixed the Code box component to take the console request instead of\r\nre-using the code snippet which is specific for the language and won't\r\nwork in our dev console.\r\n\r\nSince the console snippets are the same I moved it to the shared project\r\nso it can be used by both dedicated and serverless.","sha":"5136714f6fcd0992c275cd63b9b72bcb9d285008","branchLabelMapping":{"^v8.11.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["backport","release_note:skip","Team:EnterpriseSearch","v8.10.0","v8.11.0"],"number":164766,"url":"https://github.com/elastic/kibana/pull/164766","mergeCommit":{"message":"[Enterprise Search] fix: try in console links for code box (#164766)\n\n## Summary\r\n\r\nFixed the Code box component to take the console request instead of\r\nre-using the code snippet which is specific for the language and won't\r\nwork in our dev console.\r\n\r\nSince the console snippets are the same I moved it to the shared project\r\nso it can be used by both dedicated and serverless.","sha":"5136714f6fcd0992c275cd63b9b72bcb9d285008"}},"sourceBranch":"main","suggestedTargetBranches":["8.10"],"targetPullRequestStates":[{"branch":"8.10","label":"v8.10.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.11.0","labelRegex":"^v8.11.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/164766","number":164766,"mergeCommit":{"message":"[Enterprise Search] fix: try in console links for code box (#164766)\n\n## Summary\r\n\r\nFixed the Code box component to take the console request instead of\r\nre-using the code snippet which is specific for the language and won't\r\nwork in our dev console.\r\n\r\nSince the console snippets are the same I moved it to the shared project\r\nso it can be used by both dedicated and serverless.","sha":"5136714f6fcd0992c275cd63b9b72bcb9d285008"}}]}] BACKPORT-->
This was referenced Oct 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixed the Code box component to take the console request instead of re-using the code snippet which is specific for the language and won't work in our dev console.
Since the console snippets are the same I moved it to the shared project so it can be used by both dedicated and serverless.