Skip to content

[Enterprise Search] fix: try in console links for code box#164766

Merged
TattdCodeMonkey merged 1 commit intoelastic:mainfrom
TattdCodeMonkey:rnorris/fix/code-box-console-requests
Aug 25, 2023
Merged

[Enterprise Search] fix: try in console links for code box#164766
TattdCodeMonkey merged 1 commit intoelastic:mainfrom
TattdCodeMonkey:rnorris/fix/code-box-console-requests

Conversation

@TattdCodeMonkey
Copy link
Copy Markdown
Contributor

@TattdCodeMonkey TattdCodeMonkey commented Aug 24, 2023

Summary

Fixed the Code box component to take the console request instead of re-using the code snippet which is specific for the language and won't work in our dev console.

Since the console snippets are the same I moved it to the shared project so it can be used by both dedicated and serverless.

@TattdCodeMonkey TattdCodeMonkey added backport This PR is a backport of another PR release_note:skip Skip the PR/issue when compiling release notes Team:EnterpriseSearch v8.10.0 v8.11.0 labels Aug 24, 2023
@TattdCodeMonkey TattdCodeMonkey requested a review from a team August 24, 2023 17:54
@kibana-ci
Copy link
Copy Markdown

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
enterpriseSearch 2215 2214 -1
serverlessSearch 115 114 -1
total -2

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/search-api-panels 63 65 +2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
enterpriseSearch 2.6MB 2.6MB +109.0B
serverlessSearch 88.5KB 88.3KB -191.0B
total -82.0B
Unknown metric groups

API count

id before after diff
@kbn/search-api-panels 63 65 +2

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@TattdCodeMonkey TattdCodeMonkey merged commit 5136714 into elastic:main Aug 25, 2023
@TattdCodeMonkey TattdCodeMonkey deleted the rnorris/fix/code-box-console-requests branch August 25, 2023 14:12
@kibanamachine
Copy link
Copy Markdown
Contributor

💔 All backports failed

Status Branch Result
8.10 Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 164766

Questions ?

Please refer to the Backport tool documentation

TattdCodeMonkey added a commit to TattdCodeMonkey/kibana that referenced this pull request Aug 25, 2023
…64766)

## Summary

Fixed the Code box component to take the console request instead of
re-using the code snippet which is specific for the language and won't
work in our dev console.

Since the console snippets are the same I moved it to the shared project
so it can be used by both dedicated and serverless.

(cherry picked from commit 5136714)
@TattdCodeMonkey
Copy link
Copy Markdown
Contributor Author

💚 All backports created successfully

Status Branch Result
8.10

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

TattdCodeMonkey added a commit that referenced this pull request Aug 25, 2023
…64766) (#164868)

# Backport

This will backport the following commits from `main` to `8.10`:
- [[Enterprise Search] fix: try in console links for code box
(#164766)](#164766)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Rodney
Norris","email":"rodney.norris@elastic.co"},"sourceCommit":{"committedDate":"2023-08-25T14:12:17Z","message":"[Enterprise
Search] fix: try in console links for code box (#164766)\n\n##
Summary\r\n\r\nFixed the Code box component to take the console request
instead of\r\nre-using the code snippet which is specific for the
language and won't\r\nwork in our dev console.\r\n\r\nSince the console
snippets are the same I moved it to the shared project\r\nso it can be
used by both dedicated and
serverless.","sha":"5136714f6fcd0992c275cd63b9b72bcb9d285008","branchLabelMapping":{"^v8.11.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["backport","release_note:skip","Team:EnterpriseSearch","v8.10.0","v8.11.0"],"number":164766,"url":"https://github.com/elastic/kibana/pull/164766","mergeCommit":{"message":"[Enterprise
Search] fix: try in console links for code box (#164766)\n\n##
Summary\r\n\r\nFixed the Code box component to take the console request
instead of\r\nre-using the code snippet which is specific for the
language and won't\r\nwork in our dev console.\r\n\r\nSince the console
snippets are the same I moved it to the shared project\r\nso it can be
used by both dedicated and
serverless.","sha":"5136714f6fcd0992c275cd63b9b72bcb9d285008"}},"sourceBranch":"main","suggestedTargetBranches":["8.10"],"targetPullRequestStates":[{"branch":"8.10","label":"v8.10.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.11.0","labelRegex":"^v8.11.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/164766","number":164766,"mergeCommit":{"message":"[Enterprise
Search] fix: try in console links for code box (#164766)\n\n##
Summary\r\n\r\nFixed the Code box component to take the console request
instead of\r\nre-using the code snippet which is specific for the
language and won't\r\nwork in our dev console.\r\n\r\nSince the console
snippets are the same I moved it to the shared project\r\nso it can be
used by both dedicated and
serverless.","sha":"5136714f6fcd0992c275cd63b9b72bcb9d285008"}}]}]
BACKPORT-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR release_note:skip Skip the PR/issue when compiling release notes Team:EnterpriseSearch v8.10.0 v8.11.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants