Skip to content

[8.10] [Enterprise Search] fix: try in console links for code box (#164766)#164868

Merged
TattdCodeMonkey merged 1 commit intoelastic:8.10from
TattdCodeMonkey:backport/8.10/pr-164766
Aug 25, 2023
Merged

[8.10] [Enterprise Search] fix: try in console links for code box (#164766)#164868
TattdCodeMonkey merged 1 commit intoelastic:8.10from
TattdCodeMonkey:backport/8.10/pr-164766

Conversation

@TattdCodeMonkey
Copy link
Copy Markdown
Contributor

@TattdCodeMonkey TattdCodeMonkey commented Aug 25, 2023

Backport

This will backport the following commits from main to 8.10:

Questions ?

Please refer to the Backport tool documentation

@TattdCodeMonkey
[Enterprise Search] fix: try in console links for code box (elastic#1…
dfd3dab 
…64766)

## Summary

Fixed the Code box component to take the console request instead of
re-using the code snippet which is specific for the language and won't
work in our dev console.

Since the console snippets are the same I moved it to the shared project
so it can be used by both dedicated and serverless.

(cherry picked from commit 5136714)
@TattdCodeMonkey TattdCodeMonkey added the backport This PR is a backport of another PR label Aug 25, 2023
@TattdCodeMonkey TattdCodeMonkey enabled auto-merge (squash) August 25, 2023 16:30
@TattdCodeMonkey TattdCodeMonkey mentioned this pull request Aug 25, 2023
Merged
@TattdCodeMonkey TattdCodeMonkey merged commit 90529f8 into elastic:8.10 Aug 25, 2023
@kibana-ci
Copy link
Copy Markdown

kibana-ci commented Aug 25, 2023

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
enterpriseSearch 2212 2211 -1
serverlessSearch 99 98 -1
total -2

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/search-api-panels 63 65 +2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
enterpriseSearch 2.6MB 2.6MB +109.0B
serverlessSearch 73.2KB 73.0KB -191.0B
total -82.0B
Unknown metric groups

API count

id before after diff
@kbn/search-api-panels 63 65 +2

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

This was referenced Oct 1, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joemcelroy joemcelroy joemcelroy approved these changes

Assignees

No one assigned

Labels

backport This PR is a backport of another PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@TattdCodeMonkey @kibana-ci @joemcelroy