Skip to content

[Security Solution] [Detections] Fixes flakey exceptions read-only viewer cypress test#164283

Merged
e40pud merged 5 commits intoelastic:mainfrom
e40pud:security/tests/162839-exceptions-read-only-view
Aug 21, 2023
Merged

[Security Solution] [Detections] Fixes flakey exceptions read-only viewer cypress test#164283
e40pud merged 5 commits intoelastic:mainfrom
e40pud:security/tests/162839-exceptions-read-only-view

Conversation

@e40pud
Copy link
Copy Markdown
Contributor

@e40pud e40pud commented Aug 21, 2023

Summary

Fixes: #162569
Fixes: #164061
Fixes: #164058
Fixes: #163546
Fixes: #162669

We tried to fix the issue with this PR #162839 but test failed again.

This is another attempt to fix it using the @jpdjere's approach where we disable rule's table refreshing (#163698).

@e40pud e40pud added release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Detection Engine Security Solution Detection Engine Area labels Aug 21, 2023
@e40pud e40pud self-assigned this Aug 21, 2023
@e40pud e40pud marked this pull request as ready for review August 21, 2023 13:03
@e40pud e40pud requested a review from a team as a code owner August 21, 2023 13:03
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@e40pud e40pud requested a review from dhurley14 August 21, 2023 13:03
@e40pud e40pud added the v8.10.0 label Aug 21, 2023
@e40pud e40pud requested a review from WafaaNasr August 21, 2023 16:32
Copy link
Copy Markdown
Contributor

@WafaaNasr WafaaNasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting! LGTM

@kibana-ci
Copy link
Copy Markdown

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Defend Workflows Endpoint Cypress Tests #5 / Isolate command From cases should isolate and release host should isolate and release host

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @e40pud

@kibanamachine
Copy link
Copy Markdown
Contributor

💚 All backports created successfully

Status Branch Result
8.10

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Aug 21, 2023
…ewer cypress test (elastic#164283)

## Summary

Fixes: elastic#162569
Fixes: elastic#164061
Fixes: elastic#164058
Fixes: elastic#163546
Fixes: elastic#162669

We tried to fix the issue with this PR
elastic#162839 but test failed again.

This is another attempt to fix it using the @jpdjere's approach where we
disable rule's table refreshing
(elastic#163698).

(cherry picked from commit 4477f64)
kibanamachine added a commit that referenced this pull request Aug 21, 2023
…only viewer cypress test (#164283) (#164346)

# Backport

This will backport the following commits from `main` to `8.10`:
- [[Security Solution] [Detections] Fixes flakey exceptions read-only
viewer cypress test
(#164283)](#164283)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Ievgen
Sorokopud","email":"ievgen.sorokopud@elastic.co"},"sourceCommit":{"committedDate":"2023-08-21T18:40:14Z","message":"[Security
Solution] [Detections] Fixes flakey exceptions read-only viewer cypress
test (#164283)\n\n## Summary\r\n\r\nFixes:
https://github.com/elastic/kibana/issues/162569\r\nFixes:
https://github.com/elastic/kibana/issues/164061\r\nFixes:
https://github.com/elastic/kibana/issues/164058\r\nFixes:
https://github.com/elastic/kibana/issues/163546\r\nFixes:
https://github.com/elastic/kibana/issues/162669\r\n\r\nWe tried to fix
the issue with this PR\r\nhttps://github.com//pull/162839
but test failed again.\r\n\r\nThis is another attempt to fix it using
the @jpdjere's approach where we\r\ndisable rule's table
refreshing\r\n(https://github.com/elastic/kibana/pull/163698).","sha":"4477f642e3297355ef676dcf485efb0cb49c4fcb","branchLabelMapping":{"^v8.11.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:
SecuritySolution","Team:Detection
Engine","v8.10.0","v8.11.0"],"number":164283,"url":"https://github.com/elastic/kibana/pull/164283","mergeCommit":{"message":"[Security
Solution] [Detections] Fixes flakey exceptions read-only viewer cypress
test (#164283)\n\n## Summary\r\n\r\nFixes:
https://github.com/elastic/kibana/issues/162569\r\nFixes:
https://github.com/elastic/kibana/issues/164061\r\nFixes:
https://github.com/elastic/kibana/issues/164058\r\nFixes:
https://github.com/elastic/kibana/issues/163546\r\nFixes:
https://github.com/elastic/kibana/issues/162669\r\n\r\nWe tried to fix
the issue with this PR\r\nhttps://github.com//pull/162839
but test failed again.\r\n\r\nThis is another attempt to fix it using
the @jpdjere's approach where we\r\ndisable rule's table
refreshing\r\n(https://github.com/elastic/kibana/pull/163698).","sha":"4477f642e3297355ef676dcf485efb0cb49c4fcb"}},"sourceBranch":"main","suggestedTargetBranches":["8.10"],"targetPullRequestStates":[{"branch":"8.10","label":"v8.10.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.11.0","labelRegex":"^v8.11.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/164283","number":164283,"mergeCommit":{"message":"[Security
Solution] [Detections] Fixes flakey exceptions read-only viewer cypress
test (#164283)\n\n## Summary\r\n\r\nFixes:
https://github.com/elastic/kibana/issues/162569\r\nFixes:
https://github.com/elastic/kibana/issues/164061\r\nFixes:
https://github.com/elastic/kibana/issues/164058\r\nFixes:
https://github.com/elastic/kibana/issues/163546\r\nFixes:
https://github.com/elastic/kibana/issues/162669\r\n\r\nWe tried to fix
the issue with this PR\r\nhttps://github.com//pull/162839
but test failed again.\r\n\r\nThis is another attempt to fix it using
the @jpdjere's approach where we\r\ndisable rule's table
refreshing\r\n(https://github.com/elastic/kibana/pull/163698).","sha":"4477f642e3297355ef676dcf485efb0cb49c4fcb"}}]}]
BACKPORT-->

Co-authored-by: Ievgen Sorokopud <ievgen.sorokopud@elastic.co>
e40pud added a commit to e40pud/kibana that referenced this pull request Aug 21, 2023
…ewer cypress test (elastic#164283)

## Summary

Fixes: elastic#162569
Fixes: elastic#164061
Fixes: elastic#164058
Fixes: elastic#163546
Fixes: elastic#162669

We tried to fix the issue with this PR
elastic#162839 but test failed again.

This is another attempt to fix it using the @jpdjere's approach where we
disable rule's table refreshing
(elastic#163698).

(cherry picked from commit 4477f64)
@e40pud
Copy link
Copy Markdown
Contributor Author

e40pud commented Aug 21, 2023

💚 All backports created successfully

Status Branch Result
8.9

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

e40pud added a commit that referenced this pull request Aug 22, 2023
…nly viewer cypress test (#164283) (#164352)

# Backport

This will backport the following commits from `main` to `8.9`:
- [[Security Solution] [Detections] Fixes flakey exceptions read-only
viewer cypress test
(#164283)](#164283)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Ievgen
Sorokopud","email":"ievgen.sorokopud@elastic.co"},"sourceCommit":{"committedDate":"2023-08-21T18:40:14Z","message":"[Security
Solution] [Detections] Fixes flakey exceptions read-only viewer cypress
test (#164283)\n\n## Summary\r\n\r\nFixes:
https://github.com/elastic/kibana/issues/162569\r\nFixes:
https://github.com/elastic/kibana/issues/164061\r\nFixes:
https://github.com/elastic/kibana/issues/164058\r\nFixes:
https://github.com/elastic/kibana/issues/163546\r\nFixes:
https://github.com/elastic/kibana/issues/162669\r\n\r\nWe tried to fix
the issue with this PR\r\nhttps://github.com//pull/162839
but test failed again.\r\n\r\nThis is another attempt to fix it using
the @jpdjere's approach where we\r\ndisable rule's table
refreshing\r\n(https://github.com/elastic/kibana/pull/163698).","sha":"4477f642e3297355ef676dcf485efb0cb49c4fcb","branchLabelMapping":{"^v8.11.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:
SecuritySolution","Team:Detection
Engine","v8.10.0","v8.11.0"],"number":164283,"url":"https://github.com/elastic/kibana/pull/164283","mergeCommit":{"message":"[Security
Solution] [Detections] Fixes flakey exceptions read-only viewer cypress
test (#164283)\n\n## Summary\r\n\r\nFixes:
https://github.com/elastic/kibana/issues/162569\r\nFixes:
https://github.com/elastic/kibana/issues/164061\r\nFixes:
https://github.com/elastic/kibana/issues/164058\r\nFixes:
https://github.com/elastic/kibana/issues/163546\r\nFixes:
https://github.com/elastic/kibana/issues/162669\r\n\r\nWe tried to fix
the issue with this PR\r\nhttps://github.com//pull/162839
but test failed again.\r\n\r\nThis is another attempt to fix it using
the @jpdjere's approach where we\r\ndisable rule's table
refreshing\r\n(https://github.com/elastic/kibana/pull/163698).","sha":"4477f642e3297355ef676dcf485efb0cb49c4fcb"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"8.10","label":"v8.10.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/164346","number":164346,"state":"MERGED","mergeCommit":{"sha":"bdbc3e7e0e7cf59397af3653ed2f8ba86bd3ea93","message":"[8.10]
[Security Solution] [Detections] Fixes flakey exceptions read-only
viewer cypress test (#164283) (#164346)\n\n# Backport\n\nThis will
backport the following commits from `main` to `8.10`:\n- [[Security
Solution] [Detections] Fixes flakey exceptions read-only\nviewer cypress
test\n(#164283)](https://github.com/elastic/kibana/pull/164283)\n\n<!---
Backport version: 8.9.7 -->\n\n### Questions ?\nPlease refer to the
[Backport
tool\ndocumentation](https://github.com/sqren/backport)\n\n<!--BACKPORT
[{\"author\":{\"name\":\"Ievgen\nSorokopud\",\"email\":\"ievgen.sorokopud@elastic.co\"},\"sourceCommit\":{\"committedDate\":\"2023-08-21T18:40:14Z\",\"message\":\"[Security\nSolution]
[Detections] Fixes flakey exceptions read-only viewer cypress\ntest
(#164283)\\n\\n##
Summary\\r\\n\\r\\nFixes:\nhttps://github.com//issues/162569\\r\\nFixes:\nhttps://github.com//issues/164061\\r\\nFixes:\nhttps://github.com//issues/164058\\r\\nFixes:\nhttps://github.com//issues/163546\\r\\nFixes:\nhttps://github.com//issues/162669\\r\\n\\r\\nWe
tried to fix\nthe issue with this
PR\\r\\nhttps://github.com//pull/162839\nbut test failed
again.\\r\\n\\r\\nThis is another attempt to fix it using\nthe
@jpdjere's approach where we\\r\\ndisable rule's
table\nrefreshing\\r\\n(https://github.com/elastic/kibana/pull/163698).\",\"sha\":\"4477f642e3297355ef676dcf485efb0cb49c4fcb\",\"branchLabelMapping\":{\"^v8.11.0$\":\"main\",\"^v(\\\\d+).(\\\\d+).\\\\d+$\":\"$1.$2\"}},\"sourcePullRequest\":{\"labels\":[\"release_note:skip\",\"Team:\nSecuritySolution\",\"Team:Detection\nEngine\",\"v8.10.0\",\"v8.11.0\"],\"number\":164283,\"url\":\"https://github.com/elastic/kibana/pull/164283\",\"mergeCommit\":{\"message\":\"[Security\nSolution]
[Detections] Fixes flakey exceptions read-only viewer cypress\ntest
(#164283)\\n\\n##
Summary\\r\\n\\r\\nFixes:\nhttps://github.com//issues/162569\\r\\nFixes:\nhttps://github.com//issues/164061\\r\\nFixes:\nhttps://github.com//issues/164058\\r\\nFixes:\nhttps://github.com//issues/163546\\r\\nFixes:\nhttps://github.com//issues/162669\\r\\n\\r\\nWe
tried to fix\nthe issue with this
PR\\r\\nhttps://github.com//pull/162839\nbut test failed
again.\\r\\n\\r\\nThis is another attempt to fix it using\nthe
@jpdjere's approach where we\\r\\ndisable rule's
table\nrefreshing\\r\\n(https://github.com/elastic/kibana/pull/163698).\",\"sha\":\"4477f642e3297355ef676dcf485efb0cb49c4fcb\"}},\"sourceBranch\":\"main\",\"suggestedTargetBranches\":[\"8.10\"],\"targetPullRequestStates\":[{\"branch\":\"8.10\",\"label\":\"v8.10.0\",\"labelRegex\":\"^v(\\\\d+).(\\\\d+).\\\\d+$\",\"isSourceBranch\":false,\"state\":\"NOT_CREATED\"},{\"branch\":\"main\",\"label\":\"v8.11.0\",\"labelRegex\":\"^v8.11.0$\",\"isSourceBranch\":true,\"state\":\"MERGED\",\"url\":\"https://github.com/elastic/kibana/pull/164283\",\"number\":164283,\"mergeCommit\":{\"message\":\"[Security\nSolution]
[Detections] Fixes flakey exceptions read-only viewer cypress\ntest
(#164283)\\n\\n##
Summary\\r\\n\\r\\nFixes:\nhttps://github.com//issues/162569\\r\\nFixes:\nhttps://github.com//issues/164061\\r\\nFixes:\nhttps://github.com//issues/164058\\r\\nFixes:\nhttps://github.com//issues/163546\\r\\nFixes:\nhttps://github.com//issues/162669\\r\\n\\r\\nWe
tried to fix\nthe issue with this
PR\\r\\nhttps://github.com//pull/162839\nbut test failed
again.\\r\\n\\r\\nThis is another attempt to fix it using\nthe
@jpdjere's approach where we\\r\\ndisable rule's
table\nrefreshing\\r\\n(https://github.com/elastic/kibana/pull/163698).\",\"sha\":\"4477f642e3297355ef676dcf485efb0cb49c4fcb\"}}]}]\nBACKPORT-->\n\nCo-authored-by:
Ievgen Sorokopud
<ievgen.sorokopud@elastic.co>"}},{"branch":"main","label":"v8.11.0","labelRegex":"^v8.11.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/164283","number":164283,"mergeCommit":{"message":"[Security
Solution] [Detections] Fixes flakey exceptions read-only viewer cypress
test (#164283)\n\n## Summary\r\n\r\nFixes:
https://github.com/elastic/kibana/issues/162569\r\nFixes:
https://github.com/elastic/kibana/issues/164061\r\nFixes:
https://github.com/elastic/kibana/issues/164058\r\nFixes:
https://github.com/elastic/kibana/issues/163546\r\nFixes:
https://github.com/elastic/kibana/issues/162669\r\n\r\nWe tried to fix
the issue with this PR\r\nhttps://github.com//pull/162839
but test failed again.\r\n\r\nThis is another attempt to fix it using
the @jpdjere's approach where we\r\ndisable rule's table
refreshing\r\n(https://github.com/elastic/kibana/pull/163698).","sha":"4477f642e3297355ef676dcf485efb0cb49c4fcb"}}]}]
BACKPORT-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release_note:skip Skip the PR/issue when compiling release notes Team:Detection Engine Security Solution Detection Engine Area Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.9.2 v8.10.0 v8.11.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Failing test: Security Solution Cypress.x-pack/test/security_solution_cypress/cypress/e2e/exceptions/rule_details_flow/read_only_view·cy·ts - Exceptions viewer read only "before each" hook for "Cannot add an exception from empty viewer screen" "before each" hook for "Cannot add an exception from empty viewer screen" Failing test: Security Solution Cypress.x-pack/test/security_solution_cypress/cypress/e2e/exceptions/rule_details_flow/read_only_view·cy·ts - Exceptions viewer read only "before each" hook for "Cannot take actions on exception" "before each" hook for "Cannot take actions on exception" Failing test: Security Solution Cypress.x-pack/plugins/security_solution/cypress/e2e/exceptions/rule_details_flow/read_only_view·cy·ts - Exceptions viewer read only "before each" hook for "Cannot add an exception from empty viewer screen" "before each" hook for "Cannot add an exception from empty viewer screen" Failing test: Security Solution Cypress.x-pack/plugins/security_solution/cypress/e2e/exceptions/rule_details_flow/read_only_view·cy·ts - Exceptions viewer read only "before each" hook for "Cannot take actions on exception" "before each" hook for "Cannot take actions on exception" [Security Solution] [Flaky test] [Exceptions] Fix flakiness of x-pack/plugins/security_solution/cypress/e2e/exceptions/rule_details_flow/read_only_view·cy·ts

5 participants