Skip to content

[8.9] [Security Solution] [Detections] Fixes flakey exceptions read-only viewer cypress test (#164283)#164352

Merged
e40pud merged 1 commit intoelastic:8.9from
e40pud:backport/8.9/pr-164283
Aug 22, 2023
Merged

[8.9] [Security Solution] [Detections] Fixes flakey exceptions read-only viewer cypress test (#164283)#164352
e40pud merged 1 commit intoelastic:8.9from
e40pud:backport/8.9/pr-164283

Conversation

@e40pud
Copy link
Copy Markdown
Contributor

@e40pud e40pud commented Aug 21, 2023

Backport

This will backport the following commits from main to 8.9:

Questions ?

Please refer to the Backport tool documentation

\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sqren/backport)\n\n\n\nCo-authored-by: Ievgen Sorokopud "}},{"branch":"main","label":"v8.11.0","labelRegex":"^v8.11.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com//pull/164283","number":164283,"mergeCommit":{"message":"[Security Solution] [Detections] Fixes flakey exceptions read-only viewer cypress test (#164283)\n\n## Summary\r\n\r\nFixes: https://github.com//issues/162569\r\nFixes: https://github.com//issues/164061\r\nFixes: https://github.com//issues/164058\r\nFixes: https://github.com//issues/163546\r\nFixes: https://github.com//issues/162669\r\n\r\nWe tried to fix the issue with this PR\r\nhttps://github.com//pull/162839 but test failed again.\r\n\r\nThis is another attempt to fix it using the @jpdjere's approach where we\r\ndisable rule's table refreshing\r\n(https://github.com//pull/163698).","sha":"4477f642e3297355ef676dcf485efb0cb49c4fcb"}}]}] BACKPORT-->

…ewer cypress test (elastic#164283)

## Summary

Fixes: elastic#162569
Fixes: elastic#164061
Fixes: elastic#164058
Fixes: elastic#163546
Fixes: elastic#162669

We tried to fix the issue with this PR
elastic#162839 but test failed again.

This is another attempt to fix it using the @jpdjere's approach where we
disable rule's table refreshing
(elastic#163698).

(cherry picked from commit 4477f64)
@e40pud e40pud added the backport This PR is a backport of another PR label Aug 21, 2023
@e40pud e40pud enabled auto-merge (squash) August 21, 2023 19:07
@kibana-ci
Copy link
Copy Markdown

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Security Solution Tests #5 / Detection rules, Prebuilt Rules Installation and Update Notifications Notifications Rule installation available and rule update available notifications should notify user about prebuilt rules available for installation and for upgrade

Metrics [docs]

Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 13 15 +2
securitySolution 416 420 +4
total +6

Total ESLint disabled count

id before after diff
enterpriseSearch 14 16 +2
securitySolution 497 501 +4
total +6

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Copy Markdown
Contributor

@WafaaNasr WafaaNasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@e40pud e40pud merged commit 653a0d7 into elastic:8.9 Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants