Failing ES Promotion: FTR Configs #22 / detection engine api security and spaces enabled - rule execution logic Non ECS fields in alert document source should fail creating alert when ECS field mapping is geo_point#162247
Merged
e40pud merged 2 commits intoelastic:mainfrom Jul 20, 2023
Conversation
…ecurity and spaces enabled - rule execution logic Non ECS fields in alert document source should fail creating alert when ECS field mapping is geo_point (elastic#154277)
Contributor
Author
|
@vitaliidm added you as a reviewer as well since you worked on these tests recently. |
Contributor
Author
|
Run 100 times through flaky test runner. |
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: cc @e40pud |
ThomThomson
pushed a commit
to ThomThomson/kibana
that referenced
this pull request
Aug 1, 2023
… and spaces enabled - rule execution logic Non ECS fields in alert document source should fail creating alert when ECS field mapping is geo_point (elastic#162247) ## Summary Failing tests ticket: elastic#154277 This PR fixes the non ECS fields in alert document source failing tests. There are two failing tests: 1. `should remove source array of keywords field from alert if ECS field mapping is nested` was filing due to wrong key path format passed to jest's `toHaveProperty`. When the field name has dot notation we should be using array format as a key path. See discussion [here](jestjs/jest#5653) and usage examples [here](https://github.com/jestjs/jest/blob/main/docs/ExpectAPI.md#tohavepropertykeypath-value). 2. `should fail creating alert when ECS field mapping is geo_point` was failing due to changed error message format.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Failing tests ticket: #154277
This PR fixes the non ECS fields in alert document source failing tests.
There are two failing tests:
should remove source array of keywords field from alert if ECS field mapping is nestedwas filing due to wrong key path format passed to jest'stoHaveProperty. When the field name has dot notation we should be using array format as a key path. See discussion here and usage examples here.should fail creating alert when ECS field mapping is geo_pointwas failing due to changed error message format.